1388432 - RTL Photon download toolbar icon progressbar progresses incorrectly

Status: VERIFIED FIXED

(Firefox :: Downloads Panel, defect, P1)

Description

[Itiel]

Attachment: LTR vs. RTL progress bar

This is a follow-up to bug 1386800.

After bug 1386800's patch has landed, the progressbar on the download icon now starts from the right and finishes at the left on RTL builds, but 2 issues arose that can be seen only during an (active?) download:
1. The right part of the progress bar has gotten a bit longer (and is not curvy anymore), compared to it's left side, and that's probably because of issue #2
2. The progressbar progresses with the curvy part instead of the part with the sharp end

See attached (zoomed-in) screenshot for LTR progressbar (left) vs. RTL progressbar (right).

Comment 1

[Sam Foster [:sfoster] (he/him)]

> 1. The right part of the progress bar has gotten a bit longer (and is not
> curvy anymore), compared to it's left side, and that's probably because of
> issue #2
> 2. The progressbar progresses with the curvy part instead of the part with
> the sharp end

Thanks for spotting that - good eyes. I'll leave this open, but I hope to take care of this in bug 1387557 which touches the same code.

Comment 2

[:Paolo Amadini]

Taking this while bug 1387557 is in the works, since I'm also adjusting the progress bar limits for bug 1296554.

Comment 3

[:Paolo Amadini]

Attachment: Bug 1388432 - Fix progress bar limits and RTL behavior in the Downloads Indicator.

Review commit: https://reviewboard.mozilla.org/r/170750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170750/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8899465 [details]
Bug 1388432 - Fix progress bar limits and RTL behavior in the Downloads Indicator.

https://reviewboard.mozilla.org/r/170750/#review175908

rs=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea8bfe12e651
Fix progress bar limits and RTL behavior in the Downloads Indicator. r=jaws

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ea8bfe12e651

Comment 7

[Itiel]

Unable to verify, the download button is gone, also from the customization panel.
And, for some reason the downloads window (Ctrl+J) is now borderless (using Windows 10). No controls either (Close, Minimize, Maximize).

Is this intended?

Comment 8

[Itiel]

The bug itself is now fixed and the progressbar now progresses correctly also on RTL.

(In reply to ItielMaN from comment #7)
> Unable to verify, the download button is gone, also from the customization
> panel.

That's still an issue (unless intended). The download button appears only if there's an active ongoing download, or if there are item in the preview panel.

(In reply to ItielMaN from comment #7)
> And, for some reason the downloads window (Ctrl+J) is now borderless (using
> Windows 10). No controls either (Close, Minimize, Maximize).

And that one's already fixed by other reported bug.

Comment 9

[Sam Foster [:sfoster] (he/him)]

(In reply to ItielMaN from comment #8)
> (In reply to ItielMaN from comment #7)
> > Unable to verify, the download button is gone, also from the customization
> > panel.
> 
> That's still an issue (unless intended). The download button appears only if
> there's an active ongoing download, or if there are item in the preview
> panel.

This is tracked in bug 1371765.