Implement "Unknown progress" animation on download button

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Downloads Panel
P1
normal
RESOLVED FIXED
a year ago
23 hours ago

People

(Reporter: rexboy, Assigned: Paolo)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [CHE-BACKLOG])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Created attachment 8782788 [details]
preview for "unknown progress" in the download button

Upon the latest visual spec,
when there's only downloading files with unknown process,
we need to display that on the icon of download button.
Specifically, the icon of download icon should become an animation
of a blurred white bars keep dropping down inside the arrow.
Please check the attachment.
(Reporter)

Updated

a year ago
Attachment #8782788 - Attachment description: p.gif → preview for "unknown progress" in the download button
(Reporter)

Updated

a year ago
Summary: Implement "Unknown progress" animation → Implement "Unknown progress" animation on download button
(Assignee)

Comment 1

a year ago
(In reply to KM Lee [:rexboy] from comment #0)
> Please check the attachment.

This doesn't look very visible, is it an issue with the mockup?

We should keep the implementation simple and maintainable, in particular we should avoid adding new icon files. Maybe just animating the opacity of our current icons could still obtain a valid effect, or we can do something more complex with CSS and the assets we already have in the tree.
(Reporter)

Comment 2

a year ago
Hi Carol:
Since I've the visual based on same style issue is still under discussing, I set an needinfo here. You can reply me after confirming the visual. 
If you are going to keep the same design, We may need to produce some SVG filter for that.

Paolo:
I'm not sure if we can make exact the same effect without adding a SVG mask. It's true changing opacity or something makes things simpler but I think we need to ask for visual team's comment about that.
Flags: needinfo?(chuang)
(Reporter)

Updated

a year ago
No longer blocks: 1270012
still confirming if this is a project MVP, move it to backlog
Whiteboard: [CHE-MVP] → [CHE-BACKLOG]
(Assignee)

Comment 4

a year ago
This is a long-standing quality issue with the Downloads Indicator, we show no indication that a download is in progress if the server does not send the size. Seeing this bug fixed when we switch to the new design would be great and provide definite user value.

Comment 5

11 months ago
(In reply to KM Lee [:rexboy] from comment #2)
> Hi Carol:
> Since I've the visual based on same style issue is still under discussing, I
> set an needinfo here. You can reply me after confirming the visual. 
> If you are going to keep the same design, We may need to produce some SVG
> filter for that.

Hi Rex, I've updated the motion mock-up and spec on Bug 1269956 for "unknown progress"
We can discuss what assets you need to create the animation when you start working on this. thanks!


> Paolo:
> I'm not sure if we can make exact the same effect without adding a SVG mask.
> It's true changing opacity or something makes things simpler but I think we
> need to ask for visual team's comment about that.
Flags: needinfo?(chuang)
(Assignee)

Updated

10 months ago
Priority: -- → P3
(Reporter)

Updated

9 months ago
Assignee: nobody → rexboy
(Assignee)

Updated

3 months ago
Duplicate of this bug: 1363734
(Assignee)

Updated

3 months ago
Duplicate of this bug: 1352350
(Assignee)

Updated

3 months ago
Duplicate of this bug: 955936
(Assignee)

Updated

a day ago
Assignee: rexboy → paolo.mozmail
Status: NEW → ASSIGNED
Depends on: 1388432
Priority: P3 → P1
(Assignee)

Comment 9

a day ago
With the Photon design for the Downloads Indicator we can easily display the in-progress state for downloads of an unknown size, without any special design treatment like we'd have needed when we filled the arrow vertically.
Comment hidden (mozreview-request)
(Assignee)

Comment 11

a day ago
This can be tested with <https://httpbin.org/stream-bytes/102400>, although currently there is a size limit and the download is quite fast, so the best way to see an effect is to paste the link in the Library window.

Comment 12

a day ago
mozreview-review
Comment on attachment 8899468 [details]
Bug 1296554 - Show a static progress bar for downloads of unknown size.

https://reviewboard.mozilla.org/r/170754/#review175936

I talked with Amy Lee and she was OK with this approach.
Attachment #8899468 - Flags: review?(jaws) → review+
<amylee> @jaws My recommendation would have the icon remain grey until the download is completed and then it goes blue at that point and plays the end animation

Comment 14

a day ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75eda325afa7
Show a static progress bar for downloads of unknown size. r=jaws

Comment 15

23 hours ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/75eda325afa7
Status: ASSIGNED → RESOLVED
Last Resolved: 23 hours ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.