1388512 - browser_menu_touch.js fails to run on windows 10

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in trying to green up tests on windows10, I find a test that is written specifically for windows 10 and doesn't run for me locally.

I get a failure at this location:
http://searchfox.org/mozilla-central/source/browser/base/content/test/touch/browser_menu_touch.js#75

which is this part of the test:
// Test the page action menu.
add_task(async function test_page_action_panel_touch() {
  let pageActionPanel = document.getElementById("page-action-panel");
  let target = document.getElementById("urlbar-page-action-button");
  await openAndCheckMenu(pageActionPanel, target);
});

if I remove this task, the test completes just fine.  In searching the source code for |urlbar-page-action-button|, I do not find any other reference, just line 74 in the test file.

I would like to figure this out and allow the test to run if possible- there are 3 test files that fail on windows 10 browser-chrome, this is one of them.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

:johannh, I see that you authored the patch which added this test, is there any chance you could elaborate on this specific element?

Comment 2

[Johann Hofmann [:johannh]]

Ah, this element was renamed in bug 1374477 but they obviously didn't fix the test because the test was already failing. I'll fix it up.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1388512 - Fix browser_menu_touch.js on Windows 10.

This test was failing because we need to set an additional
pref to make our Windows 10 test infra support touch events,
and because some elements it was testing got renamed.

Review commit: https://reviewboard.mozilla.org/r/168276/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168276/

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8896972 [details]
Bug 1388512 - Fix browser_menu_touch.js on Windows 10.

https://reviewboard.mozilla.org/r/168276/#review173464

thanks!

Comment 5

[Johann Hofmann [:johannh]]

Not sure why I ran a try for this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e68884b52cc0
Fix browser_menu_touch.js on Windows 10. r=jmaher

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e68884b52cc0