browser_menu_touch.js fails to run on windows 10

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Theme
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: jmaher, Assigned: johannh)

Tracking

53 Branch
Firefox 57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
in trying to green up tests on windows10, I find a test that is written specifically for windows 10 and doesn't run for me locally.

I get a failure at this location:
http://searchfox.org/mozilla-central/source/browser/base/content/test/touch/browser_menu_touch.js#75

which is this part of the test:
// Test the page action menu.
add_task(async function test_page_action_panel_touch() {
  let pageActionPanel = document.getElementById("page-action-panel");
  let target = document.getElementById("urlbar-page-action-button");
  await openAndCheckMenu(pageActionPanel, target);
});

if I remove this task, the test completes just fine.  In searching the source code for |urlbar-page-action-button|, I do not find any other reference, just line 74 in the test file.

I would like to figure this out and allow the test to run if possible- there are 3 test files that fail on windows 10 browser-chrome, this is one of them.
(Reporter)

Comment 1

11 months ago
:johannh, I see that you authored the patch which added this test, is there any chance you could elaborate on this specific element?
Flags: needinfo?(jhofmann)
(Assignee)

Comment 2

10 months ago
Ah, this element was renamed in bug 1374477 but they obviously didn't fix the test because the test was already failing. I'll fix it up.
Flags: needinfo?(jhofmann)
(Assignee)

Updated

10 months ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Reporter)

Comment 4

10 months ago
mozreview-review
Comment on attachment 8896972 [details]
Bug 1388512 - Fix browser_menu_touch.js on Windows 10.

https://reviewboard.mozilla.org/r/168276/#review173464

thanks!
Attachment #8896972 - Flags: review?(jmaher) → review+
(Assignee)

Comment 5

10 months ago
Not sure why I ran a try for this.

Comment 6

10 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e68884b52cc0
Fix browser_menu_touch.js on Windows 10. r=jmaher

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e68884b52cc0
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.