1388565 - Allow core profiles for webgl1 (at least osx)

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - Add webgl.1.allow-core-profiles, enabled for osx. -

Review commit: https://reviewboard.mozilla.org/r/166278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166278/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. -

Review commit: https://reviewboard.mozilla.org/r/166280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166280/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

Review commit: https://reviewboard.mozilla.org/r/166282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166282/

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - shader_texture_lod is core in GL3 and ES3. -

Review commit: https://reviewboard.mozilla.org/r/166284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166284/

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8895151 [details]
Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

https://reviewboard.mozilla.org/r/166282/#review171518

LGTM

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8895151 [details]
Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

https://reviewboard.mozilla.org/r/166282/#review171520

LGTM

Comment 7

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8895152 [details]
Bug 1388565 - shader_texture_lod is core in GL3 and ES3. -

https://reviewboard.mozilla.org/r/166284/#review171526

LGTM

Comment 8

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8895150 [details]
Bug 1388565 - Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. -

https://reviewboard.mozilla.org/r/166280/#review171528

Comment 9

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8895149 [details]
Bug 1388565 - Add webgl.1.allow-core-profiles, enabled for osx. -

https://reviewboard.mozilla.org/r/166278/#review171530

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - Mark tests.

Review commit: https://reviewboard.mozilla.org/r/166824/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166824/

Comment 11

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895151 [details]
Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166282/diff/1-2/

Comment 12

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895152 [details]
Bug 1388565 - shader_texture_lod is core in GL3 and ES3. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166284/diff/1-2/

Comment 13

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - Improve driver-info.js. -

Review commit: https://reviewboard.mozilla.org/r/168522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168522/

Comment 14

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1388565 - Mark Mac+Intel as handling no-array draw-elements well.

Review commit: https://reviewboard.mozilla.org/r/168524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168524/

Comment 15

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e9890f65e5456e29f946d0fcdc9bc3e84c44c3e

Comment 16

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8897240 [details]
Bug 1388565 - Improve driver-info.js. -

https://reviewboard.mozilla.org/r/168522/#review174228

LGTM. please think about if need to add a log inside the catch{}.

::: dom/canvas/test/webgl-mochitest/driver-info.js:58
(Diff revision 1)
>        os = OS.ANDROID;
> +
> +      try {
> -      // From layout/tools/reftest/reftest.js:
> +        // From layout/tools/reftest/reftest.js:
> -      version = SpecialPowers.Services.sysinfo.getProperty('version');
> +        version = SpecialPowers.Services.sysinfo.getProperty('version');
> +      } catch (e) { }

I would like to suggest giving a log here. Or, at least, please remove this redundant space inside this {} scope.

Comment 17

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895149 [details]
Bug 1388565 - Add webgl.1.allow-core-profiles, enabled for osx. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166278/diff/1-2/

Comment 18

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895150 [details]
Bug 1388565 - Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166280/diff/1-2/

Comment 19

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895151 [details]
Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166282/diff/2-3/

Comment 20

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895152 [details]
Bug 1388565 - shader_texture_lod is core in GL3 and ES3. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166284/diff/2-3/

Comment 21

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8895606 [details]
Bug 1388565 - Mark tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166824/diff/1-2/

Comment 22

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8897240 [details]
Bug 1388565 - Improve driver-info.js. -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168522/diff/1-2/

Comment 23

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8897241 [details]
Bug 1388565 - Mark Mac+Intel as handling no-array draw-elements well.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168524/diff/1-2/

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2ce02c6789
Add webgl.1.allow-core-profiles, enabled for osx. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1c3cdb523c
Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/a18190f3d0ce
Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/744b98533cf2
shader_texture_lod is core in GL3 and ES3. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/01e8880a38d8
Mark tests.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ab7991eac91
Improve driver-info.js. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/49259b3833d7
Mark Mac+Intel as handling no-array draw-elements well.

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d2ce02c6789
https://hg.mozilla.org/mozilla-central/rev/5e1c3cdb523c
https://hg.mozilla.org/mozilla-central/rev/a18190f3d0ce
https://hg.mozilla.org/mozilla-central/rev/744b98533cf2
https://hg.mozilla.org/mozilla-central/rev/01e8880a38d8
https://hg.mozilla.org/mozilla-central/rev/4ab7991eac91
https://hg.mozilla.org/mozilla-central/rev/49259b3833d7