Closed
Bug 1388565
Opened 7 years ago
Closed 7 years ago
Allow core profiles for webgl1 (at least osx)
Categories
(Core :: Graphics: CanvasWebGL, enhancement, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
References
(Depends on 1 open bug)
Details
(Whiteboard: gfx-noted)
Attachments
(7 files)
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
Details | |
|
59 bytes,
text/x-review-board-request
|
daoshengmu
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
Details |
No description provided.| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895151 [details] Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. - https://reviewboard.mozilla.org/r/166282/#review171518 LGTM
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895151 [details] Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. - https://reviewboard.mozilla.org/r/166282/#review171520 LGTM
Attachment #8895151 -
Flags: review?(dmu) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895152 [details] Bug 1388565 - shader_texture_lod is core in GL3 and ES3. - https://reviewboard.mozilla.org/r/166284/#review171526 LGTM
Attachment #8895152 -
Flags: review?(dmu) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895150 [details] Bug 1388565 - Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. - https://reviewboard.mozilla.org/r/166280/#review171528
Attachment #8895150 -
Flags: review?(dmu) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895149 [details] Bug 1388565 - Add webgl.1.allow-core-profiles, enabled for osx. - https://reviewboard.mozilla.org/r/166278/#review171530
Attachment #8895149 -
Flags: review?(dmu) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 15•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e9890f65e5456e29f946d0fcdc9bc3e84c44c3e
|
|
||
Comment 16•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8897240 [details] Bug 1388565 - Improve driver-info.js. - https://reviewboard.mozilla.org/r/168522/#review174228 LGTM. please think about if need to add a log inside the catch{}. ::: dom/canvas/test/webgl-mochitest/driver-info.js:58 (Diff revision 1) > os = OS.ANDROID; > + > + try { > - // From layout/tools/reftest/reftest.js: > + // From layout/tools/reftest/reftest.js: > - version = SpecialPowers.Services.sysinfo.getProperty('version'); > + version = SpecialPowers.Services.sysinfo.getProperty('version'); > + } catch (e) { } I would like to suggest giving a log here. Or, at least, please remove this redundant space inside this {} scope.
Attachment #8897240 -
Flags: review?(dmu) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 24•7 years ago
|
||
Pushed by jgilbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2ce02c6789 Add webgl.1.allow-core-profiles, enabled for osx. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1c3cdb523c Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/a18190f3d0ce Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/744b98533cf2 shader_texture_lod is core in GL3 and ES3. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/01e8880a38d8 Mark tests. https://hg.mozilla.org/integration/mozilla-inbound/rev/4ab7991eac91 Improve driver-info.js. - r=daoshengmu https://hg.mozilla.org/integration/mozilla-inbound/rev/49259b3833d7 Mark Mac+Intel as handling no-array draw-elements well.
|
||
Comment 25•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5d2ce02c6789 https://hg.mozilla.org/mozilla-central/rev/5e1c3cdb523c https://hg.mozilla.org/mozilla-central/rev/a18190f3d0ce https://hg.mozilla.org/mozilla-central/rev/744b98533cf2 https://hg.mozilla.org/mozilla-central/rev/01e8880a38d8 https://hg.mozilla.org/mozilla-central/rev/4ab7991eac91 https://hg.mozilla.org/mozilla-central/rev/49259b3833d7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•