Allow core profiles for webgl1 (at least osx)

RESOLVED FIXED in Firefox 57

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
15 days ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

(Depends on 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: gfx-noted)

Attachments

(7 attachments)

No description provided.
Comment on attachment 8895151 [details]
Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

https://reviewboard.mozilla.org/r/166282/#review171518

LGTM
Comment on attachment 8895151 [details]
Bug 1388565 - Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. -

https://reviewboard.mozilla.org/r/166282/#review171520

LGTM
Attachment #8895151 - Flags: review?(dmu) → review+
Comment on attachment 8895152 [details]
Bug 1388565 - shader_texture_lod is core in GL3 and ES3. -

https://reviewboard.mozilla.org/r/166284/#review171526

LGTM
Attachment #8895152 - Flags: review?(dmu) → review+
Comment on attachment 8895150 [details]
Bug 1388565 - Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. -

https://reviewboard.mozilla.org/r/166280/#review171528
Attachment #8895150 - Flags: review?(dmu) → review+
Comment on attachment 8895149 [details]
Bug 1388565 - Add webgl.1.allow-core-profiles, enabled for osx. -

https://reviewboard.mozilla.org/r/166278/#review171530
Attachment #8895149 - Flags: review?(dmu) → review+
Comment on attachment 8897240 [details]
Bug 1388565 - Improve driver-info.js. -

https://reviewboard.mozilla.org/r/168522/#review174228

LGTM. please think about if need to add a log inside the catch{}.

::: dom/canvas/test/webgl-mochitest/driver-info.js:58
(Diff revision 1)
>        os = OS.ANDROID;
> +
> +      try {
> -      // From layout/tools/reftest/reftest.js:
> +        // From layout/tools/reftest/reftest.js:
> -      version = SpecialPowers.Services.sysinfo.getProperty('version');
> +        version = SpecialPowers.Services.sysinfo.getProperty('version');
> +      } catch (e) { }

I would like to suggest giving a log here. Or, at least, please remove this redundant space inside this {} scope.
Attachment #8897240 - Flags: review?(dmu) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2ce02c6789
Add webgl.1.allow-core-profiles, enabled for osx. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1c3cdb523c
Use GLFeature::draw_buffers for WEBGL_draw_buffers IsSupported. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/a18190f3d0ce
Fix WEBGL_compressed_texture_s3tc_srgb driver requirements. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/744b98533cf2
shader_texture_lod is core in GL3 and ES3. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/01e8880a38d8
Mark tests.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ab7991eac91
Improve driver-info.js. - r=daoshengmu
https://hg.mozilla.org/integration/mozilla-inbound/rev/49259b3833d7
Mark Mac+Intel as handling no-array draw-elements well.
Depends on: 1513207
You need to log in before you can comment on or make changes to this bug.