Closed
Bug 1388745
Opened 7 years ago
Closed 7 years ago
Some search results are not highlighted
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | verified |
firefox57 | --- | verified |
People
(Reporter: phorea, Assigned: rickychien)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [photon-preference])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
mconley
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
[Affected versions]: - Firefox 56 beta 1 build 5 - Nightly 57.0a1 2017-08-09 [Affected platforms]: - Win 10 64-bit - Ubuntu 16.04 64-bit - Mac OS X 10.13 [Steps to reproduce]: 1. Open about:preferences 2. On Search text field enter "find" or "find more" [Expected result]: - "Find (more search engine)" link is highlighted [Actual result]: - One-click Search Engines section is shown, but the searched text is not highlighted [Regression range]: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85928fde7206dbd063b4ef7c656eb7e5e835a770&tochange=5654a60499973490633adb7eb715467a99894622 [Notes]: - "Add more search engines" text that was displayed before the change was highlighted.
Updated•7 years ago
|
Whiteboard: [photon-preference][triage]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
QA Contact: hani.yacoub
Target Milestone: --- → Firefox 56
Updated•7 years ago
|
Whiteboard: [photon-preference][triage] → [photon-preference]
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8895754 [details] Bug 1388745 - Make "find more search engines" label highlightable https://reviewboard.mozilla.org/r/167082/#review172446 Thanks!
Attachment #8895754 -
Flags: review?(mconley) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb64c2d8c456 Make "find more search engines" label highlightable r=mconley
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb64c2d8c456
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 5•7 years ago
|
||
Please request Beta approval on this when you get a chance.
status-firefox-esr52:
--- → unaffected
Flags: needinfo?(rchien)
Target Milestone: Firefox 56 → Firefox 57
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8895754 [details] Bug 1388745 - Make "find more search engines" label highlightable Approval Request Comment [Feature/Bug causing the regression]: Bug 1365133 [User impact if declined]: minor, a small functionality broken. [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not yet [Needs manual test from QE? If yes, steps to reproduce]: see description [List of other uplifts needed for the feature/fix]: no [Is the change risky?]: no [Why is the change risky/not risky?]: a small functionality broken [String changes made/needed]: no
Flags: needinfo?(rchien)
Attachment #8895754 -
Flags: approval-mozilla-beta?
Comment 7•7 years ago
|
||
Hi Petruta, Can you help check if this issue was fixed in the latest nightly? Thanks.
Flags: needinfo?(petruta.rasa)
Comment 8•7 years ago
|
||
Comment on attachment 8895754 [details] Bug 1388745 - Make "find more search engines" label highlightable Simple css fix, let's uplift this to beta.
Attachment #8895754 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/2da5df1a3bdf
Reporter | ||
Comment 10•7 years ago
|
||
Verified as fixed using Nightly 57.0a1 2017-08-16 under Win 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.12. The fix didn't reach 56.0b3. Ricky, while verifying this bug I saw that "Learn more" link from Site Data section is not highlighted on Nightly. Should I file a new bug for this or is it tracked somewhere? Thank you!
Assignee | ||
Comment 11•7 years ago
|
||
Yes, please file a bug. I'll deal with that. Thanks
Flags: needinfo?(petruta.rasa)
Reporter | ||
Comment 12•7 years ago
|
||
Thanks! I filed bug 1390895 for that issue.
Flags: needinfo?(petruta.rasa)
Updated•6 years ago
|
Flags: in-qa-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•