1388745 - Some search results are not highlighted

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

[Affected versions]:
- Firefox 56 beta 1 build 5
- Nightly 57.0a1 2017-08-09

[Affected platforms]:
- Win 10 64-bit
- Ubuntu 16.04 64-bit
- Mac OS X 10.13

[Steps to reproduce]:
1. Open about:preferences
2. On Search text field enter "find" or "find more"

[Expected result]:
- "Find (more search engine)" link is highlighted

[Actual result]:
- One-click Search Engines section is shown, but the searched text is not highlighted

[Regression range]:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=85928fde7206dbd063b4ef7c656eb7e5e835a770&tochange=5654a60499973490633adb7eb715467a99894622

[Notes]:
- "Add more search engines" text that was displayed before the change was highlighted.

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1388745 - Make "find more search engines" label highlightable

Review commit: https://reviewboard.mozilla.org/r/167082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/167082/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8895754 [details]
Bug 1388745 - Make "find more search engines" label highlightable

https://reviewboard.mozilla.org/r/167082/#review172446

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb64c2d8c456
Make "find more search engines" label highlightable r=mconley

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb64c2d8c456

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8895754 [details]
Bug 1388745 - Make "find more search engines" label highlightable

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1365133
[User impact if declined]: minor, a small functionality broken.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see description
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: a small functionality broken
[String changes made/needed]: no

Comment 7

[Gerry Chang [:gchang]]

Hi Petruta,
Can you help check if this issue was fixed in the latest nightly? Thanks.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8895754 [details]
Bug 1388745 - Make "find more search engines" label highlightable

Simple css fix, let's uplift this to beta.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2da5df1a3bdf

Comment 10

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Nightly 57.0a1 2017-08-16 under Win 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.12.
The fix didn't reach 56.0b3.

Ricky, while verifying this bug I saw that "Learn more" link from Site Data section is not highlighted on Nightly. Should I file a new bug for this or is it tracked somewhere? Thank you!

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Yes, please file a bug. I'll deal with that. Thanks

Comment 12

[Petruta Horea [:phorea], Desktop Test Engineering]

Thanks! I filed bug 1390895 for that issue.

Comment 13

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as  fixed using 56.0b4 across platforms.