1388761 - The "about:addons" section has not been updated for Photon UI

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[u597134]

Attachment: Screenshot.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170809100326

Steps to reproduce:

Opened "about:addons" by clicking the "Add-ons" section in the Firefox menu.


Actual results:

I saw the Australis theme for the "about:addons" with black text for the left panel.


Expected results:

I should have seen the Photon UI look for "about:addons".

Comment 1

[Dão Gottwald [:dao]]

This should be part of photon-preference. We need to consistently make design changes in common.inc.css rather than just preferences.css.

Comment 2

[Mauro Sanabria]

Checking all links in about:about only a handful show side tabs; of these only about:preferences got the full new look while the others are affected by a dark tab background with black (darker?) letters, at least:

* about:addons
* about:debugging
* about:networking
* about:telemetry

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1388761 - Update category styling in common.css.

Review commit: https://reviewboard.mozilla.org/r/166710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166710/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8895510 [details]
Bug 1388761 - Update category styling in common.css.

https://reviewboard.mozilla.org/r/166710/#review171874

Thanks Tim!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54375b69ac4a
Update category styling in common.css. r=dao

Comment 6

[Evan Tseng [:evanxd]]

Hi Tim,

According to the updated preferences photon visual spec[1], the `--in-content-page-background` color should be `#F9F9Fa` not `#fafafc`. The spec is just updated. I will update the background color at Bug 1389002.

Thank you for updating the preferences's css.

[1]: https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/244683005

Comment 7

[Evan Tseng [:evanxd]]

And I think we might also need to update the background color of `#categories` selector. I'll also update it at Bug 1389002.

[1]: http://searchfox.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#640

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54375b69ac4a

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-11), so I'm marking this bug as VERIFIED. Thanks.