Closed Bug 1388942 Opened 9 years ago Closed 8 years ago

Search doesn't find SUMO KB articles for some common terms such as "profile", "extension", "install" or "feature".

Categories

(support.mozilla.org :: Search, defect, P2)

Product:
support.mozilla.org
Component:
Search
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rolandtanglao, Unassigned)

References

Details

Attachments

(2 files)

Screenshot-2017-8-9 Mozilla Support.png
662.37 KB, image/png
Details
Tracelog of failing tests
96.80 KB, text/plain
Details
Steps to Reproduce 1. surf to support.mozilla.org 2. In the search box at the top write type: create profile 3. Click on "HELP ARTICLES ONLY" on the left sidebar 4. Click on "FIREFOX" Expected Result: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles [1] shows up in the top 3 search results Actual Result [1] is not shown at all in search results (see attached screenshot) and the error message "We couldn't find any results for create profile in English. Maybe one of these articles will be helpful? " is displayed
Roland, Can you specify from when you are seeing the issue? Were it working in the past?
(In reply to Safwan Rahman (:safwan) from comment #1) > Roland, Can you specify from when you are seeing the issue? > Were it working in the past? i have no idea whether it was working in the past, I think joni said worked in the past with kitsune
setting to P2 to be considered for the next sprint, :madalina and :joni do you agree with P2 and getting Ben's team to look at it in the next sprint?
Flags: needinfo?(mana)
Flags: needinfo?(jsavage)
Priority: -- → P2
A search for "profile" or "profiles" produces no help articles, although https://support.mozilla.org/en-US/contributors/kb-overview shows these articles: https://support.mozilla.org/en-US/kb/profiles-where-firefox-stores-user-data https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles (already mentioned by Roland) https://support.mozilla.org/en-US/kb/profiles-where-thunderbird-stores-user-data https://support.mozilla.org/en-US/kb/back-and-restore-information-firefox-profiles https://support.mozilla.org/en-US/kb/using-multiple-profiles A search of help articles also produces no results for "extension" or "extensions", even though it's a common term in KB articles and is in the title of a number of articles, including https://support.mozilla.org/en-US/kb/troubleshoot-extensions-themes-to-fix-problems https://support.mozilla.org/en-US/kb/unable-install-add-ons-extensions-or-themes https://support.mozilla.org/en-US/kb/cannot-remove-add-on-extension-or-theme I also tried using Advanced search with no results: https://support.mozilla.org/en-US/search/advanced?q=profile&language=en-US&sortby_documents=relevance&a=1&w=1 https://support.mozilla.org/en-US/search/advanced?q=extensions&language=en-US&sortby_documents=relevance&a=1&w=1 This came up in https://support.mozilla.org/en-US/kb/firefox-add-technology-modernizing/discuss/7116#post-15281 where Tonnes wrote the following: "it’s funny to see the search works for e.g. "plugins", "products" or even "addons" when spelled without a hyphen, so it may be related to the word itself. Perhaps its score is just too high, causing the bug? Also, I’m sure it did work in the past for finding profile related articles, and when searching for "profielen" in my locale, it works." Search issues for localized articles was reported 2017-07-31 in bug 1385825.
See Also: → 1385825
A SUMO search also doesn't find any help articles for "install" or "feature", even though we have many KB articles with those words in the title. Roland, should the bug summary be updated to something like the following? Search doesn't find SUMO KB articles for some common terms such as "profile", "extension", "install" or "feature". It looks like this problem began sometime after June 23, 2017. That's when the term "WebExtensions" was added to the search summary for the article https://support.mozilla.org/en-US/kb/firefox-add-technology-modernizing and search then worked. A search for "WebExtensions" no longer worked on August 15, 2017 and still doesn't.
Flags: needinfo?(rtanglao)
Roland, P2 sounds good to me.
Flags: needinfo?(mana)
Flags: needinfo?(rtanglao)
Summary: search doesn't find "create profile" SUMO KB article → Search doesn't find SUMO KB articles for some common terms such as "profile", "extension", "install" or "feature".
:bensternthal and :giorgos could you please take a look at that bug and fix it in this sprint ?
Flags: needinfo?(giorgos)
Flags: needinfo?(bsternthal)
Roland: I am meeting with Patrick next week to understand the priority of a couple tasks that have come up. I can let you know when we would look at this after that. Also note, we don't sprint on this project.. at least not currently :)
Flags: needinfo?(giorgos)
Flags: needinfo?(bsternthal)
So I have run the tests of search application of kitsune and some tests are failing after upgrading the elasticsearch to 2.4.x The tracelog is attached. failure of `test_search_products` and `test_search_multiple_products` seems to be related of this issue. With elasticsearch 1.x, none of the test were failing. So I think we need to fix something in the search functionality for upgrading elasticsearch 2.x
(In reply to Safwan Rahman (:safwan) from comment #9) > Created attachment 8900006 [details] > Tracelog of failing tests > > So I have run the tests of search application of kitsune and some tests are > failing after upgrading the elasticsearch to 2.4.x > > The tracelog is attached. > > failure of `test_search_products` and `test_search_multiple_products` seems > to be related of this issue. > > With elasticsearch 1.x, none of the test were failing. So I think we need to > fix something in the search functionality for upgrading elasticsearch 2.x The stemming/analyzer tests fail because they use facets to test the results. Facets have been replaced with aggregations in ESv2 and those tests need to be re-written. I'm still investigating the "advanced search" test.
See Also: → 1394388
Commit pushed to master at https://github.com/mozilla/kitsune https://github.com/mozilla/kitsune/commit/c7fd9d1d6b867a0feffe826026d1ec3d1ce9fb09 [bug 1388942] Remove support for ES synonyms. Synonyms in ESv2 are broken. We remove support to make the search work again. See also https://bugzilla.mozilla.org/show_bug.cgi?id=1394388 for analysis.
It appears that the error is related to the synonym support for ElasticSearch. I've filed bug 1394388 to fix it in the future. Meanwhile I removed support for english synonyms and the document searches appear to be working again. Roland can you please verify?
Flags: needinfo?(rtanglao)
looks good to me i.e. it works on "profile", "install" and "feature"
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(rtanglao)
Resolution: --- → FIXED
just in case, alice can you do a quick test to confirm please?
Flags: needinfo?(alice.wyman)
clearing joni's needinfo which is obsolete since this problem is fixed in my testing!
Flags: needinfo?(jsavage)
(In reply to Roland Tanglao :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland from comment #14) > just in case, alice can you do a quick test to confirm please? Yes, it works now. Besides "profile" "install" and "feature", searching for "extension" and "webextension" also works. So do searches on "hardware" and "acceleration", both of which were also broken a few days ago.
Flags: needinfo?(alice.wyman)
(In reply to Alice Wyman from comment #16) > (In reply to Roland Tanglao :rolandtanglao, :mohnkuchen, :adobo, :sinigang, > :roland from comment #14) > > just in case, alice can you do a quick test to confirm please? > > Yes, it works now. Besides "profile" "install" and "feature", searching for > "extension" and "webextension" also works. So do searches on "hardware" and > "acceleration", both of which were also broken a few days ago. thanks to giorgos, alice and safwan for their fab work on getting this bug reported, fixed and tested!
See Also: → 1395662
SUMO search is broken again. Using the terms "profile", "extension", "install", and "feature" all produce the message, "We couldn't find any results for ..." both via normal search "for help articles only" and via Advanced search. A search for "website" or "update" also fails: https://support.mozilla.org/en-US/search/advanced?q=update&language=en-US&sortby_documents=relevance&a=1&w=1 https://support.mozilla.org/en-US/search/advanced?q=website&language=en-US&sortby_documents=relevance&a=1&w=1 The "most visited" list at https://support.mozilla.org/en-US/contributors/most-visited shows numerous KB articles with those terms in the title.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Flags: needinfo?(giorgos)
Severity: normal → major
An update: Giorgos and I have been looking into this but have yet to find the issue or the reason for it. We're continuing the work. Apologies for the delay.
OK so I was not able to get the real reason behind this search issue. It appears that we're using the Snowball Analyzer which is available in ES v2.4 [0], similarly to ESv1 we're using before. kitsune.search.get_analysis returns a valid set of filters and analyzers for the supported SUMO languages and ES is happy to load this configuration and run searches, but it does not return results for Documents. Changing the analyzer from 'snowball' to 'standard' appears to be fixing the issue, although that may result in lower quality results _only if_ 'snowball' worked in the first place. What I did was directly alter the ES settings using the following commands: from kitsune.search.es_utils import get_analysis analysis = get_analysis() index = write_index('default') for key, value in analysis['analyzer'].items(): analysis['analyzer'][key]['type'] = 'standard' es.indices.close(index) es.indices.put_settings(index=index, body={'analysis': analysis}) es.indices.open(index) With this change English search for 'profile' returns 71 results [1] and Italian search for 'profilo' [2] returns 66 results. Both of them where failing to return any results before. [0] https://www.elastic.co/guide/en/elasticsearch/reference/2.4/analysis-snowball-analyzer.html [1] https://support.mozilla.org/en-US/search/advanced?q=profile&language=en-US&sortby_documents=relevance&a=1&w=1 [2] https://support.mozilla.org/en-US/search/advanced?q=profilo&language=it&sortby_documents=relevance&a=1&w=1
Flags: needinfo?(giorgos)
Moments after writing comment #20 I realized that changing the analyzer to 'standard' from 'snowball' fixes the Document searching but breaks the Question searching. Looking deeper and after testing I concluded that ESv2 needs to have snowball analyzer defined in the document mapping. Questions appear to have it [0] while Documents do not [1]. I run small test by 1. creating a new default index in the admin node by adding ES_INDEXES['default'] = 'sumo_20170922' to settings_local.py 2. making code changes to include 'snowball' in the Wiki Document definition [2] 3. Reverting the synonyms change 4. Indexing and small percentage of documents with ./manage.py esreindex --mapping_type=wiki_document --percent=1 --delete and then searching using 5. ./manage.py essearch "profile" (you may need to set ALLOWED_HOSTS='*' first, but don't forget to revert back) And I get results when I was not getting before. I'll proceed with reindexing documents with the new mapping definition and see how that works. [0] https://github.com/mozilla/kitsune/blob/master/kitsune/questions/models.py#L712 [1] https://github.com/mozilla/kitsune/blob/master/kitsune/wiki/models.py#L713 [2] https://github.com/mozilla/kitsune/commit/e68e5e6a66be17fed6263398dc63fd93e7921908
wfm clearing needinfo!
Flags: needinfo?(rtanglao)
It also works for me.
Flags: needinfo?(alice.wyman)
Marking this one fixed. Thanks all!
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Commits pushed to master at https://github.com/mozilla/kitsune https://github.com/mozilla/kitsune/commit/888418a796daaa42417260ba08ca29231ed2305a Revert "[bug 1388942] Remove support for ES synonyms." This reverts commit c7fd9d1d6b867a0feffe826026d1ec3d1ce9fb09. https://github.com/mozilla/kitsune/commit/e68e5e6a66be17fed6263398dc63fd93e7921908 [bug 1388942] Add snowball analyzer in document mapping. https://github.com/mozilla/kitsune/commit/ca17bd2013f5a6041ffd9f5c2eba8fbfd092a0d6 Merge pull request #2919 from mozilla/snowball-fix [bug 1388942] Add snowball analyzer in document mapping
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: