1389034 - Clean up erroneously saved addon-bar placements

Status: RESOLVED DUPLICATE of bug 1428938

(Firefox :: Toolbars and Customization, defect, P4)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #956731 +++

See bug 956731 comment 6:

> > > Please also add a migration step into `_introduceNewBuiltinWidgets` (feel
> > > free to rename that method, its use has evolved so the name is kinda
> > > terrible now) to remove any saved placements for the area.
> > 
> > Given the addonbar-delegating thingy, why would there be any saved
> > placements?
> 
> I don't know exactly and haven't had time to dive into it, but I certainly
> see the placements being saved by just starting nightly on a clean profile.
> I expect something else is broken (like only saving customized areas, or
> something, or perhaps the migration from persisted currentsets?), but either
> way we'll need to clean up given that we would otherwise keep the
> information forever.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Dupe or related to bug 1411372? 

Are there irreversible consequences to shipping 57 without a fix for this? If I read understand #0 correctly, I think not. But I'm hesitant to give this a priority (and drop it off the triage lists) without confirming that.

Comment 2

[Mike de Boer [:mikedeboer]]

I don't think there are severe irreversible consequences to ship without this. I'll put it in the triage backlog to see if we can take this soonish.

Comment 3

[:Gijs (he/him)]

Yeah, this isn't important, certainly not for 57. It's basically mostly cleanup, though there's an opportunity for some improvement as well, by ensuring we save the minimal amount necessary in prefs, and/or switch to a better storage system for this data.

Comment 4

[:Gijs (he/him)]

bug 1428938 will remove these placements. I'm not sure it's worth trying harder to avoid saving unchanged placements to prefs.