956731 - Remove add-on bar and statusbar shims

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

Filing this bug for organizational purposes. The add-on bar and the statusbar have already been removed from the UI. And if the current line of work is to be followed, their shims, currently in place to allow a better transition when Australis hits release, will be removed as well sometime after that.

I'm personally interested in exactly when this happens, and I'm sure other add-on developers will soon be as well. So I propose using this bug for this specific (future) work. (sorry if this is a duplicate, couldn't find it)

Comment 1

[Dave Garrett]

The current kludge inside the main "navigator-toolbox" toolbar:
https://hg.mozilla.org/mozilla-central/file/bafaf8d078d8/browser/base/content/browser.xul#l899
   899     <!-- This is a shim which will go away ASAP. See bug 749804 for details -->
   900     <toolbar id="addon-bar" toolbar-delegate="nav-bar" mode="icons" iconsize="small">
   901       <hbox id="addonbar-closebutton"/>
   902       <statusbar id="status-bar"/>
   903     </toolbar>

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 956731 - Remove legacy add-on bar and statusbar shims.

Review commit: https://reviewboard.mozilla.org/r/166982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166982/

Comment 3

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2cbf1e8acc514d5dce85ad7bc0d5155a8a4b9476

Comment 4

[:Gijs (he/him)]

Comment on attachment 8895696 [details]
Bug 956731 - Remove legacy add-on bar and statusbar shims.

https://reviewboard.mozilla.org/r/166982/#review172170

Yaaay.

Can you file a followup to remove https://hg.mozilla.org/mozilla-central/file/tip/services/sync/tps/extensions/mozmill/resource/stdlib/utils.js#l278 ? I don't think any toolkit apps have an add-on bar...

::: browser/components/customizableui/CustomizableUI.jsm
(Diff revision 1)
>          "personal-bookmarks",
>        ],
>        defaultCollapsed: true,
>      }, true);
>  
> -    this.registerArea(CustomizableUI.AREA_ADDONBAR, {

Please also add a migration step into `_introduceNewBuiltinWidgets` (feel free to rename that method, its use has evolved so the name is kinda terrible now) to remove any saved placements for the area.

Comment 5

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #4)
> Please also add a migration step into `_introduceNewBuiltinWidgets` (feel
> free to rename that method, its use has evolved so the name is kinda
> terrible now) to remove any saved placements for the area.

Given the addonbar-delegating thingy, why would there be any saved placements?

Comment 6

[:Gijs (he/him)]

(In reply to Dão Gottwald [::dao] from comment #5)
> (In reply to :Gijs from comment #4)
> > Please also add a migration step into `_introduceNewBuiltinWidgets` (feel
> > free to rename that method, its use has evolved so the name is kinda
> > terrible now) to remove any saved placements for the area.
> 
> Given the addonbar-delegating thingy, why would there be any saved
> placements?

I don't know exactly and haven't had time to dive into it, but I certainly see the placements being saved by just starting nightly on a clean profile. I expect something else is broken (like only saving customized areas, or something, or perhaps the migration from persisted currentsets?), but either way we'll need to clean up given that we would otherwise keep the information forever.

Comment 7

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #4)
> Can you file a followup to remove
> https://hg.mozilla.org/mozilla-central/file/tip/services/sync/tps/extensions/
> mozmill/resource/stdlib/utils.js#l278 ? I don't think any toolkit apps have
> an add-on bar...

filed bug 1389036

(In reply to :Gijs from comment #6)
> I don't know exactly and haven't had time to dive into it, but I certainly
> see the placements being saved by just starting nightly on a clean profile.
> I expect something else is broken (like only saving customized areas, or
> something, or perhaps the migration from persisted currentsets?), but either
> way we'll need to clean up given that we would otherwise keep the
> information forever.

filed bug 1389034

Comment 8

[:Gijs (he/him)]

Comment on attachment 8895696 [details]
Bug 956731 - Remove legacy add-on bar and statusbar shims.

https://reviewboard.mozilla.org/r/166982/#review172210

I mean, r=me, but why not just add the migration step here? It'd be 5 lines at most...

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efcedec7e0a0
Remove legacy add-on bar and statusbar shims. r=Gijs

Comment 10

[Dão Gottwald [:dao]]

(In reply to :Gijs from comment #8)
> Comment on attachment 8895696 [details]
> Bug 956731 - Remove legacy add-on bar and statusbar shims.
> 
> https://reviewboard.mozilla.org/r/166982/#review172210
> 
> I mean, r=me, but why not just add the migration step here? It'd be 5 lines
> at most...

I'm not as familiar with these APIs as you are and I just have too much on my plate right now.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/efcedec7e0a0