Closed Bug 1389401 Opened 2 years ago Closed 2 years ago

mips build failure

Categories

(Core :: JavaScript Engine, defect)

55 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: yuyin-hf, Assigned: yuyin-hf)

Details

Attachments

(14 files)

3.65 KB, patch
luke
: review+
Details | Diff | Splinter Review
2.23 KB, patch
luke
: review+
Details | Diff | Splinter Review
872 bytes, patch
Details | Diff | Splinter Review
3.90 KB, patch
luke
: review+
Details | Diff | Splinter Review
1014 bytes, patch
luke
: review+
Details | Diff | Splinter Review
4.28 KB, patch
luke
: review+
Details | Diff | Splinter Review
10.97 KB, patch
luke
: review+
Details | Diff | Splinter Review
4.21 KB, patch
luke
: review+
Details | Diff | Splinter Review
1.88 KB, patch
luke
: review+
Details | Diff | Splinter Review
828 bytes, patch
luke
: review+
Details | Diff | Splinter Review
1.64 KB, patch
luke
: review+
Details | Diff | Splinter Review
2.96 KB, patch
luke
: review+
Details | Diff | Splinter Review
2.36 KB, patch
luke
: review+
Details | Diff | Splinter Review
1.87 KB, patch
luke
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4

Steps to reproduce:

js can not build on mips platform.

1)git clone https://github.com/mozilla/gecko-dev.git
2)  cd gecko-dev
3)  git checkout -b inbound origin/inbound
4)  cd js/src & mkdir build_inbound
5) cd build_inbound
6) auotconf-2.13
7) ../confirgure
8) make -j4


Actual results:

many build errors.


Expected results:

build success and jit-tests run success
Attachment #8896134 - Flags: review?(r)
Attachment #8896134 - Flags: review?(luke)
Attachment #8896135 - Flags: review?(r)
Attachment #8896135 - Flags: review?(luke)
I have 14 patches, these patch can let js build success on mips platform and hit-test run success except many wasm tests failed.
Attachment #8896137 - Flags: review?(r)
Attachment #8896137 - Flags: review?(luke)
Attachment #8896138 - Flags: review?(r)
Attachment #8896138 - Flags: review?(luke)
Attachment #8896139 - Flags: review?(r)
Attachment #8896139 - Flags: review?(luke)
Attachment #8896140 - Flags: review?(r)
Attachment #8896140 - Flags: review?(luke)
Attachment #8896143 - Flags: review?(r)
Attachment #8896143 - Flags: review?(luke)
Attachment #8896144 - Flags: review?(r)
Attachment #8896144 - Flags: review?(luke)
Attachment #8896145 - Flags: review?(r)
Attachment #8896145 - Flags: review?(luke)
Attachment #8896146 - Flags: review?(r)
Attachment #8896146 - Flags: review?(luke)
Attachment #8896147 - Flags: review?(r)
Attachment #8896147 - Flags: review?(luke)
Attachment #8896148 - Flags: review?(r)
Attachment #8896148 - Flags: review?(luke)
Attachment #8896149 - Flags: review?(r)
Attachment #8896149 - Flags: review?(luke)
Attachment #8896151 - Flags: review?(r)
Attachment #8896151 - Flags: review?(luke)
Component: Untriaged → Build Config
Product: Firefox → Core
Component: Build Config → JavaScript Engine
There is another issue with MIPS patches. Check Bug 1329650
Attachment #8896134 - Flags: review?(luke) → review+
Attachment #8896135 - Flags: review?(luke) → review+
Comment on attachment 8896137 [details] [diff] [review]
0003-MIPS-Bug-1352236-Work-around-missing-GETRANDOM_NR-wh.patch

Review of attachment 8896137 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC, bug 1389281 should be adding exactly these.
Attachment #8896137 - Flags: review?(luke)
Attachment #8896138 - Flags: review?(luke) → review+
Attachment #8896139 - Flags: review?(luke) → review+
Attachment #8896140 - Flags: review?(luke) → review+
Attachment #8896143 - Flags: review?(luke) → review+
Attachment #8896144 - Flags: review?(luke) → review+
Attachment #8896145 - Flags: review?(luke) → review+
Attachment #8896146 - Flags: review?(luke) → review+
Attachment #8896147 - Flags: review?(luke) → review+
Comment on attachment 8896148 [details] [diff] [review]
0012-MIPS-Some-fix-about-wasm-see-Bug-1334504.patch

Review of attachment 8896148 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/wasm/WasmStubs.cpp
@@ +1166,3 @@
>  
>      // This will restore stack to the address before the call.
>      masm.moveToStackPtr(s0);

It's possible you're just trying to get things building and mostly passing, in which case r+ for incremental progress, but to get the interrupt exit working, I think after this branch and restoration of sp, you need a masm.storePtr(ReturnReg, Address(sp, masm.framePushed))).  (Otherwise the return address is the 0 pushed up front.)
Attachment #8896148 - Flags: review?(luke) → review+
Attachment #8896149 - Flags: review?(luke) → review+
Attachment #8896151 - Flags: review?(luke) → review+
thank you very much, I will fix this about wasm soon.

(In reply to Luke Wagner [:luke] from comment #18)
> Comment on attachment 8896148 [details] [diff] [review]
> 0012-MIPS-Some-fix-about-wasm-see-Bug-1334504.patch
> 
> Review of attachment 8896148 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/wasm/WasmStubs.cpp
> @@ +1166,3 @@
> >  
> >      // This will restore stack to the address before the call.
> >      masm.moveToStackPtr(s0);
> 
> It's possible you're just trying to get things building and mostly passing,
> in which case r+ for incremental progress, but to get the interrupt exit
> working, I think after this branch and restoration of sp, you need a
> masm.storePtr(ReturnReg, Address(sp, masm.framePushed))).  (Otherwise the
> return address is the 0 pushed up front.)
Keywords: checkin-needed
Assignee: nobody → yuyin-hf
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe9ef51335f
MIPS: Add a register type to getAny and add the equivalent hasAny function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fb6b3ba9472
MIPS: bug 1335068 Break wasm globals out of the code segment. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/c844b43c3415
MIPS: Add missing function fix. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/95df20615cd3
MIPS: Add missing function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/01d0be7c30d5
MIPS: Fix boxDouble. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c9850dc3200
MIPS: Add miss function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb5a0c45c28b
MIPS: Add MacroAssembler::storeRegsInMask. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/996b12a1161a
MIPS: Structure reorganization for multithreaded runtimes. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8c52404be7
MIPS: Small syntax fix. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bb168fae615
MIPS: Add missing function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3eea144cc28
MIPS: Some fix about wasm. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c83ffab598
MIPS: Fix register use. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0632f12445
MIPS: Fix label use. r=luke
Keywords: checkin-needed
Attachment #8896134 - Flags: review?(r)
Attachment #8896135 - Flags: review?(r)
Attachment #8896137 - Flags: review?(r)
Attachment #8896138 - Flags: review?(r)
Attachment #8896139 - Flags: review?(r)
Attachment #8896140 - Flags: review?(r)
Attachment #8896143 - Flags: review?(r)
Attachment #8896144 - Flags: review?(r)
Attachment #8896145 - Flags: review?(r)
Attachment #8896146 - Flags: review?(r)
Attachment #8896147 - Flags: review?(r)
Attachment #8896148 - Flags: review?(r)
Attachment #8896149 - Flags: review?(r)
Attachment #8896151 - Flags: review?(r)
You need to log in before you can comment on or make changes to this bug.