1389401 - mips build failure

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[yuyin]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/603.2.4 (KHTML, like Gecko) Version/10.1.1 Safari/603.2.4

Steps to reproduce:

js can not build on mips platform.

1）git clone https://github.com/mozilla/gecko-dev.git
2)  cd gecko-dev
3)  git checkout -b inbound origin/inbound
4)  cd js/src & mkdir build_inbound
5) cd build_inbound
6) auotconf-2.13
7) ../confirgure
8) make -j4


Actual results:

many build errors.


Expected results:

build success and jit-tests run success

Comment 1

[yuyin]

Attachment: 0001-MIPS-Add-a-register-type-to-getAny-and-add-the-equiv.patch

Comment 2

[yuyin]

Attachment: 0002-MIPS-bug-1335068-Break-wasm-globals-out-of-the-code-.patch

Comment 3

[yuyin]

I have 14 patches, these patch can let js build success on mips platform and hit-test run success except many wasm tests failed.

Comment 4

[yuyin]

Attachment: 0003-MIPS-Bug-1352236-Work-around-missing-GETRANDOM_NR-wh.patch

Comment 5

[yuyin]

Attachment: 0004-MIPS-Add-missing-function-fix.patch

Comment 6

[yuyin]

Attachment: 0005-MIPS-See-Bug-1338217-add-missing-function.patch

Comment 7

[yuyin]

Attachment: 0006-MIPS-Bug-1381438-Fix-boxDouble.patch

Comment 8

[yuyin]

Attachment: 0007-MIPS-Add-miss-function.patch

Comment 9

[yuyin]

Attachment: 0008-MIPS-Add-MacroAssembler-storeRegsInMask.patch

Comment 10

[yuyin]

Attachment: 0009-MIPS-Bug-1325050-Structure-reorganization-for-multit.patch

Comment 11

[yuyin]

Attachment: 0010-MIPS-Small-syntax-fix.patch

Comment 12

[yuyin]

Attachment: 0011-MIPS-Bug-1326067-Add-missing-function.patch

Comment 13

[yuyin]

Attachment: 0012-MIPS-Some-fix-about-wasm-see-Bug-1334504.patch

Comment 14

[yuyin]

Attachment: 0013-MIPS-Fix-register-use.patch

Comment 15

[yuyin]

Attachment: 0014-MIPS-Fix-label-use.-see-Bug-1387535.patch

Comment 16

[Petar Jovanovic]

There is another issue with MIPS patches. Check Bug 1329650

Comment 17

[Luke Wagner [:luke]]

Comment on attachment 8896137 [details] [diff] [review]
0003-MIPS-Bug-1352236-Work-around-missing-GETRANDOM_NR-wh.patch

Review of attachment 8896137 [details] [diff] [review]:
-----------------------------------------------------------------

IIUC, bug 1389281 should be adding exactly these.

Comment 18

[Luke Wagner [:luke]]

Comment on attachment 8896148 [details] [diff] [review]
0012-MIPS-Some-fix-about-wasm-see-Bug-1334504.patch

Review of attachment 8896148 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/wasm/WasmStubs.cpp
@@ +1166,3 @@
>  
>      // This will restore stack to the address before the call.
>      masm.moveToStackPtr(s0);

It's possible you're just trying to get things building and mostly passing, in which case r+ for incremental progress, but to get the interrupt exit working, I think after this branch and restoration of sp, you need a masm.storePtr(ReturnReg, Address(sp, masm.framePushed))).  (Otherwise the return address is the 0 pushed up front.)

Comment 19

[yuyin]

thank you very much, I will fix this about wasm soon.

(In reply to Luke Wagner [:luke] from comment #18)
> Comment on attachment 8896148 [details] [diff] [review]
> 0012-MIPS-Some-fix-about-wasm-see-Bug-1334504.patch
> 
> Review of attachment 8896148 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: js/src/wasm/WasmStubs.cpp
> @@ +1166,3 @@
> >  
> >      // This will restore stack to the address before the call.
> >      masm.moveToStackPtr(s0);
> 
> It's possible you're just trying to get things building and mostly passing,
> in which case r+ for incremental progress, but to get the interrupt exit
> working, I think after this branch and restoration of sp, you need a
> masm.storePtr(ReturnReg, Address(sp, masm.framePushed))).  (Otherwise the
> return address is the 0 pushed up front.)

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fe9ef51335f
MIPS: Add a register type to getAny and add the equivalent hasAny function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fb6b3ba9472
MIPS: bug 1335068 Break wasm globals out of the code segment. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/c844b43c3415
MIPS: Add missing function fix. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/95df20615cd3
MIPS: Add missing function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/01d0be7c30d5
MIPS: Fix boxDouble. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c9850dc3200
MIPS: Add miss function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb5a0c45c28b
MIPS: Add MacroAssembler::storeRegsInMask. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/996b12a1161a
MIPS: Structure reorganization for multithreaded runtimes. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd8c52404be7
MIPS: Small syntax fix. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/3bb168fae615
MIPS: Add missing function. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3eea144cc28
MIPS: Some fix about wasm. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c83ffab598
MIPS: Fix register use. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0632f12445
MIPS: Fix label use. r=luke

Comment 21

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7fe9ef51335f
https://hg.mozilla.org/mozilla-central/rev/0fb6b3ba9472
https://hg.mozilla.org/mozilla-central/rev/c844b43c3415
https://hg.mozilla.org/mozilla-central/rev/95df20615cd3
https://hg.mozilla.org/mozilla-central/rev/01d0be7c30d5
https://hg.mozilla.org/mozilla-central/rev/4c9850dc3200
https://hg.mozilla.org/mozilla-central/rev/fb5a0c45c28b
https://hg.mozilla.org/mozilla-central/rev/996b12a1161a
https://hg.mozilla.org/mozilla-central/rev/bd8c52404be7
https://hg.mozilla.org/mozilla-central/rev/3bb168fae615
https://hg.mozilla.org/mozilla-central/rev/b3eea144cc28
https://hg.mozilla.org/mozilla-central/rev/a6c83ffab598
https://hg.mozilla.org/mozilla-central/rev/fc0632f12445