Closed Bug 1389439 Opened 5 years ago Closed 5 years ago

stylo: Enable test_underlying-discrete-value.html

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: hiro, Assigned: daisuke)

References

Details

Attachments

(2 files)

Now three test cases fail:

20 INFO TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_underlying-discrete-value.html | Test for 0% keyframe only - Test for 0% keyframe only: assert_equals: alignContent of keyframes[1] should be unset expected "unset" but got "normal"
21 INFO TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_underlying-discrete-value.html | Test for 100% keyframe only - Test for 100% keyframe only: assert_equals: alignContent of keyframes[0] should be unset expected "unset" but got "normal"
22 INFO TEST-UNEXPECTED-FAIL | dom/animation/test/mozilla/test_underlying-discrete-value.html | Test for no 0%/100% keyframes and 'inherit' specified on target element - Test for no 0%/100% keyframes and 'inherit' specified on target element: assert_equals: alignContent of keyframes[0] should be inherit expected "inherit" but got "normal"

But it seems to me that these results are correct. We should fix the test cases and skip the cases on gecko.

Relevant spec;
https://drafts.csswg.org/css-align/#propdef-align-content

This spec supercedes the flex-box spec[1]. 

[1] https://drafts.csswg.org/css-flexbox-1/#propdef-justify-content
Assignee: nobody → dakatsuka
Comment on attachment 8897219 [details]
Bug 1389439 - Part 2: Enable test_underlying-discrete-value.html on stylo.

https://reviewboard.mozilla.org/r/168494/#review173742

This should be part 2 right?
Attachment #8897219 - Flags: review?(hikezoe) → review+
Comment on attachment 8897219 [details]
Bug 1389439 - Part 2: Enable test_underlying-discrete-value.html on stylo.

https://reviewboard.mozilla.org/r/168494/#review173742

yes, sorry
Comment on attachment 8897220 [details]
Bug 1389439 - Part 1: Use computed values as all expected values.

https://reviewboard.mozilla.org/r/168496/#review173744

As discussed with daisuke on IRC, the expected values for gecko are not meaningful here, and so we are going to skip the test case for gecko here.

::: dom/animation/test/mozilla/file_underlying-discrete-value.html:8
(Diff revision 1)
>  <script src="../testcommon.js"></script>
>  <body>
>  <script>
>  "use strict";
>  
> +const isServo = SpecialPowers.DOMWindowUtils.isStyledByServo;

Use isStyledByServo() in testcommon.js.
Comment on attachment 8897220 [details]
Bug 1389439 - Part 1: Use computed values as all expected values.

https://reviewboard.mozilla.org/r/168496/#review173782

::: dom/animation/test/mozilla/file_underlying-discrete-value.html:35
(Diff revision 2)
> -    explanation: "Test for 0% keyframe only"
> +    explanation: "Test for 0% keyframe only",
> +    // The value of 100% should be 'normal',
> +    // but we are not supporting underlying value for Gecko.
> +    // https://bugzilla.mozilla.org/show_bug.cgi?id=1295401
> +    // So, we skip this test case.
> +    skip: !isStyledByServo()

We can define this value as a const variable at the beginning of this file.
Attachment #8897220 - Flags: review?(hikezoe) → review+
Pushed by dakatsuka@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/561074529c44
Part 1: Use computed values as all expected values. r=hiro
https://hg.mozilla.org/integration/autoland/rev/60710f479dd3
Part 2: Enable test_underlying-discrete-value.html on stylo. r=hiro
https://hg.mozilla.org/mozilla-central/rev/561074529c44
https://hg.mozilla.org/mozilla-central/rev/60710f479dd3
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.