In the tour overlay "Open Default Browser Settings" is not clickable again if it is clicked once

NEW
Unassigned

Status

()

defect
P5
normal
2 years ago
2 years ago

People

(Reporter: Abe_LV, Unassigned)

Tracking

56 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 affected, firefox57 wontfix)

Details

(Whiteboard: [photon-onboarding])

Reporter

Description

2 years ago
Steps to Reproduce:
Screen capture is here: https://testing-1.tinytake.com/sf/MTg2NDM3MF81OTk3MTk2

1. Start the latest nightly (57.0a1) from clean profile and do not set it as default
2. Create new tab and click on the fox
3. Click on "Default Browser"
4. Click on "Open Default Browser Settings" 
5. Cancel the popup default setting window.
6. Click on "Search" from the overlay
7. Click on "Default Browser" again
8. Verify "Open Default Browser Settings" is clickable

Actual Result:
"Open Default Browser Settings" is NOT clickable

Expected Result
"Open Default Browser Settings" should be clickable

Updated

2 years ago
Component: Tours → New Tab Page
Whiteboard: [photon-onboarding][triage]
Reporter

Updated

2 years ago
Flags: needinfo?(rexboy)
QA Contact: jwilliams
Version: Trunk → 56 Branch
Thanks for report, yes we should handle this edge case
Assignee: nobody → gasolin
Flags: needinfo?(rexboy)
triaged and set to P5
Assignee: gasolin → nobody
Priority: -- → P5

Updated

2 years ago
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
OS X 10.9: Selecting "Open Default Browser Settings" makes Firefox default without opening the Settings window and asking the user again (the behavior is correct on OS X 10.12).
For OS which able to makes Firefox default without opening the Settings window, we'll show related string for that and should not allow user to click the button again, check bug 1385170
Flags: needinfo?(cristian.comorasu)
Yes, but if you need to set Firefox as default browser again, the button is still inactive ( mac OS X 10.12.6 ).
Flags: needinfo?(cristian.comorasu)
You need to log in before you can comment on or make changes to this bug.