|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Bug 1385170 - show button string by checking if the platform support set default browser in background;
59 bytes, text/x-review-board-request
|Details | Review|
In UI spec it described only windows 7 allow set default browser in background, but after QA test in bug 1374717 comment 35 we found Ubuntu also support set default browser in background. That means only checking windows7 is not the right way to go. We could show the correct string by checking UITour's canSetDefaultBrowserInBackground property for on the getConfiguration("appInfo") response
Whiteboard: [ph → [photon-onboarding][triage]
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
The PR also fix the issue on window 7, which will show the disabled button instead of 2 lines of alternative message after user click the button. The expect result should be showing 2 lines of alternative message after user click the button.
The PR send an event when page is rendered and listen in default-browser-tour's getPage method. Once event is received, it will send another event to ask agent doing UITour check The previous PR create the extra `processPage` method to call the action after page is rendered, https://reviewboard.mozilla.org/r/162406/diff/3#index_header But after sync with Rex, we think listen event in `getPage` might be more flexible than make calls on every entry-point.
Can we reuse the event from bug 1384045 here?
You mean 'beforeshow'? yes, though we still need extra event to communicate with onboarding_agent for UITour related actions.
I'm a bit concerned about listening on the same `beforeshow` event in `gotoPage` function since it might be too late for async showing the button text. But I found no visual regression when I test it on Macbook Air. So I'll remove my custom event and reuse `beforeshow` event from bug 1384045
QA Contact: jwilliams
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Comment on attachment 8891191 [details] Bug 1385170 - show button string by checking if the platform support set default browser in background; https://reviewboard.mozilla.org/r/162406/#review168484
Attachment #8891191 - Flags: review?(dtownsend) → review+
Thanks! For QA please test on at least Windows 7 and Ubuntu to verify it works.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d000d7961749 show button string by checking if the platform support set default browser in background;r=mossop
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
I have verified that this is fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.