1389559 - Add-ons pane now is extra-wide and has a scrollbar for half-screen-width window sizes, due to "Missing something? Some extensions are no longer supported by Nightly. [Show legacy extensions]" blurb

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit about:addons and click "Extensions"
 2. Make your window ~900px wide.  (Or may

ACTUAL RESULTS:

The viewport for the addons area is too wide. (The long "Missing something? Some extensions are no longer supported" message imposes a minimum width)

This manifests as follows:
 - Horizontal scrollbar
 - The "search" field is positioned arbitrarily too var to the right, so it overflows the visible area and its "magnifying glass" icon isn't visible.
 - If you have extensions installed, their "Remove" buttons are positioned too far to the right and are clipped as well.

EXPECTED RESULTS:
The "Missing something? Some extensions are no longer supported" message should allow itself to wrap to multiple lines, to gracefully handle smaller windows.


This bug fixes itself if I delete the "Missing something" node using devtools -- so it's definitely a problem with that node.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of issue, with 960px-wide window

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering before regression, with 960px-wide window (note searchbox & absence of scrollbar)

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering, with much skinnier window (still good!)

Here's another screenshot, before the regression, with a much smaller window (514px wide).

The add-ons pane was still admirably responsive at this size, which was great! (some text was ellipsized/wrapped, but nothing overflows, and the search box was still 100% visible)

But with this regression, the searchbox isn't even visible in a window of this size, because this super-wide warning message pushes it wayyy off to the right, by virtue of creating a large scrollable area.

Comment 4

[Daniel Holbert [:dholbert]]

Most proximally, this was a regression from bug 1388946 (which just landed in today's Nightly) -- though that was just a pref-flip, so really it's a regression from a change that happened longer ago & was just masked by the pref being disabled.

Probably really a regression from bug 1360777, since some brief searchfox archeology indicates that that's where we added this UI...?

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: screencast showing the broken UI (including clipped "Remove" button), fixed by removing warning-text in devtools

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #4)
> Probably really a regression from bug 1360777

Confirmed, this was a regression from bug 1360777 (using mozregression with a Firefox profile that has the legacy-addons pref forcibly set to "false").

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: screenshot of similar problem with "Experiments" pane

I just noticed that the "Experiments" pane (on about:addons) has the same problem -- it's got a similarly-long message which acts as a "strut" to force the viewport to be at least a certain width.

(In this case the message is "What's this? Telemetry may install and run experiments from time to time. [Learn More][Telemetry Settings]")

As with the Extensions pane: the problem goes away if I delete this message using DevTools.

Comment 8

[Andrew Swan [:aswan]]

There's a similar header on the Plugins pane too.
Redirect to Mark, I suspect there's some simple style that can be applied to make that text wrap.

Comment 9

[Mark Striemer [:mstriemer]]

Attachment: Bug 1389559 - Wrap about:addons warnings to maintain narrow layouts

Review commit: https://reviewboard.mozilla.org/r/174654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174654/

Comment 10

[Robert Helmer [:rhelmer]]

Comment on attachment 8902926 [details]
Bug 1389559 - Wrap about:addons warnings to maintain narrow layouts

https://reviewboard.mozilla.org/r/174654/#review179780

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2ad47692c87
Wrap about:addons warnings to maintain narrow layouts r=rhelmer

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d2ad47692c87