1388946 - Flip default setting for extensions.legacy.enabled

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1388946 Part 2 Disable legacy extensions by default

Also bump the xpi database schema version to force compatibility
recomputation (since we're not changing the application version number)

Review commit: https://reviewboard.mozilla.org/r/166884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166884/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8895638 [details]
Bug 1388946 Part 2 Disable legacy extensions by default

https://reviewboard.mozilla.org/r/166884/#review171974

Comment 4

[Andrew Swan [:aswan]]

Attachment: Bug 1388946 Part 1 Fix test for default-disabled legacy extensions

Review commit: https://reviewboard.mozilla.org/r/166932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/166932/

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8895638 [details]
Bug 1388946 Part 2 Disable legacy extensions by default

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/166884/diff/1-2/

Comment 6

[Andrew Swan [:aswan]]

I think this is good to go, I've added a fix for one xpcshell test that was failing and the rest of the failures here look unrelated:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=27b8e911dd2e

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8895661 [details]
Bug 1388946 Part 1 Fix test for default-disabled legacy extensions

https://reviewboard.mozilla.org/r/166932/#review172080

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f84a053b1b4
Part 1 Fix test for default-disabled legacy extensions r=kmag
https://hg.mozilla.org/integration/autoland/rev/45d8844f0124
Part 2 Disable legacy extensions by default r=kmag

Comment 9

[Paul [pwd]]

Would it not be better to do this later in the cycle. A lot of major addons are yet to convert to WebExtensions and in order to support ESRs are trying to delay even hybrid WebExtensions to as late in the cycle as possible. See uBlock, HTTPS Everywhere and NoScript as examples. Even the Decentraleyes developer believes he had until September to get a WE out while supporting those willing to test Firefox Nightly.

Comment 10

[Andy McKay]

On the contrary, doing so will reduce the amount of time this in front of users and increase the risk of 57. The whole point of Firefox Nightly is for users and developers to test what will be coming.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4f84a053b1b4
https://hg.mozilla.org/mozilla-central/rev/45d8844f0124

Comment 12

[Vasilica Tamas, QA [:vtamas]]

I confirm that extensions.legacy.enabled pref is set to “false” by default and all the legacy add-ons installation is blocked, excepting lang packs, dictionaries and themes. 
Also when updating from a Firefox version with the pref set to true to the latest Firefox 57.0a1 where the feature is enabled by default all the installed legacy add-ons are automatically disabled and moved to “Legacy Extensions” tab.

Verified on Firefox 57.0a1 (2017-08-16/17) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.3. Based on this testing I am marking this bug as Verified fixed.

Comment 13

[[:philipp]]

this seems a major change worth documenting for 57.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Andy, would you be able to help with the relnote wording for this? Or should the relnote rather be around "Firefox 57 supports webext only"? Thanks!

Comment 15

[Andy McKay]

How about just: "Support only add-ons built using the WebExtensions API"

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This was added to 57 release notes.