1389673 - Port bug 1389529 |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

mail/components/newmailaccount/content/accountProvisioner.js
return Services.domStorageManager.getLocalStorageForPrincipal(principal, url);

mail/test/mozmill/newmailaccount/test-newmailaccount.js
let storage = dsm.getLocalStorageForPrincipal(principal, url);

suite/common/dataman/dataman.js
lStorageForPrincipal(principal, "");

Comment 1

[Frank-Rainer Grahl (:frg)]

nsIDOMStorageManager.getLocalStorageForPrincipal is only a thin wrapper for CreateStorage:

> comm-central/mozilla/dom/storage/LocalStorageManager.cpp
> NS_IMETHODIMP
> LocalStorageManager::GetLocalStorageForPrincipal(nsIPrincipal* aPrincipal,
>                                                  const nsAString& aDocumentURI,
>                                                  bool aPrivate,
>                                                  nsIDOMStorage** aRetval)
> {
>   return CreateStorage(nullptr, aPrincipal, aDocumentURI, aPrivate, aRetval);
> }

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1389673-createstorage-mail.patch

Patch for mail

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1389673-createstorage.patch

Patch for suite. Could you review it too. Trivial patch, tested and if IanN minds he will tell me for sure later.

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, no rush here since bug 1389529 hasn't landed.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8896582 [details] [diff] [review]
1389673-createstorage-mail.patch

This must be right since the IDL says:
  /**
   * @deprecated
...
   * Currently just forwards to the createStorage method of this
   * interface.
...
  nsIDOMStorage getLocalStorageForPrincipal(in nsIPrincipal aPrincipal,
                                            in DOMString aDocumentURI,
                                            [optional] in bool aPrivate);

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8896583 [details] [diff] [review]
1389673-createstorage.patch

Same comment as for the other patch.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55f7f7d393e7
Port bug 1389529: Replace getLocalStorageForPrincipal with createStorage in mail. r=jorgk
https://hg.mozilla.org/comm-central/rev/412d334f32bc
Port bug 1389529: Replace getLocalStorageForPrincipal with createStorage in suite. r=jorgk