Closed
Bug 1389673
Opened 8 years ago
Closed 8 years ago
Port bug 1389529 |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C
Categories
(Thunderbird :: General, enhancement)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 57.0
People
(Reporter: jorgk-bmo, Assigned: frg)
Details
Attachments
(2 files)
2.29 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
mail/components/newmailaccount/content/accountProvisioner.js
return Services.domStorageManager.getLocalStorageForPrincipal(principal, url);
mail/test/mozmill/newmailaccount/test-newmailaccount.js
let storage = dsm.getLocalStorageForPrincipal(principal, url);
suite/common/dataman/dataman.js
lStorageForPrincipal(principal, "");
Reporter | ||
Updated•8 years ago
|
Summary: Port |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C → Port bug 1389529 |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C
![]() |
Assignee | |
Comment 1•8 years ago
|
||
nsIDOMStorageManager.getLocalStorageForPrincipal is only a thin wrapper for CreateStorage:
> comm-central/mozilla/dom/storage/LocalStorageManager.cpp
> NS_IMETHODIMP
> LocalStorageManager::GetLocalStorageForPrincipal(nsIPrincipal* aPrincipal,
> const nsAString& aDocumentURI,
> bool aPrivate,
> nsIDOMStorage** aRetval)
> {
> return CreateStorage(nullptr, aPrincipal, aDocumentURI, aPrivate, aRetval);
> }
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 3•8 years ago
|
||
Patch for suite. Could you review it too. Trivial patch, tested and if IanN minds he will tell me for sure later.
Attachment #8896583 -
Flags: review?(jorgk)
Reporter | ||
Comment 4•8 years ago
|
||
Thanks, no rush here since bug 1389529 hasn't landed.
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8896582 [details] [diff] [review]
1389673-createstorage-mail.patch
This must be right since the IDL says:
/**
* @deprecated
...
* Currently just forwards to the createStorage method of this
* interface.
...
nsIDOMStorage getLocalStorageForPrincipal(in nsIPrincipal aPrincipal,
in DOMString aDocumentURI,
[optional] in bool aPrivate);
Attachment #8896582 -
Flags: review?(jorgk) → review+
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8896583 [details] [diff] [review]
1389673-createstorage.patch
Same comment as for the other patch.
Attachment #8896583 -
Flags: review?(jorgk) → review+
Reporter | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/55f7f7d393e7
Port bug 1389529: Replace getLocalStorageForPrincipal with createStorage in mail. r=jorgk
https://hg.mozilla.org/comm-central/rev/412d334f32bc
Port bug 1389529: Replace getLocalStorageForPrincipal with createStorage in suite. r=jorgk
Reporter | ||
Updated•8 years ago
|
Target Milestone: --- → Thunderbird 57.0
You need to log in
before you can comment on or make changes to this bug.
Description
•