Closed Bug 1389673 Opened 2 years ago Closed 2 years ago

Port bug 1389529 |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Type:
enhancement
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 57.0

People

(Reporter: jorgk, Assigned: frg)

Details

Attachments

(2 files)

1389673-createstorage-mail.patch
2.29 KB, patch
jorgk
: review+
Details | Diff | Splinter Review
1389673-createstorage.patch
1.13 KB, patch
jorgk
: review+
Details | Diff | Splinter Review 
mail/components/newmailaccount/content/accountProvisioner.js
return Services.domStorageManager.getLocalStorageForPrincipal(principal, url);

mail/test/mozmill/newmailaccount/test-newmailaccount.js
let storage = dsm.getLocalStorageForPrincipal(principal, url);

suite/common/dataman/dataman.js
lStorageForPrincipal(principal, "");
Summary: Port |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C → Port bug 1389529 |Remove deprecated nsIDOMStorageManager.getLocalStorageForPrincipal| to C-C
nsIDOMStorageManager.getLocalStorageForPrincipal is only a thin wrapper for CreateStorage:

> comm-central/mozilla/dom/storage/LocalStorageManager.cpp
> NS_IMETHODIMP
> LocalStorageManager::GetLocalStorageForPrincipal(nsIPrincipal* aPrincipal,
>                                                  const nsAString& aDocumentURI,
>                                                  bool aPrivate,
>                                                  nsIDOMStorage** aRetval)
> {
>   return CreateStorage(nullptr, aPrincipal, aDocumentURI, aPrivate, aRetval);
> }
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Patch for mail
Attachment #8896582 - Flags: review?(jorgk)
Patch for suite. Could you review it too. Trivial patch, tested and if IanN minds he will tell me for sure later.
Attachment #8896583 - Flags: review?(jorgk)
Thanks, no rush here since bug 1389529 hasn't landed.
Comment on attachment 8896582 [details] [diff] [review]
1389673-createstorage-mail.patch

This must be right since the IDL says:
  /**
   * @deprecated
...
   * Currently just forwards to the createStorage method of this
   * interface.
...
  nsIDOMStorage getLocalStorageForPrincipal(in nsIPrincipal aPrincipal,
                                            in DOMString aDocumentURI,
                                            [optional] in bool aPrivate);
Attachment #8896582 - Flags: review?(jorgk) → review+
Comment on attachment 8896583 [details] [diff] [review]
1389673-createstorage.patch

Same comment as for the other patch.
Attachment #8896583 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/55f7f7d393e7
Port bug 1389529: Replace getLocalStorageForPrincipal with createStorage in mail. r=jorgk
https://hg.mozilla.org/comm-central/rev/412d334f32bc
Port bug 1389529: Replace getLocalStorageForPrincipal with createStorage in suite. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.