Closed
Bug 1389960
Opened 7 years ago
Closed 7 years ago
Error console doesn't open
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 57.0
People
(Reporter: Paenglab, Assigned: jorgk-bmo)
Details
Attachments
(1 file, 1 obsolete file)
|
3.71 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
Pressing CTRL+SHIFT+J or on Mac CMD+SHIFT+J does no more open the error console. Also over the menu it doesn't open.
Opening the Developer Toolbox still works and the error shows:
TypeError: HUDService.openBrowserConsoleOrFocus is not a function[Learn More] mailCore.js:326:3
toJavaScriptConsole chrome://messenger/content/mailCore.js:326:3
oncommand chrome://messenger/content/messenger.xul:1:1
|
Assignee | |
Comment 1•7 years ago
|
||
Can you please try to port bug 1388552. This should be all required:
https://hg.mozilla.org/mozilla-central/rev/b54b0c24d18f#l14.12
Fix this here:
https://dxr.mozilla.org/comm-central/source/im/content/menus.js#59
https://dxr.mozilla.org/comm-central/source/mail/components/devtools/devtools-loader.js#41
I can't see how SM does this.
Flags: needinfo?(richard.marti)
Version: unspecified → Trunk
|
Reporter | |
Comment 2•7 years ago
|
||
Thanks for the pointer. I'll try it.
Assignee: nobody → richard.marti
Flags: needinfo?(richard.marti)
|
|
Assignee | |
Comment 3•7 years ago
|
||
I have a patch already.
|
|
Assignee | |
Comment 4•7 years ago
|
||
I was quicker. One more line needed porting.
Assignee: richard.marti → jorgk
Status: NEW → ASSIGNED
Attachment #8896917 -
Flags: review?(richard.marti)
|
|
Assignee | |
Comment 5•7 years ago
|
||
Also fixing suite.
Attachment #8896917 -
Attachment is obsolete: true
Attachment #8896917 -
Flags: review?(richard.marti)
Attachment #8896919 -
Flags: review?(richard.marti)
|
|
Reporter | |
Comment 6•7 years ago
|
||
Comment on attachment 8896919 [details] [diff] [review]
1389960-hudservice.patch (v2).
This works and seems straight forward from the m-c patch.
Attachment #8896919 -
Flags: review?(richard.marti) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d3c1249a84e1
Port 1388552 to C-C [Export the HUDService object directly instead of individual methods and properties]. r=Paenglab DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 57.0
You need to log in
before you can comment on or make changes to this bug.
Description
•