1390018 - test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20

Status: VERIFIED FIXED

(Core :: DOM: Web Payments, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

https://treeherder.mozilla.org/logviewer.html#?job_id=122812580&repo=try

I assume this is tied to Web Payments being behind NIGHTLY_ONLY ifdefs still?

Comment 1

[Eden Chuang[:edenchuang]]

The root cause is here

https://searchfox.org/mozilla-central/source/browser/installer/package-manifest.in#399

and it is the root cause of bug 1380009, too.

I need to check if we should keep web payment UI implementation in nightly only, such that I can remove the flag or modify test cases run in nightly build only.

MattN, could you give some comment? thanks.

Comment 2

[Matthew N. [:MattN]]

I think we should keep the dom and toolkit directories Nightly-only since I don't see any point in shipping extra code and potential security issues before then.

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390018 - test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20. r?MattN

1. Keep toolkit/components/payments being included in nightly build only.
2. Run test_abortPayment.html in nightly build only.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8897613 [details] [diff] [review]
Bug 1390018 - test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20. r?MattN

Review of attachment 8897613 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/moz.build
@@ +114,4 @@
>          'nsDefaultCLH.manifest',
>      ]
>  
> +if CONFIG['NIGHTLY_BUILD'] and CONFIG['MOZ_BUILD_APP'] == 'browser':

Isn't this going to re-introduce the packaging bustage when 57 goes to Beta unless browser/installer/package-manifest.in also gets updated?

Comment 6

[Eden Chuang[:edenchuang]]

https://searchfox.org/mozilla-central/source/browser/installer/package-manifest.in#399

I think there is a nightly build configuration in package-manifest.in.

Comment 7

[Matthew N. [:MattN]]

Which packaging bustage? package-manifest.in already has https://hg.mozilla.org/mozilla-central/annotate/b95b1638db48fc3d450b95b98da6bcd2f9326d2f/browser/installer/package-manifest.in#l399

Or do you mean for the dom parts?

Comment 8

[Matthew N. [:MattN]]

Comment on attachment 8897613 [details] [diff] [review]
Bug 1390018 - test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20. r?MattN

Review of attachment 8897613 [details] [diff] [review]:
-----------------------------------------------------------------

Please change your commit message to describe what the patch is doing, not what the problem is.

I personally would prefer we didn't ship the dom code unnecessarily as it just adds an attack vector and issues like this where it's out of sync with the UI shipping but it's not my module to decide that.

::: dom/payments/test/mochitest.ini
@@ +10,4 @@
>    ShowPaymentChromeScript.js
>  
>  [test_abortPayment.html]
> +run-if = nightly_build

You should add a comment on this line with a `#` explaining why the test is Nightly-only. e.g. "# depends on the Nightly-only UI service"

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #7)
> Which packaging bustage?

Sorry about that, I'd missed that the NIGHTLY_BUILD ifdefs got added back in bug 1381186.

Comment 10

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390018 - Keep toolkit/components/payments being included and run related test cases in nightly only. r?MattN

Add comment and modify the commit message according to comment 8.

Comment 11

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390018 - Keep toolkit/components/payments being included and run related test cases in nightly only. r?MattN

Comment 12

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390018 - Keep toolkit/components/payments being included and run related test cases in nightly only. r=MattN

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/767a4bd1abba
Build and test Payments UI code on Nightly builds only. r=MattN

Comment 15

[Eden Chuang[:edenchuang]]

Attachment: bug1390018.patch

Fix the wrong bug number in commit message

Comment 16

[Eden Chuang[:edenchuang]]

Attachment: Bug 1390018 - Keep toolkit/components/payments being included and run related test cases in nightly only. r?MattN

Fix the wrong bug number in commit message

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/767a4bd1abba

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is fixed, no need to track it.