Closed
Bug 1390018
Opened 7 years ago
Closed 7 years ago
test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20
Categories
(Core :: DOM: Web Payments, defect)
Core
DOM: Web Payments
Tracking
()
VERIFIED
FIXED
mozilla57
People
(Reporter: RyanVM, Assigned: edenchuang)
References
Details
Attachments
(1 file, 5 obsolete files)
[Tracking Requested - why for this release]: Permafailing test on the next merge day. https://treeherder.mozilla.org/logviewer.html#?job_id=122812580&repo=try I assume this is tied to Web Payments being behind NIGHTLY_ONLY ifdefs still?
Flags: needinfo?(echuang)
Assignee | ||
Comment 1•7 years ago
|
||
The root cause is here https://searchfox.org/mozilla-central/source/browser/installer/package-manifest.in#399 and it is the root cause of bug 1380009, too. I need to check if we should keep web payment UI implementation in nightly only, such that I can remove the flag or modify test cases run in nightly build only. MattN, could you give some comment? thanks.
Flags: needinfo?(echuang) → needinfo?(MattN+bmo)
Comment 2•7 years ago
|
||
I think we should keep the dom and toolkit directories Nightly-only since I don't see any point in shipping extra code and potential security issues before then.
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 3•7 years ago
|
||
1. Keep toolkit/components/payments being included in nightly build only. 2. Run test_abortPayment.html in nightly build only.
Attachment #8897613 -
Flags: review?(MattN+bmo)
Reporter | ||
Comment 5•7 years ago
|
||
Comment on attachment 8897613 [details] [diff] [review] Bug 1390018 - test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20. r?MattN Review of attachment 8897613 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/moz.build @@ +114,4 @@ > 'nsDefaultCLH.manifest', > ] > > +if CONFIG['NIGHTLY_BUILD'] and CONFIG['MOZ_BUILD_APP'] == 'browser': Isn't this going to re-introduce the packaging bustage when 57 goes to Beta unless browser/installer/package-manifest.in also gets updated?
Assignee | ||
Comment 6•7 years ago
|
||
https://searchfox.org/mozilla-central/source/browser/installer/package-manifest.in#399 I think there is a nightly build configuration in package-manifest.in.
Assignee: nobody → echuang
Status: NEW → ASSIGNED
Comment 7•7 years ago
|
||
Which packaging bustage? package-manifest.in already has https://hg.mozilla.org/mozilla-central/annotate/b95b1638db48fc3d450b95b98da6bcd2f9326d2f/browser/installer/package-manifest.in#l399 Or do you mean for the dom parts?
Comment 8•7 years ago
|
||
Comment on attachment 8897613 [details] [diff] [review] Bug 1390018 - test_abortPayment.html is going to permafail when Gecko 57 merges to Beta on 2017-09-20. r?MattN Review of attachment 8897613 [details] [diff] [review]: ----------------------------------------------------------------- Please change your commit message to describe what the patch is doing, not what the problem is. I personally would prefer we didn't ship the dom code unnecessarily as it just adds an attack vector and issues like this where it's out of sync with the UI shipping but it's not my module to decide that. ::: dom/payments/test/mochitest.ini @@ +10,4 @@ > ShowPaymentChromeScript.js > > [test_abortPayment.html] > +run-if = nightly_build You should add a comment on this line with a `#` explaining why the test is Nightly-only. e.g. "# depends on the Nightly-only UI service"
Attachment #8897613 -
Flags: review?(MattN+bmo) → review+
Reporter | ||
Comment 9•7 years ago
|
||
(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #7) > Which packaging bustage? Sorry about that, I'd missed that the NIGHTLY_BUILD ifdefs got added back in bug 1381186.
Assignee | ||
Comment 10•7 years ago
|
||
Add comment and modify the commit message according to comment 8.
Attachment #8897613 -
Attachment is obsolete: true
Attachment #8897623 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 11•7 years ago
|
||
Attachment #8897623 -
Attachment is obsolete: true
Attachment #8897623 -
Flags: review?(MattN+bmo)
Attachment #8897626 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 12•7 years ago
|
||
Attachment #8897626 -
Attachment is obsolete: true
Attachment #8897626 -
Flags: review?(MattN+bmo)
Attachment #8897629 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 14•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/767a4bd1abba Build and test Payments UI code on Nightly builds only. r=MattN
Keywords: checkin-needed
Assignee | ||
Comment 15•7 years ago
|
||
Fix the wrong bug number in commit message
Attachment #8897629 -
Attachment is obsolete: true
Attachment #8897637 -
Flags: review+
Assignee | ||
Comment 16•7 years ago
|
||
Fix the wrong bug number in commit message
Attachment #8897637 -
Attachment is obsolete: true
Attachment #8897642 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/767a4bd1abba
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Reporter | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
This is fixed, no need to track it.
You need to log in
before you can comment on or make changes to this bug.
Description
•