Enable APZ autoscrolling on the Nightly channel

RESOLVED FIXED in Firefox 57

Status

()

P3
normal
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: botond, Assigned: botond)

Tracking

57 Branch
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Support for APZ autoscrolling has landed behind a pref two weeks ago (bug 1105109).

The pref is currently disabled by default on all channels, but we've had a few people flip it and play around with the feature. After reporting a few initial regressions which have since been fixed, things have quieted down, so I think this is a good time to enable the pref on the Nightly channel and get some broader test coverage.
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8897083 [details]
Bug 1390247 - Enable APZ autoscrolling on Nightly builds.

https://reviewboard.mozilla.org/r/168370/#review173634
Attachment #8897083 - Flags: review?(bugmail) → review+
Maybe send a message to dev-platform too, so people know to file any issues they run into.
(Assignee)

Comment 5

2 years ago
(In reply to Botond Ballo [:botond] from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=46f56bb1b7f747967a360d27b5acaa54cab49e16

The Try run is showing toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js failing. We'll need to green this test up before we can land this.
Priority: -- → P3
Whiteboard: [gfx-noted]
Version: Trunk → 57 Branch
(Assignee)

Comment 6

2 years ago
(In reply to Botond Ballo [:botond] from comment #5)
> The Try run is showing
> toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js
> failing. We'll need to green this test up before we can land this.

So, after a lot of debugging and investigating in several wrong directions, this actually turned out to be a very simple fix: the mouse-move event that the test synthesizes to move the mouse away from the autoscroll anchor needs to be routed through APZ, so it can pick up the resulting mouse location.
Comment hidden (mozreview-request)

Comment 10

2 years ago
mozreview-review
Comment on attachment 8898040 [details]
Bug 1390247 - Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling.

https://reviewboard.mozilla.org/r/169340/#review174866
Attachment #8898040 - Flags: review?(bugmail) → review+

Comment 11

2 years ago
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db173b8cb609
Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling. r=kats
https://hg.mozilla.org/integration/autoland/rev/7f118ff40f8f
Enable APZ autoscrolling on Nightly builds. r=kats

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db173b8cb609
https://hg.mozilla.org/mozilla-central/rev/7f118ff40f8f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Assignee)

Comment 13

2 years ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> Maybe send a message to dev-platform too, so people know to file any issues
> they run into.

Posted https://groups.google.com/forum/#!topic/mozilla.dev.platform/J-YxNGzd0pk.

Updated

5 months ago
Depends on: 1502614
You need to log in before you can comment on or make changes to this bug.