Closed Bug 1390247 Opened 4 years ago Closed 4 years ago

Enable APZ autoscrolling on the Nightly channel

Categories

(Core :: Panning and Zooming, enhancement, P3)

Product:
Core
Component:
Panning and Zooming
Version:
57 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: botond, Assigned: botond)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

Bug 1390247 - Enable APZ autoscrolling on Nightly builds.
59 bytes, text/x-review-board-request
kats
: review+
Details
Bug 1390247 - Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling.
59 bytes, text/x-review-board-request
kats
: review+
Details 
Support for APZ autoscrolling has landed behind a pref two weeks ago (bug 1105109).

The pref is currently disabled by default on all channels, but we've had a few people flip it and play around with the feature. After reporting a few initial regressions which have since been fixed, things have quieted down, so I think this is a good time to enable the pref on the Nightly channel and get some broader test coverage.
Comment on attachment 8897083 [details]
Bug 1390247 - Enable APZ autoscrolling on Nightly builds.

https://reviewboard.mozilla.org/r/168370/#review173634
Attachment #8897083 - Flags: review?(bugmail) → review+
Maybe send a message to dev-platform too, so people know to file any issues they run into.
(In reply to Botond Ballo [:botond] from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=46f56bb1b7f747967a360d27b5acaa54cab49e16

The Try run is showing toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js failing. We'll need to green this test up before we can land this.
Priority: -- → P3
Whiteboard: [gfx-noted]
Version: Trunk → 57 Branch
(In reply to Botond Ballo [:botond] from comment #5)
> The Try run is showing
> toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js
> failing. We'll need to green this test up before we can land this.

So, after a lot of debugging and investigating in several wrong directions, this actually turned out to be a very simple fix: the mouse-move event that the test synthesizes to move the mouse away from the autoscroll anchor needs to be routed through APZ, so it can pick up the resulting mouse location.
Comment on attachment 8898040 [details]
Bug 1390247 - Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling.

https://reviewboard.mozilla.org/r/169340/#review174866
Attachment #8898040 - Flags: review?(bugmail) → review+
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db173b8cb609
Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling. r=kats
https://hg.mozilla.org/integration/autoland/rev/7f118ff40f8f
Enable APZ autoscrolling on Nightly builds. r=kats
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> Maybe send a message to dev-platform too, so people know to file any issues
> they run into.

Posted https://groups.google.com/forum/#!topic/mozilla.dev.platform/J-YxNGzd0pk.
Depends on: 1393424
Depends on: 1502614
You need to log in before you can comment on or make changes to this bug.