1385463 - Enable APZ autoscrolling by default

Status: VERIFIED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Botond Ballo [:botond]]

Bug 1105109 is adding an APZ implementation of autoscrolling, behind the pref apz.autoscroll.enabled, which will initially be disabled by default.

This bug tracks enabling enabling the pref by default.

Comment 1

[Botond Ballo [:botond]]

Moving over Quantum tracking flags from bug 1105109.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1385463 - Have APZ autoscrolling ride the trains.

Review commit: https://reviewboard.mozilla.org/r/175476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/175476/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8903694 [details]
Bug 1385463 - Have APZ autoscrolling ride the trains.

https://reviewboard.mozilla.org/r/175476/#review180576

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68c2a6565325
Have APZ autoscrolling ride the trains. r=kats

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/68c2a6565325

Comment 6

[Pascal Chevrel:pascalc]

Botond, should that be mentioned in Firefox nightly/beta release notes?

Comment 7

[Botond Ballo [:botond]]

(In reply to Pascal Chevrel:pascalc from comment #6)
> Botond, should that be mentioned in Firefox nightly/beta release notes?

Yep, I think that would be a good idea. APZ keyboard scrolling was enabled in 57 as well (bug 1376525), we should mention that too.

Comment 8

[Botond Ballo [:botond]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
  Asynchronous scrolling provides a smoother / less janky scrolling
  experience for users. This bug brings async scrolling to the
  browser's "autoscroll" feature, one of the few remaining scrolling
  methods that don't have it yet.

[Affects Firefox for Android]:
  No.

  (Technically, the answer may be "yes" - I'm not actually sure if
  autoscrolling works on Android, if it does then APZ will apply
  to it too - but as mouse input is very rare Android, it's not 
  worth mentioning.)

[Suggested wording]:
  The browser's "autoscrolling" feature now uses asynchronous scrolling,
  similar to other input methods like mousewheel, providing a smoother
  scrolling experience.

[Links (documentation, blog post, etc)]:
  Nothing specifically for autoscrolling, but some links for APZ
  in general:

  wiki: https://wiki.mozilla.org/Platform/GFX/APZ
  blog post: https://blog.mozilla.org/firefox/smooth-scrolling-web-browser-removes-jank/

Comment 9

[Petruta Horea [:phorea], Desktop Test Engineering]

Marking as verified since checking that apz.autoscroll.enabled pref is set to true was tested for pre-Beta sign off in Firefox 57.0a1 across platforms.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This was added to 57 beta release notes.