1390247 - Enable APZ autoscrolling on the Nightly channel

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Botond Ballo [:botond]]

Support for APZ autoscrolling has landed behind a pref two weeks ago (bug 1105109).

The pref is currently disabled by default on all channels, but we've had a few people flip it and play around with the feature. After reporting a few initial regressions which have since been fixed, things have quieted down, so I think this is a good time to enable the pref on the Nightly channel and get some broader test coverage.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1390247 - Enable APZ autoscrolling on Nightly builds.

Review commit: https://reviewboard.mozilla.org/r/168370/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168370/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8897083 [details]
Bug 1390247 - Enable APZ autoscrolling on Nightly builds.

https://reviewboard.mozilla.org/r/168370/#review173634

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Maybe send a message to dev-platform too, so people know to file any issues they run into.

Comment 4

[Botond Ballo [:botond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46f56bb1b7f747967a360d27b5acaa54cab49e16

Comment 5

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #4)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=46f56bb1b7f747967a360d27b5acaa54cab49e16

The Try run is showing toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js failing. We'll need to green this test up before we can land this.

Comment 6

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #5)
> The Try run is showing
> toolkit/content/tests/browser/browser_bug295977_autoscroll_overflow.js
> failing. We'll need to green this test up before we can land this.

So, after a lot of debugging and investigating in several wrong directions, this actually turned out to be a very simple fix: the mouse-move event that the test synthesizes to move the mouse away from the autoscroll anchor needs to be routed through APZ, so it can pick up the resulting mouse location.

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1390247 - Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling.

Review commit: https://reviewboard.mozilla.org/r/169340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169340/

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8897083 [details]
Bug 1390247 - Enable APZ autoscrolling on Nightly builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168370/diff/1-2/

Comment 9

[Botond Ballo [:botond]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7533bd57beb26a9b4b82544dcf654feb2250e414

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8898040 [details]
Bug 1390247 - Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling.

https://reviewboard.mozilla.org/r/169340/#review174866

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db173b8cb609
Get browser_bug295977_autoscroll_overflow.js working with APZ autoscrolling. r=kats
https://hg.mozilla.org/integration/autoland/rev/7f118ff40f8f
Enable APZ autoscrolling on Nightly builds. r=kats

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db173b8cb609
https://hg.mozilla.org/mozilla-central/rev/7f118ff40f8f

Comment 13

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #3)
> Maybe send a message to dev-platform too, so people know to file any issues
> they run into.

Posted https://groups.google.com/forum/#!topic/mozilla.dev.platform/J-YxNGzd0pk.