1390249 - Land PingCentre in Nightly under browser/modules

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect)

Description

[Marina Samuel [:emtwo]]

The work for this issue is being done here: https://github.com/mozilla/activity-stream/pull/3140

Comment 1

[Marina Samuel [:emtwo]]

Attachment: Bug 1390249: Add PingCentre to browser/modules.

Review commit: https://reviewboard.mozilla.org/r/168440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168440/

Comment 2

[Marina Samuel [:emtwo]]

Current try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a179ae23207223e92b3742c80368ec5f6370f11

Comment 3

[Kate Hudson :k88hudson]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

https://reviewboard.mozilla.org/r/168440/#review176370

::: browser/app/profile/firefox.js:1516
(Diff revision 1)
>  pref("experiments.supported", true);
>  
> +// Ping Centre Telemetry settings.
> +#ifdef NIGHTLY_BUILD
> +pref("browser.ping-centre.telemetry", true);
> +pref("browser.ping-centre.log", true);

I don't think we want .log on by default for nightly, it's mostly just for local debugging

Comment 4

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/1-2/

Comment 5

[Marina Samuel [:emtwo]]

Note: the tests are in karma and can be found in this PR: https://github.com/mozilla/activity-stream/pull/3140

Comment 6

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/2-3/

Comment 7

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/3-4/

Comment 8

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/4-5/

Comment 9

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/5-6/

Comment 10

[Ursula Sarracini (:ursula)]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

https://reviewboard.mozilla.org/r/168440/#review177578

Looks good! Thanks Marina :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25f127dff090
Add PingCentre to browser/modules. r=ursula

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=125670507&repo=autoland

Comment 13

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff56b0b30628
Backed out changeset 25f127dff090 for browser_all_files_referenced.js failures a=backout CLOSED TREE

Comment 14

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/6-7/

Comment 15

[Marina Samuel [:emtwo]]

Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168440/diff/7-8/

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/944ab211fc31
Add PingCentre to browser/modules. r=ursula

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/944ab211fc31