Land PingCentre in Nightly under browser/modules

RESOLVED FIXED in Firefox 57

Status

()

Firefox
Activity Streams: Newtab
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: emtwo, Assigned: emtwo, NeedInfo)

Tracking

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
The work for this issue is being done here: https://github.com/mozilla/activity-stream/pull/3140
Comment hidden (mozreview-request)

Comment 3

9 months ago
mozreview-review
Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

https://reviewboard.mozilla.org/r/168440/#review176370

::: browser/app/profile/firefox.js:1516
(Diff revision 1)
>  pref("experiments.supported", true);
>  
> +// Ping Centre Telemetry settings.
> +#ifdef NIGHTLY_BUILD
> +pref("browser.ping-centre.telemetry", true);
> +pref("browser.ping-centre.log", true);

I don't think we want .log on by default for nightly, it's mostly just for local debugging
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Attachment #8897142 - Flags: review?(usarracini)
(Assignee)

Comment 5

9 months ago
Note: the tests are in karma and can be found in this PR: https://github.com/mozilla/activity-stream/pull/3140
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

9 months ago
mozreview-review
Comment on attachment 8897142 [details]
Bug 1390249: Add PingCentre to browser/modules.

https://reviewboard.mozilla.org/r/168440/#review177578

Looks good! Thanks Marina :)
Attachment #8897142 - Flags: review?(usarracini) → review+
(Assignee)

Updated

9 months ago
Attachment #8897142 - Flags: checkin?
(Assignee)

Updated

9 months ago
Attachment #8897142 - Flags: checkin?

Comment 11

9 months ago
Pushed by usarracini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25f127dff090
Add PingCentre to browser/modules. r=ursula
Backed out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=125670507&repo=autoland
Flags: needinfo?(msamuel)

Comment 13

9 months ago
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ff56b0b30628
Backed out changeset 25f127dff090 for browser_all_files_referenced.js failures a=backout CLOSED TREE
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 16

9 months ago
Pushed by msamuel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/944ab211fc31
Add PingCentre to browser/modules. r=ursula

Comment 17

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/944ab211fc31
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

9 months ago
Blocks: 1395188

Updated

9 months ago
Blocks: 1393604
You need to log in before you can comment on or make changes to this bug.