1390293 - Re-implement NSUserActivity helper for Handoff

Status: VERIFIED FIXED

(Firefox for iOS :: General, enhancement, P2)

Description

[Justin D'Arcangelo [:justindarc]]

As a follow-up to Bug 1390200, we need to re-implement a better helper for handling NSUserActivity for Handoff support.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Nominating for triage to see when we want to re-introduce this.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3513

Feedback required, especially around naming and API; there's documentation in the TabEventHandler class around potential usage.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Where does this patch call into NSUserActivity? We disabled that code previously, it looks like it is still disabled?

Comment 4

[James Hugman [:jhugman] [@jhugman]]

:st3fan This doesn't yet call into NSUserActivity. I've been asking for feedback for the general approach. It's an architectural change; NSUserActivity is the first consumer of it.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8932985 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3513

Now ready for review!

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Uplifted d30915fe4 to v10.x, as 02b86d184.

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on 10.5 (8741). Handoff is working correctly between two iOS devices and from iOS to macOS.