Re-implement NSUserActivity helper for Handoff

VERIFIED FIXED

Status

()

P2
normal
VERIFIED FIXED
a year ago
9 months ago

People

(Reporter: justindarc, Assigned: jhugman)

Tracking

unspecified
Other
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios10.5, fxios-v10.5 verified)

Details

(Whiteboard: [MobileCore])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
As a follow-up to Bug 1390200, we need to re-implement a better helper for handling NSUserActivity for Handoff support.
(Reporter)

Comment 1

a year ago
Nominating for triage to see when we want to re-introduce this.
tracking-fxios: --- → ?
Depends on: 1390200
Priority: -- → P2
Whiteboard: [MobileCore]
tracking-fxios: ? → 10.0
(Reporter)

Updated

a year ago
See Also: → bug 1368966
tracking-fxios: 10.0 → 10.1

Updated

11 months ago
tracking-fxios: 10.1 → 10.3
(Assignee)

Updated

11 months ago
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 months ago
Created attachment 8932985 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3513

Feedback required, especially around naming and API; there's documentation in the TabEventHandler class around potential usage.
Attachment #8932985 - Flags: feedback?(gkeeley)
Attachment #8932985 - Flags: feedback?(fpatel)

Updated

11 months ago
Attachment #8932985 - Flags: feedback?(gkeeley) → feedback+

Updated

11 months ago
Attachment #8932985 - Flags: feedback?(fpatel) → feedback+

Comment 3

11 months ago
Where does this patch call into NSUserActivity? We disabled that code previously, it looks like it is still disabled?

Updated

11 months ago
Flags: needinfo?(jhugman)
(Assignee)

Comment 4

11 months ago
:st3fan This doesn't yet call into NSUserActivity. I've been asking for feedback for the general approach. It's an architectural change; NSUserActivity is the first consumer of it.
Flags: needinfo?(jhugman)
(Assignee)

Comment 5

11 months ago
Comment on attachment 8932985 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3513

Now ready for review!
Attachment #8932985 - Flags: review?(gkeeley)

Updated

11 months ago
Attachment #8932985 - Flags: review?(gkeeley) → review+
(Assignee)

Updated

10 months ago
Whiteboard: [MobileCore] → [MobileCore][needsUplift]
(Assignee)

Comment 6

10 months ago
Merged into master.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
(Assignee)

Comment 7

9 months ago
Uplifted d30915fe4 to v10.x, as 02b86d184.
(Assignee)

Updated

9 months ago
Whiteboard: [MobileCore][needsUplift] → [MobileCore]

Updated

9 months ago
tracking-fxios: 10.3 → 10.5

Updated

9 months ago
See Also: → bug 1433147

Updated

9 months ago
Depends on: 1433147

Comment 8

9 months ago
Verifying as fix on 10.5 (8741). Handoff is working correctly between two iOS devices and from iOS to macOS.
Status: RESOLVED → VERIFIED
status-fxios-v10.5: --- → verified
You need to log in before you can comment on or make changes to this bug.