Closed Bug 1390336 Opened 7 years ago Closed 7 years ago

Unable to use down arrow to select search result when search bar is in overflow panel

Categories

(Firefox :: Search, defect, P1)

x86_64
Linux
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox57 --- verified

People

(Reporter: catlee, Assigned: mikedeboer)

References

Details

(Whiteboard: [reserve-photon-structure])

Attachments

(1 file)

STR:

1) Customize toolbar to put the search box into the overflow panel
2) Hit Ctrl-K to start a search
3) Hit down-arrow to try and select one of the search suggestions

Expected results:
I should be able to navigate the search suggestions with the arrow keys

Actual results:
The search suggestions disappear, although the overflow panel and search box remain visible.
Whiteboard: [photon][triage]
Whiteboard: [photon][triage] → [photon-structure][triage]
Flags: qe-verify+
Priority: -- → P3
QA Contact: gwimberly
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Just for completeness, rephrasing observations from dupes:

- Left/Right arrow keys (in any ctrl/shift combination) in the search field located in the More Tools menu does nothing -- unlike home/end which work correctly.

- Up/Down arrow keys actually both focuses the "Customize Toolbar" button at the bottom of the "More Tools…" menu, just like Tab key does when the filed is empty -- but unlike the Tab key arrows cannot return focus back.

- The Tab key quite correctly cycles between the Search Field, the Search Engines palette (if visible), the Search Settings button (if visible) and the Customize Toolbar button.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Comment on attachment 8905852 [details]
Bug 1390336 - Disable panelview keyboard navigation using arrow keys in the overflow panel, because input boxes can be in there.

https://reviewboard.mozilla.org/r/177662/#review182736

Makes sense, thanks!
Attachment #8905852 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mdeboer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a0fd0db0fb0
Disable panelview keyboard navigation using arrow keys in the overflow panel, because input boxes can be in there. r=Gijs
Iteration: --- → 57.3 - Sep 19
Priority: P3 → P1
https://hg.mozilla.org/mozilla-central/rev/5a0fd0db0fb0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced the issue mentioned in comment 0, using an affected Firefox 57.0a1 build (BuildId:20170814100258).

I have verified that the issue is not reproducible using Firefox 57.0b6 (Build Id:20171005195903) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.