Closed
Bug 1390698
Opened 8 years ago
Closed 8 years ago
Make an add-on for the opt-out study of Safe Browsing V2/V4
Categories
(Shield :: Shield Study, enhancement, P1)
Shield
Shield Study
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: francois, Assigned: kardekani)
References
()
Details
(Whiteboard: #sbv4-m9)
Attachments
(1 file, 1 obsolete file)
|
40.83 KB,
application/x-xpinstall
|
Details |
We need a bootstrap add-on that flips these prefs in the experiment group:
pref("urlclassifier.malwareTable", "goog-malware-shavar,goog-unwanted-shavar,test-malware-simple,test-unwanted-simple");
pref("urlclassifier.phishTable", "goog-phish-shavar,test-phish-simple");
pref("urlclassifier.downloadAllowTable", "goog-downloadwhite-digest256");
pref("urlclassifier.downloadBlockTable", "goog-badbinurl-shavar");
and then restores them to the default values when it's removed.
The add-on does not need to send any extra telemetry.
| Reporter | ||
Comment 1•8 years ago
|
||
Kamyar, are you able to get this done by next Monday so that we can test it next week and confirm that this approach will work?
Flags: needinfo?(kardekani)
| Reporter | ||
Updated•8 years ago
|
| Reporter | ||
Updated•8 years ago
|
Priority: -- → P1
| Reporter | ||
Comment 2•8 years ago
|
||
Here is the bootstrap add-on for the study.
Mike, is that all you need to get the add-on signed and deployed on Normandy once the study has been approved in bug 1377267?
Flags: needinfo?(mcooper)
Comment 3•8 years ago
|
||
I'm going on pto soon, so I'm redirecting this to Osmose.
Flags: needinfo?(mcooper) → needinfo?(mkelly)
| Reporter | ||
Comment 4•8 years ago
|
||
Kamyar added a small cleanup: https://github.com/raymak/sbv4-crash-shield-study/commit/f1ff8d44232ccde1d605f618806fe7cc84ef36bb#diff-4b80223300be1233ce41b6b9d0c08761R70
Attachment #8906143 -
Attachment is obsolete: true
Flags: needinfo?(kardekani)
Comment 5•8 years ago
|
||
As per the study guidelines[1], we need two things before signing an opt-out study:
- A description of the population we'll be sending the study to, particularly which channels.
- Sign-off that the functionality of the add-on has been tested on the platforms that we'll be sending it to. If the study is going to pre-release channels only, this can be provided by the developer directly.
Include both of those in this bug, and I can sign the add-on for ya'll. :D
[1] https://docs.google.com/document/d/1hOMjZ7l1K0HL8DUp7HCr8BeRO7NGw0SwYjK2nfwtRJQ/edit#heading=h.q8cndfdy29ua
Flags: needinfo?(mkelly) → needinfo?(francois)
| Reporter | ||
Comment 6•8 years ago
|
||
(In reply to Michael Kelly [:mkelly,:Osmose] from comment #5)
> - A description of the population we'll be sending the study to,
> particularly which channels.
100% of Beta 56 population.
> - Sign-off that the functionality of the add-on has been tested on the
> platforms that we'll be sending it to. If the study is going to pre-release
> channels only, this can be provided by the developer directly.
I tested it on Linux, Win32 and Win64. Kamyar tested it on Mac.
Flags: needinfo?(francois)
| Reporter | ||
Comment 7•8 years ago
|
||
Michael, anything else you need before you can sign this add-on?
Flags: needinfo?(mkelly)
Comment 8•8 years ago
|
||
I've signed and uploaded the study to Normandy under the name "Safe Browsing v4 (Crash Rate Test)".
Flags: needinfo?(mkelly)
| Reporter | ||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•