Closed
Bug 1390703
Opened 7 years ago
Closed 7 years ago
Bump Flash Click-to-Play rollout to 25% on release
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
mozilla57
People
(Reporter: Felipe, Assigned: Felipe)
References
()
Details
(Keywords: flashplayer, site-compat)
Attachments
(3 files, 2 obsolete files)
59 bytes,
text/x-review-board-request
|
benjamin
:
review+
lizzard
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-release-
|
Details |
2.63 KB,
application/x-xpinstall
|
wezhou
:
feedback+
|
Details |
6.50 KB,
application/x-xpinstall
|
wezhou
:
review+
|
Details |
Following the original plan, we want to bump Flash CTP to 25% of users on release, ~2 weeks after the original release date. Note: I think the 55 release might be rolling out slower than usual (due to some bugs like bug 1388584 and bug 1388628, I think automatic updates might have been off for longer than usual), so let me know if the original schedule should be adjusted. Otherwise, the target for this is Aug 22.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8897654 [details] Bug 1390703 - Bump Flash Click-to-Play rollout to 25% on release. https://reviewboard.mozilla.org/r/168926/#review174482 r=me RT is going to be product owner of plugins and so he'll decide whether we need to delay the rollout from the original plan because of the 55 dot-release delays.
Attachment #8897654 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Hey there, I've got two system add-ons to sign (on this bug and bug 1390705). Can one of you sign them, please? Thanks in advance.
Attachment #8897995 -
Flags: feedback?(wezhou)
Attachment #8897995 -
Flags: feedback?(jthomas)
Attachment #8897995 -
Flags: feedback?(wezhou)
Attachment #8897995 -
Flags: feedback?(jthomas)
Attachment #8897995 -
Flags: feedback+
Assignee | ||
Comment 5•7 years ago
|
||
Sorry about requesting this again, I had to do a small fix to it.
Attachment #8897995 -
Attachment is obsolete: true
Attachment #8898057 -
Attachment is obsolete: true
Attachment #8899898 -
Flags: feedback?(wezhou)
Comment hidden (mozreview-request) |
Signed file attached. Please test.
Attachment #8899982 -
Flags: review+
Attachment #8899898 -
Flags: feedback?(wezhou) → feedback+
Assignee | ||
Comment 8•7 years ago
|
||
Stefan, could you do some quick testing of this? I published an update.xml file that points to the signed XPI here: https://felipc.github.io/ctp25/update.xml To test: - Use Firefox 55.0.2 release - change the pref `extensions.systemAddon.update.url` to `https://felipc.github.io/ctp25/update.xml` to update - Maybe force a system addon update - Check in about:support that "Click-to-Play staged rollout" should change from version 1.2 to 1.3 What to test: - observe the values of plugins.ctprollout.cohort and plugins.ctprollout.cohortSample, before and after the update Before the update: Sample --> Cohort ------ ------ < 0.05 test in between excluded > 0.95 control After the update: Sample --> Cohort ------ ------ < 0.25 test in between excluded > 0.75 control And also check that "test" represents a "Ask to Activate" setting in about:addons for the Flash plugin, where "control" or "excluded" represents "Always Activate"
Flags: needinfo?(stefan.georgiev)
Comment 9•7 years ago
|
||
I was able to verify the Click-to-Play staged rollout from 1.2 to 1.3 on Windows 10 x64 with the latest Firefox release 55.0.2 I have tested it with the following values for plugins.ctprollout.cohortSample: 0.05, 0.10, 0.5, 0.8, 0.95 0.05 / 0.10 < 0.25 = test (Flash is set to "Ask to Activate") 0.5 = excluded (Flash is set to "Always Activate") 0.8 / 0.95 > 0.75 = control (Flash is set to "Always Activate") Tomorrow I will test and update the bug with results for Ubuntu and OS X.
Comment 10•7 years ago
|
||
I have tested this on Ubuntu 16.04 x64 and OS X 10.12 with the same values for plugins.ctprollout.cohortSample as stated in comment 9. Test results are as follow for both platforms: 0.05 / 0.10 < 0.25 = test (Flash is set to "Ask to Activate") 0.5 = excluded (Flash is set to "Always Activate") 0.8 / 0.95 > 0.75 = control (Flash is set to "Always Activate")
Flags: needinfo?(stefan.georgiev)
Assignee | ||
Comment 11•7 years ago
|
||
Thanks Stefan! Everything looks correct
Assignee | ||
Comment 12•7 years ago
|
||
Update: we're good to go. The plan is to publish this update today.
Comment 13•7 years ago
|
||
OK. Please let me know if you need my signoff in balrog.
Comment 14•7 years ago
|
||
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6ba84c8ef63 Bump Flash Click-to-Play rollout to 25% on release. r=bsmedberg
Assignee | ||
Comment 15•7 years ago
|
||
Comment on attachment 8897654 [details] Bug 1390703 - Bump Flash Click-to-Play rollout to 25% on release. Approval Request Comment [Feature/Bug causing the regression]: This is going out to release users via GoFaster, and I landed the change on mozilla-central, so it's good to keep this in sync on mozilla-beta too. [User impact if declined]: Beta code would be different than central and release.. And Firefox 56 would start at 5% again instead of 25%, and require anothre GoFaster update [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: doesn't apply [Needs manual test from QE? If yes, steps to reproduce]: QA was completed on this [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: tested addon that just toggles the setting for Flash [String changes made/needed]: none
Attachment #8897654 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 16•7 years ago
|
||
Needinfo'ing Rehan for the GoFaster deployment: Channel: Release 55, all platforms Sample: 100%
Flags: needinfo?(rdalal)
Comment 17•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b6ba84c8ef63
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 18•7 years ago
|
||
Comment on attachment 8897654 [details] Bug 1390703 - Bump Flash Click-to-Play rollout to 25% on release. Setting this up to be in place once 56 moves to release.
Attachment #8897654 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 19•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/94cf7f1ee06b
status-firefox56:
--- → fixed
Comment 20•7 years ago
|
||
This is on the "release-sysaddon" testing channel. Felipe can you confirm it is working? I've also created a rule in balrog for "release" which is pending QE/Relman sign off.
Flags: needinfo?(rdalal) → needinfo?(felipc)
Comment 23•7 years ago
|
||
This will also need QA sign off I assume from Stefan?
Flags: needinfo?(stefan.georgiev)
Comment 24•7 years ago
|
||
Done, looks like we have QE signoff from around Aug. 23rd via email.
Flags: needinfo?(lhenry)
Updated•7 years ago
|
Flags: needinfo?(stefan.georgiev)
Assignee | ||
Comment 25•7 years ago
|
||
This has been released via GoFaster to Release 55. It's good practice to then also uplift this to mozilla-release (so that it comes built-in in case we have to ship a new dot release), so I'll request approval for that
Assignee | ||
Comment 26•7 years ago
|
||
Comment on attachment 8897654 [details] Bug 1390703 - Bump Flash Click-to-Play rollout to 25% on release. Approval Request Comment [Feature/Bug causing the regression]: Flash Click-to-Play by default [User impact if declined]: If a new dot release is shipped, users will temporarily revert to 5% rollout instead of 25% until they receive a new system addon update [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: not applicable [Needs manual test from QE? If yes, steps to reproduce]: Already tested by QE [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: contained to the click-to-play setting, and already shipped to release via a system add-on update [String changes made/needed]:
Attachment #8897654 -
Flags: approval-mozilla-release?
Comment 27•7 years ago
|
||
This is already live for 55, right? So maybe uplifting to 56 is your goal here? 56 will be on m-r at some point early tomorrow.
Flags: needinfo?(felipc)
Assignee | ||
Comment 28•7 years ago
|
||
Yes, this is live for 55 through a system add-on update, but any time we do that we should also uplift to mozilla-release in case a new 55 dot release is built, so that this update can be included built-in.
Flags: needinfo?(felipc)
Comment 29•7 years ago
|
||
Comment on attachment 8897654 [details] Bug 1390703 - Bump Flash Click-to-Play rollout to 25% on release. no more 55 dot releases planned, and 56 is about to go on m-r.
Attachment #8897654 -
Flags: approval-mozilla-release? → approval-mozilla-release-
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•