Closed
Bug 1390705
Opened 7 years ago
Closed 7 years ago
Bump Flash Click-to-Play rollout to 100% on release
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(firefox56+ fixed, firefox57 fixed)
RESOLVED
FIXED
mozilla57
People
(Reporter: Felipe, Assigned: Felipe)
References
()
Details
(Keywords: flashplayer, site-compat)
Attachments
(3 files, 2 obsolete files)
59 bytes,
text/x-review-board-request
|
benjamin
:
review+
lizzard
:
approval-mozilla-beta-
lizzard
:
approval-mozilla-release+
|
Details |
2.62 KB,
application/x-xpinstall
|
wezhou
:
feedback+
|
Details |
6.49 KB,
application/x-xpinstall
|
wezhou
:
feedback+
|
Details |
+++ This bug was initially created as a clone of Bug #1390703 +++
Following the original plan, we want to bump Flash CTP to 100% of users on release, ~4 weeks after the original release date.
The target for this is Sep 5.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8897655 [details]
Bug 1390705 - Bump Flash Click-to-Play rollout to 100% on release.
https://reviewboard.mozilla.org/r/168930/#review174484
Attachment #8897655 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Hey there, I've got two system add-ons to sign (on this bug and bug 1390705). Can one of you sign them, please?
Thanks in advance.
Attachment #8897996 -
Flags: feedback?(wezhou)
Attachment #8897996 -
Flags: feedback?(jthomas)
Attachment #8897996 -
Flags: feedback?(wezhou)
Attachment #8897996 -
Flags: feedback?(jthomas)
Attachment #8897996 -
Flags: feedback+
Assignee | ||
Comment 5•7 years ago
|
||
Sorry about requesting this again, I had to do a small fix to it
Attachment #8897996 -
Attachment is obsolete: true
Attachment #8898059 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8899899 -
Flags: feedback?(wezhou)
Comment hidden (mozreview-request) |
Signed file attached. Please test.
Attachment #8899990 -
Flags: feedback+
Attachment #8899899 -
Flags: feedback?(wezhou) → feedback+
Assignee | ||
Comment 8•7 years ago
|
||
Stefan, once you finish the testing on bug 1390703, you can do the same testing here, with the following differences:
- Use `https://felipc.github.io/ctp100/update.xml` as the value for `extensions.systemAddon.update.url`
- The updated add-on version will be 1.4
- All cohort sample values will lead to the cohort name "test" -> "Ask to Activate"
It would be nice to test this update both:
- directly from version 1.2
- after a first step update to 1.3
Flags: needinfo?(stefan.georgiev)
Comment 9•7 years ago
|
||
I've tested the Click-to-Play staged roll out from (1.2 to 1.4) and (1.3 to 1.4) on Windows 10 x64 with the latest Firefox release 55.0.2.
I have tested it with the following values for plugins.ctprollout.cohortSample: 0.05, 0.10, 0.5, 0.8, 0.95
The updates from 1.2 to 1.4 for all values sets the Shockwave Flash plugin to "Ask to Activate".
The updates from 1.3 to 1.4 for all values sets the Shockwave Flash plugin to "Ask to Activate".
Tomorrow I will test and update the bug with results for Ubuntu and OS X.
Flags: needinfo?(stefan.georgiev)
Comment 10•7 years ago
|
||
I've finished testing the Flash Click-to-Play staged rollout from (1.2 to 1.4) and (1.3 to 1.4) on Ubuntu 16.04 x64 and OS X 10.12 x64.
The updates was tested with the same values for plugins.ctprollout.cohortSample as stated in comment 9.
The updates from 1.2 to 1.4 for all values sets the Shockwave Flash plugin to "Ask to Activate" on all tested platforms.
The updates from 1.3 to 1.4 for all values sets the Shockwave Flash plugin to "Ask to Activate" on all tested platforms.
No issues found.
Assignee | ||
Comment 11•7 years ago
|
||
Hey, just so that I can plan accordingly, when would be the last opportunity to nominate this to get into the 56 RC? We might decide in a couple of days to increase this rollout to 100%, and it would be nice if this ships by default in 56 instead of having to do a system addon update.
Flags: needinfo?(lhenry)
Flags: needinfo?(jcristau)
Comment 12•7 years ago
|
||
After we know the migration is done - likely later today
Comment 13•7 years ago
|
||
Oh, I misunderstood the question. The earliest we should uplift is (likely) a bit later today. Latest, I'd say Sunday night/early next Monday morning. I will want to go to build at some point around noon or as early as possible on Monday. We will very likely end up with an RC2 later in the week. So that is another opportunity.
Flags: needinfo?(lhenry)
Updated•7 years ago
|
status-firefox56:
--- → affected
tracking-firefox56:
--- → +
Assignee | ||
Comment 15•7 years ago
|
||
Hi Rehan, following the Flash rollout plan, it's time now to bump flash to 100% of users on 55, which this version of the system add-on does. Stefan has already QA'ed it (see comment 10). Could you publish this to the release channel, pending Liz's sign-off?
Target: 55, all platforms, 100%.
Flags: needinfo?(rdalal)
Assignee | ||
Comment 16•7 years ago
|
||
Comment on attachment 8897655 [details]
Bug 1390705 - Bump Flash Click-to-Play rollout to 100% on release.
Approval Request Comment
[Feature/Bug causing the regression]: Flash click-to-play rollout. This is going out to 55 users through a system add-on update, and I'd like to land it in-tree for 56 to avoid the need of doing the same system add-on update process for 56.
[User impact if declined]: 25% of users are activated at the moment, the plan is to go to 100%
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not applicable
[Needs manual test from QE? If yes, steps to reproduce]: Already done
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just changes the numerical value for the flash click-to-play activation.
[String changes made/needed]:
Attachment #8897655 -
Flags: approval-mozilla-release?
Attachment #8897655 -
Flags: approval-mozilla-beta?
Comment 17•7 years ago
|
||
Comment on attachment 8897655 [details]
Bug 1390705 - Bump Flash Click-to-Play rollout to 100% on release.
This can land on m-r for 56 RC build today. But if it doesn't make it till after we go to build, that's OK, since I'm sure we will have an RC2 later in the week.
Attachment #8897655 -
Flags: approval-mozilla-release?
Attachment #8897655 -
Flags: approval-mozilla-release+
Attachment #8897655 -
Flags: approval-mozilla-beta?
Attachment #8897655 -
Flags: approval-mozilla-beta-
Comment 18•7 years ago
|
||
bugherder uplift |
Assignee | ||
Comment 19•7 years ago
|
||
Comment 20•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 21•7 years ago
|
||
We managed to verify this issue on Firefox 56.0 under Windows 10x64, Ubuntu 16.04x86 and under macOS 10.12.
Click-to-Play staged rollout is set to 1.4 by default, but the Shockwave Flash is set to 'Always Activate' instead of 'Ask to Activate' (see Comment 8). Is this an expected behavior?
Flags: needinfo?(felipc)
Assignee | ||
Comment 22•7 years ago
|
||
Hi Mihai, did you change the value of app.update.channel to perform these tests? Can you let me know what the value of the following prefs are:
plugins.ctprollout.cohortSample
plugins.ctprollout.cohort
plugin.state.flash
app.update.channel
And give me a link for these builds that you tested? (I'm guessing it's the RC)
Flags: needinfo?(felipc) → needinfo?(mihai.boldan)
Assignee | ||
Comment 23•7 years ago
|
||
Actually, I can reproduce the problem. It's a regression from bug 1357517 which was meant to be fixed by bug 1397379 but turns out it wasn't. I'll file a bug for it.
Flags: needinfo?(mihai.boldan)
Assignee | ||
Comment 24•7 years ago
|
||
Rehan can continue the deployment of this via GoFaster to 55, since it doesn't affect 55.
Assignee | ||
Comment 25•7 years ago
|
||
(In reply to Mihai Boldan, QA [:mboldan] from comment #21)
> We managed to verify this issue on Firefox 56.0 under Windows 10x64, Ubuntu
> 16.04x86 and under macOS 10.12.
> Click-to-Play staged rollout is set to 1.4 by default, but the Shockwave
> Flash is set to 'Always Activate' instead of 'Ask to Activate' (see Comment
> 8). Is this an expected behavior?
Thanks a lot for catching this. Filed bug 1401249 for it.
Comment 26•7 years ago
|
||
This has been shipped to the test channel "release-sysaddon". Felipe, could you confirm it works correctly?
I've also added a rule for the "release" channel which is pending sign off from QA/relman.
Flags: needinfo?(ryanvm)
Flags: needinfo?(rdalal)
Flags: needinfo?(lhenry)
Flags: needinfo?(felipc)
Assignee | ||
Comment 27•7 years ago
|
||
I verified that it works on the testing "release-sysaddon" channel.
Liz/Stefan, can you sign it off in Balrog?
Flags: needinfo?(felipc) → needinfo?(stefan.georgiev)
Comment 28•7 years ago
|
||
Stefan is busy with other things right now. I've done the QE signoff.
Flags: needinfo?(stefan.georgiev)
Flags: needinfo?(ryanvm)
Comment 29•7 years ago
|
||
signed off as relman, so clicktoplay-rollout SAO version 1.4 is now live on release 55.
Flags: needinfo?(lhenry)
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•