Closed Bug 1390725 Opened 4 years ago Closed 4 years ago

Change the loading path of CDM host verification file on Mac

Categories

(Core :: Audio/Video: GMP, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

References

Details

Attachments

(1 file)

Bug 1390552 will try to change the file location of sig file for Firefox on Mac.

We need to do the corresponding change to load the sig file at right place.
Blocks: 1388771
Attachment #8897936 - Flags: review?(cpearce)
Comment on attachment 8897936 [details]
Bug 1390725 - Change the loading path of CDM host verification file on Mac.

https://reviewboard.mozilla.org/r/169224/#review174734

::: dom/media/gmp/GMPChild.cpp:505
(Diff revision 1)
>    nsCString result;
> -  for (const nsCString& s : aStrings) {
> +  for (const auto& p : aPairs) {
>      if (!result.IsEmpty()) {
>        result.AppendLiteral(",");
>      }
> -    result.Append(s);
> +    result.Append(p.first());

I think you should instead append each pair as:
nsPrintfCString("(%s,%s)", p.first().get(), p.second().get())

As you're currently just appending the first of the pair, and so you're not logging the second of the pair.
Attachment #8897936 - Flags: review?(cpearce) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5e2b2fb7858
Change the loading path of CDM host verification file on Mac. r=cpearce
https://hg.mozilla.org/mozilla-central/rev/d5e2b2fb7858
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1392175
Comment on attachment 8897936 [details]
Bug 1390725 - Change the loading path of CDM host verification file on Mac.

Approval Request Comment
[Feature/Bug causing the regression]:NO
[User impact if declined]: user could not play DRM content. When we update new CDM.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:
Please follow this order for uplifting
1. Bug 1390453
2. Bug 1390739
3. This Bug 1390725
4. Bug 1392175 
[Is the change risky?]:No
[Why is the change risky/not risky?]:The change did not effect on the current CDM.  
[String changes made/needed]: No
Attachment #8897936 - Flags: approval-mozilla-beta?
Comment on attachment 8897936 [details]
Bug 1390725 - Change the loading path of CDM host verification file on Mac.

#3 of several patches to update the CDM for beta 6.
Attachment #8897936 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.