Closed Bug 1390874 Opened 3 years ago Closed 3 years ago

Run browser_startup_images.js on double device pixel ratio

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: johannh, Assigned: johannh)

References

Details

Attachments

(1 file)

Bug 1328830 gave us the ability to set prefs in mochitest manifests, so we can set the layout.css.devPixelsPerPx pref to emulate retina screens for testing that we're missing no high-res images that are loaded and that this test run consistently on all platforms.
Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

https://reviewboard.mozilla.org/r/169134/#review174494

Looks good if you think we'll have other tests that will want to run both in hidpi and lowdpi. If not, then I would make 'hidpi' a subdir of 'performance'.

Is the default always low DPI (eg. for mac) now? Or would we need to set the pref to 1 on the 'performance' folder to ensure we have coverage for both set of icons on Mac?
Attachment #8897843 - Flags: review?(florian) → review+
Ok, I switched to two subfolders: performance/hidpi and performance/lowdpi. I think that makes most sense and guarantees that we're always testing both. Thanks for the input!

Feel free to take another look, I'm not re-requesting review since it's basically the same as the previous commit with some files moved around. I'll land this as soon as the try is green.
Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

https://reviewboard.mozilla.org/r/169134/#review174520

Looks good to me!

::: browser/base/content/test/performance/browser_startup_images.js:108
(Diff revision 2)
>    },
>  ];
>  
>  add_task(async function() {
> +  if (!AppConstants.DEBUG) {
> +    ok(false, "You need to run this test in debug mode.");

maybe 'on a debug build' to be even more explicit.
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a543fedee9c
Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. r=florian
https://hg.mozilla.org/mozilla-central/rev/0a543fedee9c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Backed out for unexpected pass and unexpected fail in mochitest browser_startup_images.js, at least on Windows:

https://hg.mozilla.org/mozilla-central/rev/530e399d9027dd4243f4d0eafd34035faafd84ab

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123847703&repo=mozilla-central
11:57:28    ERROR -  53 INFO TEST-UNEXPECTED-PASS | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/chevron.svg should not have been shown. -
11:57:28     INFO -  Stack trace:
11:57:28     INFO -  chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:128
11:57:28     INFO -  TEST-INFO | expected FAIL
11:57:28     INFO -  TEST-INFO | started process screenshot
11:57:28     INFO -  TEST-INFO | screenshot: exit 0
11:57:28    ERROR -  54 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/sidebars.svg should have been shown. -
11:57:28     INFO -  Stack trace:
11:57:28     INFO -  chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:132
Status: RESOLVED → REOPENED
Flags: needinfo?(jhofmann)
Resolution: FIXED → ---
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5534f9aff56b
Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. r=florian
https://hg.mozilla.org/mozilla-central/rev/5534f9aff56b
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
See Also: → 1400357
You need to log in before you can comment on or make changes to this bug.