Closed
Bug 1390874
Opened 7 years ago
Closed 7 years ago
Run browser_startup_images.js on double device pixel ratio
Categories
(Firefox :: Theme, enhancement)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: johannh, Assigned: johannh)
References
Details
Attachments
(1 file)
Bug 1328830 gave us the ability to set prefs in mochitest manifests, so we can set the layout.css.devPixelsPerPx pref to emulate retina screens for testing that we're missing no high-res images that are loaded and that this test run consistently on all platforms.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5503e3674e7ad8d8c4922708c7173c3848c0df24
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8897843 [details] Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. https://reviewboard.mozilla.org/r/169134/#review174494 Looks good if you think we'll have other tests that will want to run both in hidpi and lowdpi. If not, then I would make 'hidpi' a subdir of 'performance'. Is the default always low DPI (eg. for mac) now? Or would we need to set the pref to 1 on the 'performance' folder to ensure we have coverage for both set of icons on Mac?
Attachment #8897843 -
Flags: review?(florian) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=189db23a80c2af7c9794e6612b8c4f3cd54ed3e8
Assignee | ||
Comment 6•7 years ago
|
||
Ok, I switched to two subfolders: performance/hidpi and performance/lowdpi. I think that makes most sense and guarantees that we're always testing both. Thanks for the input! Feel free to take another look, I'm not re-requesting review since it's basically the same as the previous commit with some files moved around. I'll land this as soon as the try is green.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8897843 [details] Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. https://reviewboard.mozilla.org/r/169134/#review174520 Looks good to me! ::: browser/base/content/test/performance/browser_startup_images.js:108 (Diff revision 2) > }, > ]; > > add_task(async function() { > + if (!AppConstants.DEBUG) { > + ok(false, "You need to run this test in debug mode."); maybe 'on a debug build' to be even more explicit.
Comment hidden (mozreview-request) |
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a543fedee9c Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. r=florian
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0a543fedee9c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 11•7 years ago
|
||
Backed out for unexpected pass and unexpected fail in mochitest browser_startup_images.js, at least on Windows: https://hg.mozilla.org/mozilla-central/rev/530e399d9027dd4243f4d0eafd34035faafd84ab Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123847703&repo=mozilla-central 11:57:28 ERROR - 53 INFO TEST-UNEXPECTED-PASS | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/chevron.svg should not have been shown. - 11:57:28 INFO - Stack trace: 11:57:28 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:128 11:57:28 INFO - TEST-INFO | expected FAIL 11:57:28 INFO - TEST-INFO | started process screenshot 11:57:28 INFO - TEST-INFO | screenshot: exit 0 11:57:28 ERROR - 54 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/sidebars.svg should have been shown. - 11:57:28 INFO - Stack trace: 11:57:28 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:132
Status: RESOLVED → REOPENED
Flags: needinfo?(jhofmann)
Resolution: FIXED → ---
Assignee | ||
Comment 12•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=da5154b2c49ae7b735887772374cfdf209bffb66
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e28339826a1550b02828cc90b80d5219f42e391d
Comment hidden (mozreview-request) |
Assignee | ||
Comment 16•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=30a52bcceeb19648e59c10ad29e1c71ca2e4e427
Comment hidden (mozreview-request) |
Comment 18•7 years ago
|
||
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5534f9aff56b Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. r=florian
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5534f9aff56b
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jhofmann)
You need to log in
before you can comment on or make changes to this bug.
Description
•