1390874 - Run browser_startup_images.js on double device pixel ratio

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Johann Hofmann [:johannh]]

Bug 1328830 gave us the ability to set prefs in mochitest manifests, so we can set the layout.css.devPixelsPerPx pref to emulate retina screens for testing that we're missing no high-res images that are loaded and that this test run consistently on all platforms.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

Also adds a warning that the test should only be used in debug mode.

Review commit: https://reviewboard.mozilla.org/r/169134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169134/

Comment 2

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5503e3674e7ad8d8c4922708c7173c3848c0df24

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

https://reviewboard.mozilla.org/r/169134/#review174494

Looks good if you think we'll have other tests that will want to run both in hidpi and lowdpi. If not, then I would make 'hidpi' a subdir of 'performance'.

Is the default always low DPI (eg. for mac) now? Or would we need to set the pref to 1 on the 'performance' folder to ensure we have coverage for both set of icons on Mac?

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169134/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=189db23a80c2af7c9794e6612b8c4f3cd54ed3e8

Comment 6

[Johann Hofmann [:johannh]]

Ok, I switched to two subfolders: performance/hidpi and performance/lowdpi. I think that makes most sense and guarantees that we're always testing both. Thanks for the input!

Feel free to take another look, I'm not re-requesting review since it's basically the same as the previous commit with some files moved around. I'll land this as soon as the try is green.

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

https://reviewboard.mozilla.org/r/169134/#review174520

Looks good to me!

::: browser/base/content/test/performance/browser_startup_images.js:108
(Diff revision 2)
>    },
>  ];
>  
>  add_task(async function() {
> +  if (!AppConstants.DEBUG) {
> +    ok(false, "You need to run this test in debug mode.");

maybe 'on a debug build' to be even more explicit.

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169134/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a543fedee9c
Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. r=florian

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0a543fedee9c

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for unexpected pass and unexpected fail in mochitest browser_startup_images.js, at least on Windows:

https://hg.mozilla.org/mozilla-central/rev/530e399d9027dd4243f4d0eafd34035faafd84ab

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123847703&repo=mozilla-central
11:57:28    ERROR -  53 INFO TEST-UNEXPECTED-PASS | browser/base/content/test/performance/browser_startup_images.js | Whitelisted image chrome://browser/skin/chevron.svg should not have been shown. -
11:57:28     INFO -  Stack trace:
11:57:28     INFO -  chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:128
11:57:28     INFO -  TEST-INFO | expected FAIL
11:57:28     INFO -  TEST-INFO | started process screenshot
11:57:28     INFO -  TEST-INFO | screenshot: exit 0
11:57:28    ERROR -  54 INFO TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://browser/skin/sidebars.svg should have been shown. -
11:57:28     INFO -  Stack trace:
11:57:28     INFO -  chrome://mochitests/content/browser/browser/base/content/test/performance/browser_startup_images.js:null:132

Comment 12

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da5154b2c49ae7b735887772374cfdf209bffb66

Comment 13

[Johann Hofmann [:johannh]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169134/diff/3-4/

Comment 14

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e28339826a1550b02828cc90b80d5219f42e391d

Comment 15

[Johann Hofmann [:johannh]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169134/diff/4-5/

Comment 16

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30a52bcceeb19648e59c10ad29e1c71ca2e4e427

Comment 17

[Johann Hofmann [:johannh]]

Comment on attachment 8897843 [details]
Bug 1390874 - Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169134/diff/5-6/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5534f9aff56b
Add a hidpi test directory to emulate high screen resolution for browser_startup_images.js. r=florian

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5534f9aff56b