1390885 - When Title Bar is enabled the Themes selector flickers

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[ovidiu boca[:Ovidiu]]

[Affected versions]:

Nightly 57.0a1(2017-08-15)

[Affected platforms]:

Reproducible only on Mac. 

[Steps to reproduce]:

1. Go to Customize
2. Enable "Title Bar"
3. Click on "Themes" and hover your mouse over the available themes.

[Expected result]:

The themes change one by one depending on the one that is selected. 

[Actual result]:

The themes change but with flicker.

Comment 1

[ovidiu boca[:Ovidiu]]

Attachment: Recording #42.mp4

Comment 2

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Marco, SoftVision recommended we fix this bug in the beta57 cycle. Triage has tagged this as P3. Does that mean we will get to it before 57 goes live or not? Thanks

Comment 3

[Marco Mucci [:MarcoM]]

(In reply to Ritu Kothari (:ritu) from comment #2)
> Hi Marco, SoftVision recommended we fix this bug in the beta57 cycle. Triage
> has tagged this as P3. Does that mean we will get to it before 57 goes live
> or not? Thanks

We are aiming for that.  It just hasn't been picked up yet.

Comment 4

[Johann Hofmann [:johannh]]

Removing photon-visual since this isn't a regression caused by us (I can reproduce in 55), I'll still take a moment to look into this.

Comment 6

[Johann Hofmann [:johannh]]

Attachment: Bug 1390885 - Remove code that adjusts the titlebar to drawing lwthemes inside the titlebar.

We got rid of drawing lwthemes inside the titlebar on OSX in bug 1392219 but
there was still some code that adjusted the titlebar, which we forgot
remove. Incidentally, that code was also causing a bug (even before we
removed the in-titlebar drawing) which we now don't need to worry about
anymore now.

Review commit: https://reviewboard.mozilla.org/r/184744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184744/

Comment 7

[Johann Hofmann [:johannh]]

Sorry for the back and forth, but I'm pulling this back into photon-visual since the solution turns out to be a fix for a regression we introduced in bug 1392219 (the titlebar not showing the window title). We should track this.

Comment 8

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f93145c9bdab0046d6ab9a06a148f90d3bf07c9

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for 57, please request uplift to bet57 when the fix is ready and stable.

Comment 10

[Johann Hofmann [:johannh]]

Comment on attachment 8913414 [details]
Bug 1390885 - Remove code that adjusts the titlebar to drawing lwthemes inside the titlebar.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184744/diff/1-2/

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8913414 [details]
Bug 1390885 - Remove code that adjusts the titlebar to drawing lwthemes inside the titlebar.

https://reviewboard.mozilla.org/r/184744/#review190108

Glad to have this fixed, thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074089753394
Remove code that adjusts the titlebar to drawing lwthemes inside the titlebar. r=nhnt11

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/074089753394

Comment 14

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.12 with FF Nightly 57.0a1(2017-10-01) and I can confirm the fix. This needs to be verified on Beta after this fix will be uplifted.

Comment 15

[Johann Hofmann [:johannh]]

Comment on attachment 8913414 [details]
Bug 1390885 - Remove code that adjusts the titlebar to drawing lwthemes inside the titlebar.

Approval Request Comment
[Feature/Bug causing the regression]: I don't know, it's been around for some time apparently.
[User impact if declined]: On OSX, when the titlebar is enabled, the Theme selector flickers quite heavily.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Enable the titlebar, hover over themes in customize mode.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: We're removing unneeded code that was only run under OSX.
[String changes made/needed]: None

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8913414 [details]
Bug 1390885 - Remove code that adjusts the titlebar to drawing lwthemes inside the titlebar.

Fix was verified on nightly, beta57+

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/10c0c1c42bfd

Comment 18

[ovidiu boca[:Ovidiu]]

I verified this issue on Mac OS 10.10 with FF 57.0b5 and I can confirm the fix. I comment 14 I wanted to say Nightly 58.0a1.