Closed Bug 1392219 Opened 7 years ago Closed 7 years ago

Window title is unreadable when the title bar is enabled with dark themes on MacOS

Categories

(Firefox :: Theme, defect, P1)

Unspecified
macOS
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.3 - Sep 19
Tracking Status
firefox57 --- verified

People

(Reporter: nhnt11, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(2 files)

It's fine immediately after enabling from customize mode, but once Firefox is restarted it's unreadable.

The bug can be immediately reproduced by toggling browser.tabs.drawInTitlebar in about:config instead of going through customize mode.

I can't remember if a bug was filed for this already, and if it was, I can't find it, so I'm filing this now.
The patch just makes sure that the titlebar always takes native appearance (the grey gradient), as a band-aid fix for the unreadable text.

Markus, it seems like frontend doesn't have control over the text color of the titlebar label (the text itself doesn't show up in the inspector, and setting the foreground color from CSS has no effect). My guess is that the text is being drawn directly by something at the OS/platform level. Can you comment on how feasible it would be to make it possible to control the text color, so that we can keep a dark background titlebar in the dark theme without the title bar text being invisible?
Flags: needinfo?(mstange)
There's a patch in bug 486536 that demonstrates that we can apply some hacks to the (private) implementation of Cocoa's titlebar drawing in order to specify the color, but it would be nice if we could avoid doing that.
My preferred solution to this problem would be to put the title string into the browser XUL structure, and then always draw into the titlebar and never use the native titlebar for browser windows. Then the frontend would have full control over the title bar's appearance. There was some discussion about this in bug 1381004, although in a different context.
Flags: needinfo?(mstange)
Flags: qe-verify+
Priority: -- → P3
QA Contact: ovidiu.boca
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Assignee: nobody → nhnt11
Priority: P3 → P1
Status: NEW → ASSIGNED
Iteration: --- → 57.3 - Sep 19
Comment on attachment 8902216 [details]
Bug 1392219 - Always use native titlebar appearance on MacOS when it is enabled.

https://reviewboard.mozilla.org/r/173692/#review182236

::: browser/base/content/browser.css:250
(Diff revision 2)
>    -moz-window-dragging: no-drag;
>  }
>  
>  %ifdef XP_MACOSX
> +#titlebar {
> +  -moz-appearance: -moz-window-titlebar;

Seems like we should update http://searchfox.org/mozilla-central/rev/67f38de2443e6b613d874fcf4d2cd1f2fc3d5e97/browser/themes/osx/browser.css#82-84 instead
Attachment #8902216 - Flags: review?(dao+bmo) → review-
Is this related to this regression that appeared yesterday on 10.13? http://i.imgur.com/bq2ZBMS.png
(In reply to Alex from comment #6)
> Is this related to this regression that appeared yesterday on 10.13?
> http://i.imgur.com/bq2ZBMS.png

No, that one is bug 1391790 which is a regression from bug 1324892.
This issue should address also some other themes like "Space Fantasy". The text is barely visible as can be check in the attached screenshot. Thank you
Comment on attachment 8902216 [details]
Bug 1392219 - Always use native titlebar appearance on MacOS when it is enabled.

https://reviewboard.mozilla.org/r/173692/#review183696
Attachment #8902216 - Flags: review?(dao+bmo) → review+
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8ab8827d56b6
Always use native titlebar appearance on MacOS when it is enabled. r=dao
https://hg.mozilla.org/mozilla-central/rev/8ab8827d56b6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I tested this on Mac OS X 10.12 with FF Nightly 57.0a1(2017-09-13) and I can confirm the fix, the text from the title bar is visible when dark theme is enabled.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1390885
Depends on: 1417396
You need to log in before you can comment on or make changes to this bug.