Closed Bug 1390888 Opened 3 years ago Closed 3 years ago

[macOS] Remove white inset shadow on the window

Categories

(Core :: Widget: Cocoa, enhancement, P1)

57 Branch
All
macOS
enhancement

Tracking

()

VERIFIED FIXED
mozilla57
Iteration:
57.2 - Aug 29
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: shorlander, Assigned: mstange)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(2 files)

The window has a translucent white inset shadow. This looks fine on windows with the traditional gradient but doesn't look nice with the flat look and vibrancy.

I am not entirely sure how this is rendered. Is this something we can change in the theme or is it tied to the native window implementation?
Whiteboard: [photon-visual] → [photon-visual] [triage]
Priority: P1 → --
We draw it in the widget. We can just stop drawing it completely.
Flags: needinfo?(mstange)
Assignee: nobody → mstange
Status: NEW → ASSIGNED
Component: Theme → Widget: Cocoa
Product: Firefox → Core
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [photon-visual] [triage] → [reserve-photon-visual]
Comment on attachment 8897929 [details]
Bug 1390888 - Stop drawing the titlebar highlight line.

https://reviewboard.mozilla.org/r/169210/#review174610
Attachment #8897929 - Flags: review?(spohl.mozilla.bugs) → review+
Comment on attachment 8897928 [details]
Bug 1390888 - Correctly draw into mTitlebarCGContext and invalidate the right parts if mTitlebarRect is not located at (0, 0).

https://reviewboard.mozilla.org/r/169208/#review174612
Attachment #8897928 - Flags: review?(spohl.mozilla.bugs) → review+
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/0445256375b3
Correctly draw into mTitlebarCGContext and invalidate the right parts if mTitlebarRect is not located at (0, 0). r=spohl
https://hg.mozilla.org/integration/autoland/rev/32ef66091d9e
Stop drawing the titlebar highlight line. r=spohl
https://hg.mozilla.org/mozilla-central/rev/0445256375b3
https://hg.mozilla.org/mozilla-central/rev/32ef66091d9e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify? → qe-verify+
QA Contact: ovidiu.boca
Blocks: 1390328
Depends on: 1391689
Depends on: 1392574
I tested this issue on Mac Os X 10.10 with FF Nightly 57.0a1(2017-10-18) and with FF beta 57.0b9 and I can confirm the fix.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.