1390888 - [macOS] Remove white inset shadow on the window

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, enhancement, P1)

Description

[Stephen Horlander [:shorlander]]

The window has a translucent white inset shadow. This looks fine on windows with the traditional gradient but doesn't look nice with the flat look and vibrancy.

I am not entirely sure how this is rendered. Is this something we can change in the theme or is it tied to the native window implementation?

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1390888 - Correctly draw into mTitlebarCGContext and invalidate the right parts if mTitlebarRect is not located at (0, 0).

Review commit: https://reviewboard.mozilla.org/r/169208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169208/

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1390888 - Stop drawing the titlebar highlight line.

This line is subtle enough to not be noticeable with light titlebar fills,
and looks out of place with dark titlebar fills.

Review commit: https://reviewboard.mozilla.org/r/169210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169210/

Comment 3

[Markus Stange [:mstange]]

We draw it in the widget. We can just stop drawing it completely.

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8897928 [details]
Bug 1390888 - Correctly draw into mTitlebarCGContext and invalidate the right parts if mTitlebarRect is not located at (0, 0).

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169208/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8897929 [details]
Bug 1390888 - Stop drawing the titlebar highlight line.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169210/diff/1-2/

Comment 6

[Stephen A Pohl [:spohl]]

Comment on attachment 8897929 [details]
Bug 1390888 - Stop drawing the titlebar highlight line.

https://reviewboard.mozilla.org/r/169210/#review174610

Comment 7

[Stephen A Pohl [:spohl]]

Comment on attachment 8897928 [details]
Bug 1390888 - Correctly draw into mTitlebarCGContext and invalidate the right parts if mTitlebarRect is not located at (0, 0).

https://reviewboard.mozilla.org/r/169208/#review174612

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0445256375b3
Correctly draw into mTitlebarCGContext and invalidate the right parts if mTitlebarRect is not located at (0, 0). r=spohl
https://hg.mozilla.org/integration/autoland/rev/32ef66091d9e
Stop drawing the titlebar highlight line. r=spohl

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0445256375b3
https://hg.mozilla.org/mozilla-central/rev/32ef66091d9e

Comment 10

[ovidiu boca[:Ovidiu]]

I tested this issue on Mac Os X 10.10 with FF Nightly 57.0a1(2017-10-18) and with FF beta 57.0b9 and I can confirm the fix.