1391689 - [MacOS] Left portion of browser window cut off in corner

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue on latest Mac nightly

Seen after updating to Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:57.0) Gecko/20100101 Firefox/57.0, Build 20170818100226

STR:
1. Open the browser
2. Observe the attached screenshot

This issue is not observed on my 10.12 machine running the same build. It is also not an issue using a new profile on the same machine.

Yesterday I was playing around with customizing the toolbar...

Comment 1

[Marcia Knous [:marcia]]

I now see this on my 10.12 machine as well. I tried the "refresh nightly" option and that seemed to fix it.

Comment 2

[Markus Stange [:mstange]]

This is most probably a regression from bug 1390888. I made some changes there that I thought would account for the offset, but apparently it doesn't always work.

Comment 3

[Marcia Knous [:marcia]]

Tracking this issue for Firefox 57, as it makes the browser difficult to minimize or go full screen.

Comment 4

[Markus Stange [:mstange]]

I haven't been able to reproduce this yet.

Comment 6

[ibrokemypie]

(In reply to Tooru Fujisawa [:arai] from comment #1)
> not reproducible on build 20170828100127 with clean profile on macOS
> 10.12.6, on retina display (I think you're also using retina display,
> according to the screenshot)
> does the issue happen on safe mode and/or clean profile?

No, does not seem to happen in safe mode for me.

Comment 7

[Tooru Fujisawa [:arai]]

if the issue doesn't happen on safe mode or clean profile for 2 people,
it would mean that it's most likely conflict with addons.
try disabling all of them and enable one by one to see which one is causing the issue.

Comment 8

[Marcia Knous [:marcia]]

I don't think it is extensions for me, at least on my 10.12 machine. That nightly profile has no extensions installed and is using the default theme. Refreshing the browser option fixed it for me on that machine.

The 10.13 machine I am running on, where I first saw it, has some extensions, but right now they are all disabled. Launching on that machine with a new profile fixes the issue. On that machine I spent some time testing customizing the toolbar, so not sure if that had anything to do with it.

Comment 9

[ibrokemypie]

Same here, disabled all extensions and restarted, no change.

Comment 10

[ibrokemypie]

Disabling gfx.webrender.enabled fixed this for me.

Comment 11

[Markus Stange [:mstange]]

Oh, of course. Thanks for the tip with webrender. The dark red tab bar in Marcia's screenshot should have tipped me off.

Comment 12

[Jim Mathies [:jimm]]

Markus, does gfx have a webrenderer regression meta for bugs like this?

Clearing status, webrenderer won't ship in 57.

Comment 13

[Markus Stange [:mstange]]

(In reply to Jim Mathies [:jimm] from comment #12)
> Markus, does gfx have a webrenderer regression meta for bugs like this?

Not that I'm aware of, no. We have different meta bugs for different "stages" of shipping (bugs blocking bug 1386678), but the more specific ones are all about Windows, so this Mac issue wouldn't really qualify. I'm just going to make it block the generic webrender bug.

Comment 14

[Markus Stange [:mstange]]

Attachment: Bug 1391689 - Pass the correct origin when drawing the titlebar overlay with webrender.

Review commit: https://reviewboard.mozilla.org/r/177300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177300/

Comment 15

[Markus Stange [:mstange]]

Attachment: Bug 1391689 - Simplify titlebar image update logic.

Review commit: https://reviewboard.mozilla.org/r/177302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177302/

Comment 16

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8905487 [details]
Bug 1391689 - Pass the correct origin when drawing the titlebar overlay with webrender.

https://reviewboard.mozilla.org/r/177300/#review182496

Comment 17

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8905488 [details]
Bug 1391689 - Simplify titlebar image update logic.

https://reviewboard.mozilla.org/r/177302/#review182504

Comment 18

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4e1b49ee7a5c -d 1a536787340c: rebasing 418657:4e1b49ee7a5c "Bug 1391689 - Pass the correct origin when drawing the titlebar overlay with webrender. r=mattwoodrow"
merging widget/cocoa/nsChildView.mm
rebasing 418658:b325117b56ce "Bug 1391689 - Simplify titlebar image update logic. r=mattwoodrow" (tip)
merging widget/cocoa/nsChildView.mm
warning: conflicts while merging widget/cocoa/nsChildView.mm! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 19

[Markus Stange [:mstange]]

Comment on attachment 8905487 [details]
Bug 1391689 - Pass the correct origin when drawing the titlebar overlay with webrender.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177300/diff/1-2/

Comment 20

[Markus Stange [:mstange]]

Comment on attachment 8905488 [details]
Bug 1391689 - Simplify titlebar image update logic.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/177302/diff/1-2/

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39dc0da77e09
Pass the correct origin when drawing the titlebar overlay with webrender. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/71652e025914
Simplify titlebar image update logic. r=mattwoodrow

Comment 22

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/39dc0da77e09
https://hg.mozilla.org/mozilla-central/rev/71652e025914