1391328 - Tabs on OSX shouldn't have a top border.

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Johann Hofmann [:johannh]]

Tabs on OSX should go all the way to the top, see http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1391328 - Remove top border from tabs on OSX.

Review commit: https://reviewboard.mozilla.org/r/169786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/169786/

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8898393 [details]
Bug 1391328 - Remove top border from tabs on OSX.

https://reviewboard.mozilla.org/r/169786/#review175034

::: browser/themes/shared/tabs.inc.css:311
(Diff revision 1)
>  .tab-background {
>    border: 1px none transparent;
>    background-clip: padding-box;
>  }
>  
> +%ifndef MOZ_WIDGET_COCOA

Why not XP_MACOSX?

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

BTW, while I'm here, I noticed that the blue indicator isn't quite the same color as in the spec. Also, there's a 1px border at the top of the window (serving as some kind of bevel/sheen) and it lightens the blue indicator where they overlap, causing the indicator to look smaller (in my opinion, too small). I wonder if we can fix this somehow, but I suspect that it's an OS X thing that we don't fully control. Hopefully I'm totally wrong.

Comment 4

[Stephen Horlander [:shorlander]]

Meant to file a bug on the color. Should be blue-50 http://design.firefox.com/photon/visual/color.html#blue

The window inset effect should be gone now: https://bugzilla.mozilla.org/show_bug.cgi?id=1390888

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8898393 [details]
Bug 1391328 - Remove top border from tabs on OSX.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/169786/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

I think this makes most sense.

Comment 7

[Johann Hofmann [:johannh]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)
> BTW, while I'm here, I noticed that the blue indicator isn't quite the same
> color as in the spec.

Let's fix that in a separate bug. :)

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8898393 [details]
Bug 1391328 - Remove top border from tabs on OSX.

https://reviewboard.mozilla.org/r/169786/#review175626

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3c14da19775
Remove top border from tabs on OSX. r=nhnt11

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b3c14da19775

Comment 11

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.10 and Mac OS X 10.12 with Nightly 57.0a1(2017-08-22) and I can confirm this fix.

Comment 12

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=128a79130ecd6f277190d031a623f991c73c5272&newProject=mozilla-central&newRev=db2a49c83d536d38fad916149e43a8fb35121f82