Closed Bug 1391331 Opened 2 years ago Closed 2 years ago

Spacing between Bookmark item Icon and Label should be 4px

Categories

(Firefox :: Theme, defect, P1)

57 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 57
Iteration:
57.2 - Aug 29
Tracking Status
firefox57 --- verified
firefox58 --- verified

People

(Reporter: shorlander, Assigned: shorlander)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-visual])

Attachments

(3 files)

Comment on attachment 8898389 [details] [diff] [review]
bookmark-icon-spacing.patch

Review of attachment 8898389 [details] [diff] [review]:
-----------------------------------------------------------------

Ah, I forgot about this one. Thank you!
Attachment #8898389 - Flags: review?(jhofmann) → review+
Status: NEW → ASSIGNED
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify+
QA Contact: ovidiu.boca
Whiteboard: [photon-visual] → [reserve-photon-visual]
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fa898b4095ea0516113edf55ff60bbf28542b17
Bug 1391331 - Make space between bookmark item icon and label 4px instead of 5px. r=johannh
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fa898b4095e
Make space between bookmark item icon and label 4px instead of 5px. r=johannh
https://hg.mozilla.org/mozilla-central/rev/0fa898b4095e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I verified this on Windows 10 with the latest Nightly 57.0a1(2017-08-18) and I see 6 px not 4. Please see the attachment and also note that on Mac Os X 10.10 I see 4 px as expected.
Flags: needinfo?(shorlander)
There will be some visual difference depending on what the font is and what the end character is. In this case we would have to trust the calculations from the Browser Toolbox or draw a background on the label to use for measuring.

It looks correct to me. On macOS at least.
Flags: needinfo?(shorlander)
Thanks Stephen, you are right on Mac I can confirm that the spacing is 4 px, but I think this 4 px spacing should be applied on all OSes, right? From what I see on Windows this spacing is not the expected one. Please tell me what are the expected results in order to be able to mark this bug as verified or not. Thanks
Blocks: 1391625
No longer depends on: 1391625
Is this bug only for Mac OS? Please tell me the expected result in order to verify this, or the expected result that was described in comment 7 is the right one?  Thanks
Flags: needinfo?(shorlander)
Any news about this issue?
Stephen, can you please help me with this, see comment 7. Thanks
(In reply to ovidiu boca[:Ovidiu] from comment #10)
> Stephen, can you please help me with this, see comment 7. Thanks

According to the inspector the current spacing is 4px and is correct.
Flags: needinfo?(shorlander)
Thanks for your help, I verified this on Mac Os X 10.12 and Windows 10 with FF Nightly 58.0a1(2017-11-02) and I can confirm this fix.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.