1391458 - Crash in mozilla::ipc::MessageChannel::CxxStackFrame::CxxStackFrame | mozilla::ipc::MessageChannel::Send | mozilla::layers::PWebRenderBridgeChild::SendDPBegin

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Andrew McCreight [:mccr8]]

This bug was filed from the Socorro interface and is 
report bp-d4d7b438-403b-4490-a09e-bab600170817.
=============================================================

This looks like a crash in a channel assertion, which means the channel is being used on the wrong thread, or it is uninitialized, or was corrupted somehow.

Comment 1

[Vincent Liu[:vliu]]

Hi kats,

As [1] in bug 1392621 Comment 1 said, there are few similar bugs hit the "not on worker thread" release crash in CxxStackFrame::CxxStackFrame. In current accumulation, SendDPBegin got the 112 crash rate which is the highest till now. To see more info, do you think we should add the below code in [2] to make sure IPC channel is exist before SendDPBegin() is called?


  if (!IPCOpen()) {
    gfxCriticalNote << "IPC Channel is already torn down unexpectedly\n";
    return false;
  }


[2]: https://searchfox.org/mozilla-central/rev/18c16ebf818abb86805ce08a6e537e4cd826f044/gfx/layers/wr/WebRenderBridgeChild.cpp#76

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I think it would be better to put that code at the start of BeginTransaction [1] because then the false return value is actually checked in the paint code. The DPBegin return value doesn't propagate all the way out of the LayerManager, both WebRenderLayerManager::EndTransaction and WebRenderLayerManager::EndTransactionWithoutLayer ignore that return value.

[1] https://searchfox.org/mozilla-central/rev/18c16ebf818abb86805ce08a6e537e4cd826f044/gfx/layers/wr/WebRenderLayerManager.cpp#160

Comment 3

[Vincent Liu[:vliu]]

Attachment: 0001-Bug-1391458-Make-sure-WrBridge-is-ready-in-the-head-.patch

Hi kats,

As your suggestion in Comment 2, the patch was attached. Could you please have a review? Thanks.

Comment 4

[Vincent Liu[:vliu]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4d3934d5b1eba2edd0ebf794afca98716510edb

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/378e69fe5a92
Make sure WrBridge is ready in the head of BeginTransaction. r=kats

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/378e69fe5a92