1391464 - Regression caused by bug 1354336: Can’t use the `.panel-section-tabs-button.selected` class

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P5)

Description

[ExE Boss]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170814072924

Steps to reproduce:

Created an options page with a `<div>` with the `.panel-section-tabs-button.selected` class.


Actual results:

The `<div>` looks like a `<div>` with only the `.panel-section-tabs-button` class.


Expected results:

The `<div>` should look like a `<div>` with the `.panel-section-tabs-button.selected` class.


Additional information:

The reason why this happened has been explained in bug 1354336 comment 43.

Documentation on the `.panel-section-tabs-button.selected` class is available at:
http://design.firefox.com/StyleGuide/#/navigation

Comment 1

[ExE Boss]

:ntim is fixing this as part of bug 1421652, so I’m setting it as a dependency on this (is that how this should be done?).

Comment 2

[ExE Boss]

In the end, I fixed this as part of bug 1371951:
https://hg.mozilla.org/mozilla-central/rev/e57c44d5ec97

Comment 3

[Victor Carciu]

Is manual QA needed on this bug? If yes, please provide a test webextension and some STRs, else add the "qe-verify-" flag.

Comment 4

[ExE Boss]

(In reply to Victor Carciu from comment #3)
> Is manual QA needed on this bug? If yes, please provide a test webextension
> and some STRs, else add the "qe-verify-" flag.

I don’t think it is, as I just reverted an incorrect change to two CSS selectors from bug 1354336.