1391576 - Stop doing main-thread I/O in FileUtils.getFile for the most common case

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[:Paolo Amadini]

There are a few cases where this method is still used with unnecessary I/O:

http://searchfox.org/mozilla-central/search?q=FileUtils.getFile&path=

Bug 920187 is on file to migrate the callers, but for the moment we can get an easy win by optimizing the function. Looking at the production code above, there shouldn't be cases where the directory doesn't exist if we're not asking for a subdirectory.

I've looked at the callers of FileUtils.getDir also, but they seem to be generally well-behaved:

http://searchfox.org/mozilla-central/search?q=FileUtils.getDir&path=

I'll start a tryserver build to see if any of the test code relies on the creation of the base directory.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1391576 - Stop doing main-thread I/O in FileUtils.getFile for the most common case.

Review commit: https://reviewboard.mozilla.org/r/170122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170122/

Comment 2

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=31446fb3477e6fa1ceabca23e2c671eccb165034

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8898716 [details]
Bug 1391576 - Stop doing main-thread I/O in FileUtils.getFile for the most common case.

https://reviewboard.mozilla.org/r/170122/#review175396

r=me if tests still pass.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5f62e5b5655
Stop doing main-thread I/O in FileUtils.getFile for the most common case. r=kmag

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c5f62e5b5655