920187 - Deprecate and get rid of FileUtils.getFile()

Status: RESOLVED FIXED

(Toolkit Graveyard :: IOUtils and PathUtils, task)

Description

[David Teller [:Yoric] - still alive but not very active]

FileUtils.getFile() calls FileUtils.getDir(..., ..., true), which performs main thread I/O. We should root out calls to this method, mark it deprecated, and at some unspecified point in the future, get rid of it.

Comment 1

[Beth Rennie [:beth] (she/her)]

Reinserting into the qf triage queue since this is not under a performance pillar.

Comment 2

[Andrew Creskey [:acreskey]]

I don't see any references to ``FileUtils.getFile()` in the code base.
Are we sure this is still relevant?

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

There's still a few FileUtils.getFile() calls: https://searchfox.org/mozilla-central/search?q=FileUtils.getFile&path=

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

We'll call this qf:p3:responsiveness. It would be good to get profiles which demonstrate whether how much impact these IO's have, as they're in the parent process.

Comment 5

[David Teller [:Yoric] - still alive but not very active]

For what it's worth, the duration of a blocking file I/O is not bounded. I have had Telemetry of cases (not of this specific I/O) that last several seconds doing trivial I/O (e.g. opening a file or closing it), with Firefox entirely blocked by the I/O.

Comment 6

[Beth Rennie [:beth] (she/her)]

IOUtils and PathUtils offers async alternatives

Comment 7

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 920187 - Remove FileUtils.getFile r?gijs

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e88377109e68
Remove FileUtils.getFile r=Gijs

Comment 9

[Serban Stanca [:SerbanS]]

Backed out for as requested by dev for potential test failures.

• Backout link

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79cbe2c22d0a
Remove FileUtils.getFile r=Gijs

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/79cbe2c22d0a