1391613 - Update style for hover and keyboard selection in URL bar to be same as hamburger menu

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement, P1)

Description

[afnankhan]

Attachment: Hamburger menu

Comment 1

[Dão Gottwald [:dao]]

I'm not sure we want the exact same style here, but we should probably remove the border from the hover state.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander

Review commit: https://reviewboard.mozilla.org/r/171936/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171936/

Comment 3

[Drew Willcoxon :adw]

Where'd this bug come from?  I haven't heard anything about changing the urlbar popup styling, or removing the border on its items, and there doesn't seem to be any mention of the popup in the Invision spec.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Drew Willcoxon :adw from comment #3)
> Where'd this bug come from?

From a user observing an inconsistency. This used to more or less match the hover feedback in Australis panels. Now that we're changing these, it makes sense to update this too.

Comment 5

[Drew Willcoxon :adw]

I don't think that follows, but could you please check with Stephen first?

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 8900539 [details]
Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander

https://reviewboard.mozilla.org/r/171936/#review177674

::: browser/themes/shared/urlbar-autocomplete.inc.css:12
(Diff revision 1)
>  #treecolAutoCompleteImage {
>    max-width: 36px;
>  }
>  
>  .autocomplete-richlistbox {
> -  padding: 4px;
> +  padding: 4px 3px;

Why this change?

Comment 7

[Drew Willcoxon :adw]

I didn't mean to leave comment 6 when I cleared the review, so please ignore it for now.

Comment 8

[Dão Gottwald [:dao]]

(In reply to Drew Willcoxon :adw from comment #5)
> I don't think that follows,

What doesn't follow?

> but could you please check with Stephen first?

The patch is already waiting for Stephen's ui-review.

Comment 9

[Drew Willcoxon :adw]

(In reply to Dão Gottwald [::dao] from comment #4)
> This used to more or less match the hover feedback in Australis panels.
> Now that we're changing these, it makes sense to update this too.

I don't think it follows that because we're changing hover feedback in panels that it makes sense to update hover feedback in the urlbar popup.  The urlbar popup is one of the most important pieces of UI.  Surely if UX had intended it to be updated, they would have included it in the Invision spec, and by now I would know about it.

But I could be wrong.  Please re-request review once Stephen says that the urlbar popup should be changed in this way.

Comment 10

[Dão Gottwald [:dao]]

I don't think it's useful to muse about why there's no mockup for this and whether or not somebody had this on their radar. Let's evaluate this change on its own merits, which would be consistency across the UI.

Comment 11

[Stephen Horlander [:shorlander]]

Comment on attachment 8900539 [details]
Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander

We overlooked the awesome bar results in the initial Photon spec. Aligning the various states with the other Photon styles is the right thing to do. The try-builds looked good to me. Thank you!

Comment 12

[Drew Willcoxon :adw]

Comment on attachment 8900539 [details]
Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander

https://reviewboard.mozilla.org/r/171936/#review179306

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/781da96f5a62
Remove border from URL bar and search bar autocomplete items. ui-r=shorlander r=adw

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/781da96f5a62