Closed
Bug 1391613
Opened 7 years ago
Closed 7 years ago
Update style for hover and keyboard selection in URL bar to be same as hamburger menu
Categories
(Firefox :: Theme, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: afnankhan, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(2 files)
6.10 KB,
image/png
|
Details | |
59 bytes,
text/x-review-board-request
|
adw
:
review+
shorlander
:
ui-review+
|
Details |
No description provided.
Updated•7 years ago
|
Whiteboard: [photon-visual][triage]
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 1•7 years ago
|
||
I'm not sure we want the exact same style here, but we should probably remove the border from the hover state.
Assignee: nobody → dao+bmo
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: P4 → P1
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8900539 -
Flags: ui-review?(shorlander)
Updated•7 years ago
|
Iteration: --- → 57.2 - Aug 29
Flags: qe-verify?
Assignee | ||
Updated•7 years ago
|
Flags: qe-verify? → qe-verify-
Comment 3•7 years ago
|
||
Where'd this bug come from? I haven't heard anything about changing the urlbar popup styling, or removing the border on its items, and there doesn't seem to be any mention of the popup in the Invision spec.
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #3) > Where'd this bug come from? From a user observing an inconsistency. This used to more or less match the hover feedback in Australis panels. Now that we're changing these, it makes sense to update this too.
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8900539 [details] Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander https://reviewboard.mozilla.org/r/171936/#review177674 ::: browser/themes/shared/urlbar-autocomplete.inc.css:12 (Diff revision 1) > #treecolAutoCompleteImage { > max-width: 36px; > } > > .autocomplete-richlistbox { > - padding: 4px; > + padding: 4px 3px; Why this change?
Attachment #8900539 -
Flags: review?(adw)
Comment 7•7 years ago
|
||
I didn't mean to leave comment 6 when I cleared the review, so please ignore it for now.
Assignee | ||
Comment 8•7 years ago
|
||
(In reply to Drew Willcoxon :adw from comment #5) > I don't think that follows, What doesn't follow? > but could you please check with Stephen first? The patch is already waiting for Stephen's ui-review.
Comment 9•7 years ago
|
||
(In reply to Dão Gottwald [::dao] from comment #4) > This used to more or less match the hover feedback in Australis panels. > Now that we're changing these, it makes sense to update this too. I don't think it follows that because we're changing hover feedback in panels that it makes sense to update hover feedback in the urlbar popup. The urlbar popup is one of the most important pieces of UI. Surely if UX had intended it to be updated, they would have included it in the Invision spec, and by now I would know about it. But I could be wrong. Please re-request review once Stephen says that the urlbar popup should be changed in this way.
Assignee | ||
Comment 10•7 years ago
|
||
I don't think it's useful to muse about why there's no mockup for this and whether or not somebody had this on their radar. Let's evaluate this change on its own merits, which would be consistency across the UI.
Comment 11•7 years ago
|
||
Comment on attachment 8900539 [details] Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander We overlooked the awesome bar results in the initial Photon spec. Aligning the various states with the other Photon styles is the right thing to do. The try-builds looked good to me. Thank you!
Attachment #8900539 -
Flags: ui-review?(shorlander) → ui-review+
Updated•7 years ago
|
Iteration: 57.2 - Aug 29 → 57.3 - Sep 19
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8900539 [details] Bug 1391613 - Remove border from URL bar and search bar autocomplete items. ui-r=shorlander https://reviewboard.mozilla.org/r/171936/#review179306
Attachment #8900539 -
Flags: review+
Comment 13•7 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/781da96f5a62 Remove border from URL bar and search bar autocomplete items. ui-r=shorlander r=adw
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/781da96f5a62
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in
before you can comment on or make changes to this bug.
Description
•