1392582 - Change the hover background url text color in awesomebar when using gnome3 dark theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #1386934 +++

When using Firefox in Gnome 3 with dark theme the hover background url color is hardly visible on black background.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: hover.png

See the black row in the middle which comes from mouse hover. It's difficult to notice it.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

The code which affects it is here but I'm not sure how to fix that properly:

diff --git a/browser/themes/linux/browser.css b/browser/themes/linux/browser.css
--- a/browser/themes/linux/browser.css
+++ b/browser/themes/linux/browser.css

 .autocomplete-richlistitem:hover,
 treechildren.searchbar-treebody::-moz-tree-row(hover) {
   background-color: hsla(0, 0%, 0%, 0.06); <<< wrong color when background is dark
   border-color: hsla(0, 0%, 0%, 0.1);
 }

Comment 3

[:Gijs (he/him)]

Seems to be there since bug 1295458. Looks like this CSS exists on every platform, and should maybe use system colours on Linux, or something, or maybe opacity?

Comment 4

[Dão Gottwald [:dao]]

(In reply to Martin Stránský from comment #2)
> The code which affects it is here but I'm not sure how to fix that properly:
> 
> diff --git a/browser/themes/linux/browser.css
> b/browser/themes/linux/browser.css
> --- a/browser/themes/linux/browser.css
> +++ b/browser/themes/linux/browser.css
> 
>  .autocomplete-richlistitem:hover,
>  treechildren.searchbar-treebody::-moz-tree-row(hover) {
>    background-color: hsla(0, 0%, 0%, 0.06); <<< wrong color when background
> is dark
>    border-color: hsla(0, 0%, 0%, 0.1);
>  }

We should use var(--arrowpanel-dimmed) as the background-color and var(--panel-separator-color) as the border-color.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1392582 - Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor,

Review commit: https://reviewboard.mozilla.org/r/171586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171586/

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Thanks, there's the patch attached. Works for me with light and dark themes.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8900221 [details]
Bug 1392582 - Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor,

https://reviewboard.mozilla.org/r/171586/#review176730

Could you please update the windows/ and osx/ stylesheets for consistency? Thanks!

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8900221 [details]
Bug 1392582 - Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171586/diff/1-2/

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 8900221 [details]
Bug 1392582 - Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor,

https://reviewboard.mozilla.org/r/171586/#review176832

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65efdf7b6bad
Use arrowpanel-dimmed/panel-separator-color colors for awesome bar cursor,r=dao

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/65efdf7b6bad