1392064 - <pre wrap=""> added to HTML replies of non-flowed plaintext messages inhibits downgrade

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1385636 +++

From 1385636 comment #22:

When you HTML-quote a plaintext message you get:

      <blockquote type="cite">
        <pre wrap="">Hallo,

And the fix [from bug 1385636] inhibits the downgrade to plaintext. So you answer plaintext adding plaintext and the sent result is HTML. Not good. I can't see right now who adds this, but I think we should add this as moz-* class.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: Sample e-mail

Just import that message and do a HTML reply. Then send. Result: Not downgraded.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1392064-pre-with-class.patch (v1).

Adding a moz-* class to the pre let's us skip it when downgrading. Repeat the steps from comment #1 and it's downgraded again.

Comment 3

[Jorg K (CEST = GMT+2)]

Problem only happens when replying to non-flowed messages, like the example attached here. Flowed messages don't use the <pre>. That why the fix is in mimetpla.cpp (MIME Text Plain), not mimetpfl.cpp (MIME Test Plain Flowed).

Comment 4

[:aceman]

Somehow I can't reproduce this. What kind of recipient do I need? I tried one that prefers plain text and the reply was automatically downgraded. I do see the <pre wrap=""> in the HTML composition before sending.

Comment 5

[Jorg K (CEST = GMT+2)]

"Unknown" recipient, auto-downgrade. Doesn't downgrade the pre.

Comment 6

[:aceman]

So with the patch on that "unknown preference" the downgrading dialog says the message can be converted without loosing information. Previously the dialog said that some formatting may be lost. Is that what I should see?

Comment 7

[Jorg K (CEST = GMT+2)]

Yes.

In Bug 1385636 <pre> was reclassified from nsIMsgCompConvertible::Plain to nsIMsgCompConvertible::Altering, so it might trigger that dialogue. Adding a class moz-* will lead to ignoring the <pre>, thus no dialogue should be triggered.

I don't have the option "Ask me what to do", so it just silently sends as HTML, which is undesired.

Comment 8

[:aceman]

Comment on attachment 8899238 [details] [diff] [review]
1392064-pre-with-class.patch (v1).

Review of attachment 8899238 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, in that case it seems to work.

Some time in the future we could look at that 'wrap' attribute which is ignored according to
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/pre

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dcfbdc934514
Insert <pre> tags in quotes with class=moz-quote-pre to not inhibit auto-downgrade. r=aceman