1392221 - FeedWriter declares that it implements nsINavHistoryObserver when it doesn't need to (and doesn't implement it)

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, enhancement)

Description

[Mark Banner (:standard8)]

Whilst looking at another bug, I realised that FeedWriter is declaring that it implements Ci.nsINavHistoryObserver, but it doesn't need to, nor does it implement it.

Bug 621274 stopped FeedWriter being an observer of Places history, and removed the implementation of that observer, but didn't remove the declaration line.

We can simply remove the line from the QueryInterface definition.

Assigning to Dan as I'm sure he can do a patch for this.

Comment 1

[Dan Banner]

Attachment: Bug 1392221 - FeedWriter doesn't implement nsINavHistoryObserver nor does it need to - so remove it from the QI definition.

Review commit: https://reviewboard.mozilla.org/r/170768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170768/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8899494 [details]
Bug 1392221 - FeedWriter doesn't implement nsINavHistoryObserver nor does it need to - so remove it from the QI definition.

https://reviewboard.mozilla.org/r/170768/#review175966

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74907b791b12
FeedWriter doesn't implement nsINavHistoryObserver nor does it need to - so remove it from the QI definition. r=standard8

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/74907b791b12