1392230 - about:telemetry - Small design fixes

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[flyingrub]

https://public.etherpad-mozilla.org/p/about_telemetry_feedback make a list of small css changes that doesn't need a bug for each ones.

Comment 1

[flyingrub]

Attachment: Bug 1392230 - Small design fixes in about:telemetry

Fix font size according to photon specs.

Review commit: https://reviewboard.mozilla.org/r/170718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170718/

Comment 2

[Chris H-C :chutten]

Comment on attachment 8899433 [details]
Bug 1392230 - Small design fixes in about:telemetry

https://reviewboard.mozilla.org/r/170718/#review175868

Seems good. If you are going to put "checkin-needed" on the bug to have this merged, remember to use "leave-open" as well so the bug isn't automatically resolved on merge. This will allow you to work on further improvements within the same bug.

Or just wait until all the improvements are up and r+ before marking "checkin-needed". Your choice.

Comment 3

[flyingrub]

Attachment: Bug 1392230 - Fix placeholder text in about:telemetry

Review commit: https://reviewboard.mozilla.org/r/170760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170760/

Comment 4

[flyingrub]

I prefer to wait and merge all the patch at once.

Comment 5

[Chris H-C :chutten]

Comment on attachment 8899482 [details]
Bug 1392230 - Fix placeholder text in about:telemetry

https://reviewboard.mozilla.org/r/170760/#review176044

Seems about right

Comment 6

[flyingrub]

Attachment: Bug 1392230 - Fix sql statements in about:telemetry

Display only one line at the bottom of table.

Review commit: https://reviewboard.mozilla.org/r/171112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171112/

Comment 7

[Chris H-C :chutten]

Comment on attachment 8899777 [details]
Bug 1392230 - Fix sql statements  in about:telemetry

https://reviewboard.mozilla.org/r/171112/#review176258

Simple and straightforward.

Comment 8

[flyingrub]

Comment on attachment 8899433 [details]
Bug 1392230 - Small design fixes in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170718/diff/1-2/

Comment 9

[flyingrub]

Comment on attachment 8899777 [details]
Bug 1392230 - Fix sql statements  in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171112/diff/1-2/

Comment 10

[flyingrub]

Comment on attachment 8899482 [details]
Bug 1392230 - Fix placeholder text in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170760/diff/1-2/

Comment 11

[flyingrub]

Attachment: Bug 1392230 - Fix sidebar height in about:telemetry

Review commit: https://reviewboard.mozilla.org/r/172130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172130/

Comment 12

[flyingrub]

Comment on attachment 8900689 [details]
Bug 1392230 - Fix sidebar height in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172130/diff/1-2/

Comment 13

[flyingrub]

Attachment: Bug 1392230 - Prevent table overflow in about:telemetry

Review commit: https://reviewboard.mozilla.org/r/172200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172200/

Comment 14

[Chris H-C :chutten]

Comment on attachment 8900689 [details]
Bug 1392230 - Fix sidebar height in about:telemetry

https://reviewboard.mozilla.org/r/172130/#review177466

::: commit-message-a4708:1
(Diff revision 2)
> +Bug 1392230 - Fix sidebar width in about:telemetry r?chutten

This is fixing the height, no?

Comment 15

[Chris H-C :chutten]

Comment on attachment 8900740 [details]
Bug 1392230 - Prevent table overflow in about:telemetry

https://reviewboard.mozilla.org/r/172200/#review177468

Comment 16

[Chris H-C :chutten]

Comment on attachment 8900689 [details]
Bug 1392230 - Fix sidebar height in about:telemetry

https://reviewboard.mozilla.org/r/172130/#review177630

r+ when you fix the commit message

Comment 17

[flyingrub]

Comment on attachment 8899433 [details]
Bug 1392230 - Small design fixes in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170718/diff/2-3/

Comment 18

[flyingrub]

Comment on attachment 8899777 [details]
Bug 1392230 - Fix sql statements  in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171112/diff/2-3/

Comment 19

[flyingrub]

Comment on attachment 8899482 [details]
Bug 1392230 - Fix placeholder text in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170760/diff/2-3/

Comment 20

[flyingrub]

Comment on attachment 8900689 [details]
Bug 1392230 - Fix sidebar height in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172130/diff/2-3/

Comment 21

[flyingrub]

Comment on attachment 8900740 [details]
Bug 1392230 - Prevent table overflow in about:telemetry

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172200/diff/1-2/

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Still has unresolved issues in MozReview.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd47c1e3d27e
Small design fixes in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/dce2841b8153
Fix sql statements  in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/2906056b9833
Fix placeholder text in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/31785307b29f
Fix sidebar height in about:telemetry r=chutten
https://hg.mozilla.org/integration/autoland/rev/827da4c1d0ad
Prevent table overflow in about:telemetry r=chutten

Comment 24

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/dd47c1e3d27e
https://hg.mozilla.org/mozilla-central/rev/dce2841b8153
https://hg.mozilla.org/mozilla-central/rev/2906056b9833
https://hg.mozilla.org/mozilla-central/rev/31785307b29f
https://hg.mozilla.org/mozilla-central/rev/827da4c1d0ad