1392255 - [FTL] Enable source view support

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, enhancement, P2)

Description

[Matjaz Horvat [:mathjazz]]

We need to enable source view for FTL strings, in order to bring support to all FTL messages, including the ones we don't have a dedicated UI for.

We should also allow users to switch between source view and the rich UI when this is possible.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/749

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/1159b6f2de9057960e9083dcbe600f45a98cf4c3
Fix bug 1392255: Enable source view for FTL messages (#749)

Restore FTL button and enable switching between source and FTL editor:
- Fallback to source view for translations not supported in FTL editor.
- Same for source strings.
- Switching reflects changes in either editor.
- Prevent switching to rich editor if message not supported.
- Show translation length and Copy from source only for simple FTL
  strings and only in FTL editor.
- For untranslated strings not supported in rich editor, show source
  view if source string displayed as source.
- Autofill source view for untranslated strings with `key =`.

Always use #translation textarea for source editor and #ftl-area for FTL
editor (even for simple strings). Similarly, even simple source strings
are displayed in #ftl-original. To make that possible, we keep entity
and translation objects unchanged for non-complex FTL strings.

Other improvements:
- Refactor code style of fluent_interface.js.
- Bugfix: Update editor when FTL message unrejected.
- Join renderEditorWithTranslation() and renderEditor() functions.
- Focus first element, regardless if <input> or <textarea>.
- Properly calculate translation length of FTL messages.
- Properly warn about unsaved changes for FTL messages.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/874cb0198775661b3194e3cca1330ddce164d3a9
Revert "Fix bug 1392255: Enable source view for FTL messages (#749)"

This reverts commit 1159b6f2de9057960e9083dcbe600f45a98cf4c3.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/a28a423c700a2bce9fea4d9fcd8eb597f406f784
Revert "Revert "Fix bug 1392255: Enable source view for FTL messages (#749)""

This reverts commit 874cb0198775661b3194e3cca1330ddce164d3a9.

https://github.com/mozilla/pontoon/commit/0d5ccc1d10b1435a550e27cb410973b764e47521
Bug 1392255: Address bugs found during testing

- Strip trailing newlines for easier translated status detection. This
  fixes the bug that prevented switching back to the rich FTL editor
  after switching to source view for untranslated pluralized source
  strings.

- Prevent unsaved changes warning to show up when saving virtually any
  FTL translation.

- Treat strings containing only text and references to external
  arguments and other messages as simple strings.

- Extend copy from helpers support for FTL strings:
  * Allow copy from history and other locales in source editor
  * Allow copy from other locales in rich FTL editor

- Allow switching to rich FTL if source editor empty.

- Add ability to display custom plural forms. Previously, FTL editor
  only supported pluralized translations that used variants for one of
  the CLDR plural forms available for the locale. FTL also allows adding
  custom variants, usually numbers, usually 0. Because "No strings"
  sounds better than "0 Strings".

- In FTL source editor, use default tab behaviour.