1392262 - [update verification] verify.sh: Print out what locale failed

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect, P2)

Description

[Johan Lorenzo [:jlorenzo]]

While investigating bug 1389466, I stumbled upon an easy modification that will help debugging update verification tests (like bug 1388431). This won't be as efficient as splitting update verification per locale (bug 1389478), but that will concatenate the failed locales at the end of the log file.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1392262 - [update verification] verify.sh: Print out what locale failed

Review commit: https://reviewboard.mozilla.org/r/170738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170738/

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8899456 [details]
Bug 1392262 - [update verification] verify.sh: Print out what locale failed

https://reviewboard.mozilla.org/r/170738/#review176610

Good idea, but shall we go a step further and use [$release $locale $patch_type] to cover other types of bustages ?

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8899456 [details]
Bug 1392262 - [update verification] verify.sh: Print out what locale failed

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170738/diff/1-2/

Comment 4

[Johan Lorenzo [:jlorenzo]]

Good point! I initially though $release wasn't worth it because the value is already present in $source_file. However, not every error message has $source_file in it. Thus, I fully implemented your suggestion.

Landed on default at: https://hg.mozilla.org/build/tools/rev/366a7b278252cf7497e34fd79e3294da610b2db5