Closed
Bug 1392272
Opened 7 years ago
Closed 2 years ago
[Win] Optimize the way we resolve proxy settings
Categories
(Core :: Networking: HTTP, enhancement, P3)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox96 | --- | fixed |
People
(Reporter: mayhemer, Assigned: kershaw)
References
Details
(Keywords: perf, Whiteboard: [necko-next][proxy])
Attachments
(2 files)
With the default prefs we do async proxy resolution for every channel. Most users these days have Windows set to "no proxy" in the Windows internet settings. We should detect changes by observing for either registry changes or doing some other magic and bypass proxy resolution completely when no proxy has been specified. I can see 20+ ms (on a fast machine, in an opt build!) on EVERY channel. This also includes main thread dispatch. Not sure we could have this for 57, but would definitely be nice. Loosely blocking CDP. https://stackoverflow.com/questions/6192563/detect-windows-ie-proxy-settings-changes
![]() |
Reporter | |
Comment 1•7 years ago
|
||
One simple solution (some probability of regression prove..) could be to refresh the registry settings only when loading a top level document and not for sub-resources.
Updated•7 years ago
|
Whiteboard: [necko-next] → [necko-next][proxy]
Comment 2•7 years ago
|
||
Assign to myself, but maybe fix later, so keep necko-next.
Assignee: nobody → xeonchen
Comment 3•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P3 → P2
Updated•7 years ago
|
Assignee: xeonchen → nobody
Updated•5 years ago
|
Priority: P2 → P3
Assignee | ||
Comment 4•3 years ago
|
||
Updated•3 years ago
|
Assignee: nobody → kershaw
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•3 years ago
|
||
Add leave-open
, since linux and android parts are not completed.
Keywords: leave-open
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1c1c60a1f6ef P1: [windows] Monitor system proxy changes, r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/931db25d14fd P2: [osx] Monitor system proxy changes, r=necko-reviewers,dragana
Comment 9•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1c1c60a1f6ef
https://hg.mozilla.org/mozilla-central/rev/931db25d14fd
Updated•3 years ago
|
status-firefox57:
affected → ---
status-firefox96:
--- → fixed
Updated•3 years ago
|
Severity: -- → N/A
Comment 10•2 years ago
|
||
I think it would be better to close this bug since patches landed in Firefox 96 and open new bugs for Linux and Android.
Flags: needinfo?(kershaw)
Assignee | ||
Comment 11•2 years ago
|
||
(In reply to Mathew Hodson from comment #10)
I think it would be better to close this bug since patches landed in Firefox 96 and open new bugs for Linux and Android.
Note that the patches in this bug was reverted because of bug 1749501.
I'll file a new bug to track the necessary work.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(kershaw)
Keywords: leave-open
Resolution: --- → FIXED
Comment 12•1 month ago
|
||
(In reply to Kershaw Chang [:kershaw] from comment #11)
I'll file a new bug to track the necessary work.
Bug 1907364 might be that new bug.
You need to log in
before you can comment on or make changes to this bug.
Description
•