Closed Bug 1392272 Opened 7 years ago Closed 2 years ago

[Win] Optimize the way we resolve proxy settings

Categories

(Core :: Networking: HTTP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox96 --- fixed

People

(Reporter: mayhemer, Assigned: kershaw)

References

Details

(Keywords: perf, Whiteboard: [necko-next][proxy])

Attachments

(2 files)

With the default prefs we do async proxy resolution for every channel.  Most users these days have Windows set to "no proxy" in the Windows internet settings.  We should detect changes by observing for either registry changes or doing some other magic and bypass proxy resolution completely when no proxy has been specified.

I can see 20+ ms (on a fast machine, in an opt build!) on EVERY channel.  This also includes main thread dispatch.

Not sure we could have this for 57, but would definitely be nice.

Loosely blocking CDP.

https://stackoverflow.com/questions/6192563/detect-windows-ie-proxy-settings-changes
One simple solution (some probability of regression prove..) could be to refresh the registry settings only when loading a top level document and not for sub-resources.
Keywords: perf
Whiteboard: [necko-next]
Whiteboard: [necko-next] → [necko-next][proxy]
Assign to myself, but maybe fix later, so keep necko-next.
Assignee: nobody → xeonchen
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P3 → P2
Assignee: xeonchen → nobody
Priority: P2 → P3
Assignee: nobody → kershaw
Status: NEW → ASSIGNED

Add leave-open, since linux and android parts are not completed.

Keywords: leave-open
Pushed by kjang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c1c60a1f6ef
P1: [windows] Monitor system proxy changes, r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/931db25d14fd
P2: [osx] Monitor system proxy changes, r=necko-reviewers,dragana
Regressions: 1749501
No longer blocks: 1652083
Severity: normal → --
Severity: -- → N/A

I think it would be better to close this bug since patches landed in Firefox 96 and open new bugs for Linux and Android.

Flags: needinfo?(kershaw)

(In reply to Mathew Hodson from comment #10)

I think it would be better to close this bug since patches landed in Firefox 96 and open new bugs for Linux and Android.

Note that the patches in this bug was reverted because of bug 1749501.
I'll file a new bug to track the necessary work.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(kershaw)
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: