[Win] Optimize the way we resolve proxy settings

NEW
Unassigned

Status

()

Core
Networking: HTTP
P2
normal
11 months ago
6 months ago

People

(Reporter: mayhemer, Unassigned)

Tracking

(Blocks: 1 bug, {perf})

Trunk
Points:
---

Firefox Tracking Flags

(firefox57 affected)

Details

(Whiteboard: [necko-next][proxy])

(Reporter)

Description

11 months ago
With the default prefs we do async proxy resolution for every channel.  Most users these days have Windows set to "no proxy" in the Windows internet settings.  We should detect changes by observing for either registry changes or doing some other magic and bypass proxy resolution completely when no proxy has been specified.

I can see 20+ ms (on a fast machine, in an opt build!) on EVERY channel.  This also includes main thread dispatch.

Not sure we could have this for 57, but would definitely be nice.

Loosely blocking CDP.

https://stackoverflow.com/questions/6192563/detect-windows-ie-proxy-settings-changes
(Reporter)

Comment 1

11 months ago
One simple solution (some probability of regression prove..) could be to refresh the registry settings only when loading a top level document and not for sub-resources.
(Reporter)

Updated

11 months ago
Keywords: perf
Whiteboard: [necko-next]
Whiteboard: [necko-next] → [necko-next][proxy]
Assign to myself, but maybe fix later, so keep necko-next.
Assignee: nobody → xeonchen
Assignee: xeonchen → nobody
You need to log in before you can comment on or make changes to this bug.