1749501 - "Use system proxy settings" no longer uses all defined exceptions

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Tynth]

Steps to reproduce:

In Firefox the proxy setting "Use system proxy settings" is used.
In Windows Internet Options the proxy is set and several proxy exceptions are defined with semikolons. Its always only the first exception in the list working.
Going back to Version 95.0.2 - all exceptions are working again.

Actual results:

Firefox only uses first proxy exception entry before the first semikolon. all other exceptions dont work.

Expected results:

firefox should use all exceptions in the list, like it was with previous versions.

Comment 1

[Dragana Damjanovic [:dragana]]

Kershaw, can this be related to your recent work on the proxy detection?

Comment 2

[Kershaw Chang [:kershaw]]

(In reply to Dragana Damjanovic [:dragana] from comment #1)

Kershaw, can this be related to your recent work on the proxy detection?

No, that feature is not enabled yet.

Hi Reporter,

Could you help us track down the issue by using mozregression?
Thanks.

Comment 3

[Karsten Gorn]

I can confirm this error also in another scenario
With Firefox Version up to 95.0.2
a proxy exception of the type ".mydomain.local" did catch both "myhost.mydomain.local" and also "myhost" (searchdomain in DNS is set to mydomain.local)
after the update I have to include myhost in the proxy exception list.

Comment 4

[philipprudolph1990]

I can confirm this error on multiple system in our company network since Version 96.

Mozregression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5823cb0f699866c8672cce50cf8e1cbceadc43aa&tochange=2635e89a17901559baea7ba0e50adea0cbad8e42

Comment 5

[Kershaw Chang [:kershaw]]

(In reply to philipprudolph1990 from comment #4)

I can confirm this error on multiple system in our company network since Version 96.

Mozregression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5823cb0f699866c8672cce50cf8e1cbceadc43aa&tochange=2635e89a17901559baea7ba0e50adea0cbad8e42

Thanks. This bug seems to be regressed by bug 1392272.
I'll try to fix this asap.

Comment 6

[Kershaw Chang [:kershaw]]

Attachment: Bug 1749501 - Revert bug 1392272, r=#necko

Comment 8

[Tynth]

Good to see that there is already another bug with the same issue reported. hopefully we get a fix asap with 69.0.1 in the coming days since this is really critical on company environments.

Comment 9

[Gregg Nicholas]

As a workaround, I used group policy to set manual proxy settings for Mozilla Firefox (not use system proxy settings).
I wonder if this problem was caused by the different syntax used for proxy exceptions in Windows control panel vs. Firefox.
For instance, Windows accepts exceptions like: "10.;172.16.". Doesn't Firefox prefer those to be entered as: "10.0.0.0/8, 172.16.0.0/16"

Comment 10

[dsikioa]

Had to add exclusions on browser settings as well, then it works even when "Use system proxy settings" is in use. So seems to be a bug that Firefox looks exceptions only? from browser settings and other settings from system level.

Comment 11

[Dragana Damjanovic [:dragana]]

(In reply to Kershaw Chang [:kershaw] from comment #5)

(In reply to philipprudolph1990 from comment #4)

I can confirm this error on multiple system in our company network since Version 96.

Mozregression: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5823cb0f699866c8672cce50cf8e1cbceadc43aa&tochange=2635e89a17901559baea7ba0e50adea0cbad8e42

Thanks. This bug seems to be regressed by bug 1392272.
I'll try to fix this asap.

I had this bug in mind in comment 1.

Comment 12

[Kershaw Chang [:kershaw]]

Comment on attachment 9258665 [details]
Bug 1749501 - Revert bug 1392272, r=#necko

Beta/Release Uplift Approval Request

• User impact if declined: The exception list for proxy resolution is broken.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No risk. This patch only reverts the code back.
• String changes made/needed: N/A

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9487d469939e
Revert bug 1392272, r=necko-reviewers,dragana

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9487d469939e

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1392272

Comment 20

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9258665 [details]
Bug 1749501 - Revert bug 1392272, r=#necko

Approved for 97.0b3.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b1c82d2252c7

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Escalating this to blocker level. We're leaving updates throttled until we have a fixed release ready to ship.

Comment 23

[Dianna Smith [:diannaS]]

Comment on attachment 9258665 [details]
Bug 1749501 - Revert bug 1392272, r=#necko

Approved for 96.0.1

Comment 24

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/2efe8c82c6c4

Comment 25

[Tynth]

Tested with 96.0.1 and its fixed as far as i can tell. Thanks for the fast fix!

Comment 26

[Emil Ghitta, QA [:emilghitta]]

I've managed to reproduce this issue using Firefox 98.0a1 (BuildId:20220111213255).

This issue is verified fixed using Firefox 96.0.1 (BuildId:20220113185450), 97.0b3 (BuildId:20220113185849) and 98.0a1 (BuildId:20220114093102) on Windows 10 64bit, macOS 10.14 and Ubuntu 18.04 64bit.

All items from the proxy exclusion list are treated as expected.