Closed Bug 1392884 Opened 2 years ago Closed 2 years ago

Remove nsIAtomService

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsIAtomService is barely used in Firefox, and used a small amount in Thunderbird. Getting rid of it will allow us to deCOMtaminate nsIAtom (bug 1392883).
Depends on: 1392989
Holy smokes, if a script passes a string to an interface that expects an nsIAtom, XPConnect will atomize the string!

http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/js/xpconnect/src/XPCConvert.cpp#694-706

(That explains why editor/libeditor/tests/test_bug1140105.html was succeeding even after I changed its atoms to strings.)

Once nsIAtom is made non-scriptable, that conversion code can be removed.
Depends on: 1393371
Depends on: 1393692
Depends on: 1393642
The blocking bugs needs to be completed first, but this patch is ready for
review.
Attachment #8901061 - Flags: review?(nfroyd)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
Depends on: 1394298
Depends on: 1394299
Comment on attachment 8901061 [details] [diff] [review]
Remove nsIAtomService

Review of attachment 8901061 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for taking so long with this, this patch is great and trivial to review!
Attachment #8901061 - Flags: review?(nfroyd) → review+
No longer depends on: 1394299
https://hg.mozilla.org/mozilla-central/rev/a2cc3ce26632
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.