1392884 - Remove nsIAtomService

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Nicholas Nethercote [inactive]]

nsIAtomService is barely used in Firefox, and used a small amount in Thunderbird. Getting rid of it will allow us to deCOMtaminate nsIAtom (bug 1392883).

Comment 1

[Nicholas Nethercote [inactive]]

Holy smokes, if a script passes a string to an interface that expects an nsIAtom, XPConnect will atomize the string!

http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/js/xpconnect/src/XPCConvert.cpp#694-706

(That explains why editor/libeditor/tests/test_bug1140105.html was succeeding even after I changed its atoms to strings.)

Once nsIAtom is made non-scriptable, that conversion code can be removed.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Remove nsIAtomService

The blocking bugs needs to be completed first, but this patch is ready for
review.

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8901061 [details] [diff] [review]
Remove nsIAtomService

Review of attachment 8901061 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for taking so long with this, this patch is great and trivial to review!

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a2cc3ce26632a1551b822dce0b81dfae459c0b84
Bug 1392884 - Remove nsIAtomService. r=froydnj.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a2cc3ce26632