Remove all uses of nsIAtomService from DOM Inspector

RESOLVED INVALID

Status

RESOLVED INVALID
a year ago
9 months ago

People

(Reporter: njn, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
I am in the process of removing nsIAtomService (bug 1392884) in order to deCOMtaminate nsIAtom (bug  1392883).

DOM Inspector has a handful of nsIAtomService and nsIAtom uses in relation to some getRowProperties() and getCellProperties() methods, which I don't quite understand.

I'm not even sure what DOM Inspector's status is, given the decomissioning of legacy extensions in Firefox 57. Neil, do you have any thoughts?
Flags: needinfo?(neil)
(Reporter)

Comment 1

a year ago
Gijs informed me in bug 1394298 that the properties arguments to nsITreeView::get{Row,Cell}Properties were removed in Gecko 22. See https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsITreeView#getRowProperties for details.

Therefore, the construction of these properties lists should be removed, because they are unused, and they will break when I remove nsIAtomService.

I will mark this as not being a blocker for bug 1392884.
No longer blocks: 1392884
DOM Inpector is still compatible with older Gecko versions. The code is not executed in later versions. One day it will need to be cleaned up or retired but it is still ok with TB 58 and SeaMonkey 2.55.
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Flags: needinfo?(neil)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.